* [Buildroot] [PATCH] graphs: store and keep intermediate 'dot' program for graph-depends
@ 2014-04-19 20:17 Yann E. MORIN
2014-04-19 20:41 ` Maxime Hadjinlian
2014-04-19 21:53 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-04-19 20:17 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Currently, graph-depends (and PKG-graph-depends) do not store the
intermediate 'dot' program.
Some users would like to get the dot program to be able to further
customise the generated graphs (eg. modify the layout, colorise some
of the packages...)
So, store the intermediate dot program alongside the generated graph.
Reported-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
Makefile | 1 +
package/pkg-generic.mk | 1 +
2 files changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 42adf7c..dd47f77 100644
--- a/Makefile
+++ b/Makefile
@@ -670,6 +670,7 @@ graph-depends:
@$(INSTALL) -d $(O)/graphs
@cd "$(CONFIG_DIR)"; \
$(TOPDIR)/support/scripts/graph-depends -d $(BR_GRAPH_DEPTH) \
+ |tee $(O)/graphs/$(@).dot \
|dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT)
else # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 8a62d4c..cf02210 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -496,6 +496,7 @@ $(1)-graph-depends:
@$(INSTALL) -d $(O)/graphs
@cd "$(CONFIG_DIR)"; \
$(TOPDIR)/support/scripts/graph-depends -p $(1) -d $(BR_GRAPH_DEPTH) \
+ |tee $(O)/graphs/$$(@).dot \
|dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$$(@).$(BR_GRAPH_OUT)
$(1)-dirclean: $$($(2)_TARGET_DIRCLEAN)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] graphs: store and keep intermediate 'dot' program for graph-depends
2014-04-19 20:17 [Buildroot] [PATCH] graphs: store and keep intermediate 'dot' program for graph-depends Yann E. MORIN
@ 2014-04-19 20:41 ` Maxime Hadjinlian
2014-04-19 21:53 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Hadjinlian @ 2014-04-19 20:41 UTC (permalink / raw)
To: buildroot
Acked-by: "Maxime Hadjinlian" <maxime.hadjinlian@gmail.com>
On Sat, Apr 19, 2014 at 10:17 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Currently, graph-depends (and PKG-graph-depends) do not store the
> intermediate 'dot' program.
>
> Some users would like to get the dot program to be able to further
> customise the generated graphs (eg. modify the layout, colorise some
> of the packages...)
>
> So, store the intermediate dot program alongside the generated graph.
>
> Reported-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> Makefile | 1 +
> package/pkg-generic.mk | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 42adf7c..dd47f77 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -670,6 +670,7 @@ graph-depends:
> @$(INSTALL) -d $(O)/graphs
> @cd "$(CONFIG_DIR)"; \
> $(TOPDIR)/support/scripts/graph-depends -d $(BR_GRAPH_DEPTH) \
> + |tee $(O)/graphs/$(@).dot \
> |dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT)
>
> else # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 8a62d4c..cf02210 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -496,6 +496,7 @@ $(1)-graph-depends:
> @$(INSTALL) -d $(O)/graphs
> @cd "$(CONFIG_DIR)"; \
> $(TOPDIR)/support/scripts/graph-depends -p $(1) -d $(BR_GRAPH_DEPTH) \
> + |tee $(O)/graphs/$$(@).dot \
> |dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$$(@).$(BR_GRAPH_OUT)
>
> $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN)
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] graphs: store and keep intermediate 'dot' program for graph-depends
2014-04-19 20:17 [Buildroot] [PATCH] graphs: store and keep intermediate 'dot' program for graph-depends Yann E. MORIN
2014-04-19 20:41 ` Maxime Hadjinlian
@ 2014-04-19 21:53 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-04-19 21:53 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On Sat, 19 Apr 2014 22:17:08 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Currently, graph-depends (and PKG-graph-depends) do not store the
> intermediate 'dot' program.
>
> Some users would like to get the dot program to be able to further
> customise the generated graphs (eg. modify the layout, colorise some
> of the packages...)
>
> So, store the intermediate dot program alongside the generated graph.
>
> Reported-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-19 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-19 20:17 [Buildroot] [PATCH] graphs: store and keep intermediate 'dot' program for graph-depends Yann E. MORIN
2014-04-19 20:41 ` Maxime Hadjinlian
2014-04-19 21:53 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.