[meta-gnome][PATCH] abiword: force build order

[meta-gnome][PATCH] abiword: force build order

[Trevor Woerner]

Every time I try to build abiword my build fails:

	make[3]: *** No rule to make target `../goffice-bits2/libgoffice.la', needed by `libabiword-3.0.la'.  Stop.
	make[3]: Leaving directory
	`/SSD/build/distroless/tmp/qemuarm-eglibc/work/armv5te-oe-linux-gnueabi/abiword/3.0.0-r0/abiword-3.0.0/src'

I've tried a couple things, and this is what works for me.

I tried setting PARALLEL_MAKE to "" and it still fails. The odd thing is, the
Makefiles do show ../goffice-bits2/libgoffice.la as being a dependency of
libabiword-3.0.la (opt_libs), but it still doesn't guarantee the dependency is
built ahead of time (in fact, never on my system). Maybe this dependency is
buried too deep in variables?

Then I thought that maybe it was an autotools-brokensep problem and gave that
a try too, but it still failed. I even created a patch to change the
${top_builddir} to ${top_srcdir}, but it still failed.

Trevor Woerner (1):
  abiword: force build order

 meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
1.9.0

[meta-gnome][PATCH] abiword: force build order

[Trevor Woerner]

There is a race condition whereby "libgoffice.la" must be built (and exist)
before the rest of the code in "src" is built.

Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
---
 meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb b/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb
index 69d62ef..073622a 100644
--- a/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb
+++ b/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb
@@ -50,6 +50,14 @@ do_configure() {
     autotools_do_configure
 }
 
+do_compile() {
+    cd ${S}/goffice-bits2
+    make goffice-paths.h
+    make libgoffice.la
+    cd ${S}
+    oe_runmake
+}
+
 PACKAGES += " ${PN}-clipart ${PN}-strings ${PN}-systemprofiles ${PN}-templates "
 
 FILES_${PN} += " \
-- 
1.9.0

Re: [meta-gnome][PATCH] abiword: force build order

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

On Wed, Apr 09, 2014 at 10:12:51PM -0400, Trevor Woerner wrote:
> There is a race condition whereby "libgoffice.la" must be built (and exist)
> before the rest of the code in "src" is built.

Merged, thanks

> 
> Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
> ---
>  meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb b/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb
> index 69d62ef..073622a 100644
> --- a/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb
> +++ b/meta-gnome/recipes-gnome/abiword/abiword_3.0.0.bb
> @@ -50,6 +50,14 @@ do_configure() {
>      autotools_do_configure
>  }
>  
> +do_compile() {
> +    cd ${S}/goffice-bits2
> +    make goffice-paths.h
> +    make libgoffice.la
> +    cd ${S}
> +    oe_runmake
> +}
> +
>  PACKAGES += " ${PN}-clipart ${PN}-strings ${PN}-systemprofiles ${PN}-templates "
>  
>  FILES_${PN} += " \
> -- 
> 1.9.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]