Re: [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning

From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning
Date: Sun, 20 Apr 2014 12:34:41 +0200	[thread overview]
Message-ID: <20140420103441.GL2486@jama> (raw)
In-Reply-To: <1397581965-24301-1-git-send-email-jacob.kroon@mikrodidakt.se>

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On Tue, Apr 15, 2014 at 07:12:45PM +0200, Jacob Kroon wrote:
> Fixes the following warning:
> 
> WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead

It's correct patch, but I'm a bit tempted to take this patch after
branching daisy, because some people are using latest meta-qt5 with
older oe-core releases and this undoing this change is easy to miss
(unlike e.g. cmake .bbappends which fail when not updated for correct
oe-core releases).

What do you think?

Alternatively we can add wiki page about using latest meta-qt5 with
older oe-core and just document this there.

> Signed-off-by: Jacob Kroon <jacob.kroon@mikrodidakt.se>
> ---
>  classes/populate_sdk_qt5.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/populate_sdk_qt5.bbclass b/classes/populate_sdk_qt5.bbclass
> index c921983..7b31bbb 100644
> --- a/classes/populate_sdk_qt5.bbclass
> +++ b/classes/populate_sdk_qt5.bbclass
> @@ -53,4 +53,4 @@ toolchain_create_sdk_env_script_append () {
>      echo 'HostBinaries = ${SDKPATHNATIVE}${OE_QMAKE_PATH_HOST_BINS}' >> $qtconf
>  }
>  
> -PACKAGE_GROUP_qtcreator-debug = "packagegroup-qt5-qtcreator-debug"
> +FEATURE_PACKAGES_qtcreator-debug = "packagegroup-qt5-qtcreator-debug"
> -- 
> 1.9.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]