* [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning @ 2014-04-15 17:12 Jacob Kroon 2014-04-20 10:34 ` Martin Jansa 0 siblings, 1 reply; 5+ messages in thread From: Jacob Kroon @ 2014-04-15 17:12 UTC (permalink / raw) To: openembedded-devel Fixes the following warning: WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead Signed-off-by: Jacob Kroon <jacob.kroon@mikrodidakt.se> --- classes/populate_sdk_qt5.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/populate_sdk_qt5.bbclass b/classes/populate_sdk_qt5.bbclass index c921983..7b31bbb 100644 --- a/classes/populate_sdk_qt5.bbclass +++ b/classes/populate_sdk_qt5.bbclass @@ -53,4 +53,4 @@ toolchain_create_sdk_env_script_append () { echo 'HostBinaries = ${SDKPATHNATIVE}${OE_QMAKE_PATH_HOST_BINS}' >> $qtconf } -PACKAGE_GROUP_qtcreator-debug = "packagegroup-qt5-qtcreator-debug" +FEATURE_PACKAGES_qtcreator-debug = "packagegroup-qt5-qtcreator-debug" -- 1.9.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning 2014-04-15 17:12 [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning Jacob Kroon @ 2014-04-20 10:34 ` Martin Jansa 2014-04-20 13:54 ` Jacob Kroon 2014-04-20 20:21 ` Otavio Salvador 0 siblings, 2 replies; 5+ messages in thread From: Martin Jansa @ 2014-04-20 10:34 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1574 bytes --] On Tue, Apr 15, 2014 at 07:12:45PM +0200, Jacob Kroon wrote: > Fixes the following warning: > > WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead It's correct patch, but I'm a bit tempted to take this patch after branching daisy, because some people are using latest meta-qt5 with older oe-core releases and this undoing this change is easy to miss (unlike e.g. cmake .bbappends which fail when not updated for correct oe-core releases). What do you think? Alternatively we can add wiki page about using latest meta-qt5 with older oe-core and just document this there. > Signed-off-by: Jacob Kroon <jacob.kroon@mikrodidakt.se> > --- > classes/populate_sdk_qt5.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/classes/populate_sdk_qt5.bbclass b/classes/populate_sdk_qt5.bbclass > index c921983..7b31bbb 100644 > --- a/classes/populate_sdk_qt5.bbclass > +++ b/classes/populate_sdk_qt5.bbclass > @@ -53,4 +53,4 @@ toolchain_create_sdk_env_script_append () { > echo 'HostBinaries = ${SDKPATHNATIVE}${OE_QMAKE_PATH_HOST_BINS}' >> $qtconf > } > > -PACKAGE_GROUP_qtcreator-debug = "packagegroup-qt5-qtcreator-debug" > +FEATURE_PACKAGES_qtcreator-debug = "packagegroup-qt5-qtcreator-debug" > -- > 1.9.0 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning 2014-04-20 10:34 ` Martin Jansa @ 2014-04-20 13:54 ` Jacob Kroon 2014-04-20 20:23 ` Otavio Salvador 2014-04-20 20:21 ` Otavio Salvador 1 sibling, 1 reply; 5+ messages in thread From: Jacob Kroon @ 2014-04-20 13:54 UTC (permalink / raw) To: openembedded-devel Hi Martin, On Sun, Apr 20, 2014 at 12:34 PM, Martin Jansa <martin.jansa@gmail.com>wrote: > On Tue, Apr 15, 2014 at 07:12:45PM +0200, Jacob Kroon wrote: > > Fixes the following warning: > > > > WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead > > It's correct patch, but I'm a bit tempted to take this patch after > branching daisy, because some people are using latest meta-qt5 with > older oe-core releases and this undoing this change is easy to miss > (unlike e.g. cmake .bbappends which fail when not updated for correct > oe-core releases). > > What do you think? > > I think I follow you. So the deprecation happened in commit d703e07ea5056624101e1bc48f10d25b602635e9, 2014-03-07, so I guess only daisy/master will give the warning. For older oe-core releases with meta-qt5 master, this patch could silently break stuff I can imagine. So like you propose, keeping this one for master only, after branching daisy, seems like a good idea to me. /Jacob ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning 2014-04-20 13:54 ` Jacob Kroon @ 2014-04-20 20:23 ` Otavio Salvador 0 siblings, 0 replies; 5+ messages in thread From: Otavio Salvador @ 2014-04-20 20:23 UTC (permalink / raw) To: OpenEmbedded Devel List On Sun, Apr 20, 2014 at 10:54 AM, Jacob Kroon <jacob.kroon@gmail.com> wrote: > Hi Martin, > > On Sun, Apr 20, 2014 at 12:34 PM, Martin Jansa <martin.jansa@gmail.com>wrote: > >> On Tue, Apr 15, 2014 at 07:12:45PM +0200, Jacob Kroon wrote: >> > Fixes the following warning: >> > >> > WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead >> >> It's correct patch, but I'm a bit tempted to take this patch after >> branching daisy, because some people are using latest meta-qt5 with >> older oe-core releases and this undoing this change is easy to miss >> (unlike e.g. cmake .bbappends which fail when not updated for correct >> oe-core releases). >> >> What do you think? >> >> > I think I follow you. So the deprecation happened in commit > d703e07ea5056624101e1bc48f10d25b602635e9, 2014-03-07, so I guess only > daisy/master will give the warning. For older oe-core releases with > meta-qt5 master, this patch could silently break stuff I can imagine. So > like you propose, keeping this one for master only, after branching daisy, > seems like a good idea to me. I prefer to drop the warning in daisy. It is always bad to have warnings during the build and we ought to have it clean. As I said, this will indeed break people but not many people are using this class as this is quite new. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning 2014-04-20 10:34 ` Martin Jansa 2014-04-20 13:54 ` Jacob Kroon @ 2014-04-20 20:21 ` Otavio Salvador 1 sibling, 0 replies; 5+ messages in thread From: Otavio Salvador @ 2014-04-20 20:21 UTC (permalink / raw) To: OpenEmbedded Devel List Hello Martin, On Sun, Apr 20, 2014 at 7:34 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > On Tue, Apr 15, 2014 at 07:12:45PM +0200, Jacob Kroon wrote: >> Fixes the following warning: >> >> WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead > > It's correct patch, but I'm a bit tempted to take this patch after > branching daisy, because some people are using latest meta-qt5 with > older oe-core releases and this undoing this change is easy to miss > (unlike e.g. cmake .bbappends which fail when not updated for correct > oe-core releases). > > What do you think? > > Alternatively we can add wiki page about using latest meta-qt5 with > older oe-core and just document this there. I am one of those guys using it with older releases. However I think we ought to have it clean so I am in favor of merging as this is really a nice fix. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-20 20:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-15 17:12 [meta-qt5][PATCH] populate_sdk_qt5.bbclass: Fix PACKAGE_GROUP deprecation warning Jacob Kroon 2014-04-20 10:34 ` Martin Jansa 2014-04-20 13:54 ` Jacob Kroon 2014-04-20 20:23 ` Otavio Salvador 2014-04-20 20:21 ` Otavio Salvador
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.