* [meta-oe][PATCH 0/2] eject: fix multilib builds and wrong return value of usage @ 2014-04-09 6:27 jackie.huang 2014-04-09 6:27 ` [meta-oe][PATCH 1/2] eject: fix multilib builds jackie.huang 2014-04-09 6:27 ` [meta-oe][PATCH 2/2] eject: Fix wrong return value jackie.huang 0 siblings, 2 replies; 9+ messages in thread From: jackie.huang @ 2014-04-09 6:27 UTC (permalink / raw) To: openembedded-devel From: Jackie Huang <jackie.huang@windriver.com> --- The following changes since commit bc969d3705c45928de8525ef3d2d9d2867311864: inetutils: add -dbg packages for tftpd, telnetd and rshd (2014-04-02 11:18:54 -0400) are available in the git repository at: git://git.pokylinux.org/poky-contrib jhuang0/r_eject_1 http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/r_eject_1 Jackie Huang (2): eject: fix multilib builds eject: Fix wrong return value .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ meta-oe/recipes-support/eject/eject_2.1.5.bb | 6 ++++-- 2 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch -- 1.7.9.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [meta-oe][PATCH 1/2] eject: fix multilib builds 2014-04-09 6:27 [meta-oe][PATCH 0/2] eject: fix multilib builds and wrong return value of usage jackie.huang @ 2014-04-09 6:27 ` jackie.huang 2014-04-20 11:21 ` Martin Jansa 2014-04-09 6:27 ` [meta-oe][PATCH 2/2] eject: Fix wrong return value jackie.huang 1 sibling, 1 reply; 9+ messages in thread From: jackie.huang @ 2014-04-09 6:27 UTC (permalink / raw) To: openembedded-devel From: Jackie Huang <jackie.huang@windriver.com> Use BPN instead of PN, BP instead of P to fix the multilib builds. Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> --- meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta-oe/recipes-support/eject/eject_2.1.5.bb b/meta-oe/recipes-support/eject/eject_2.1.5.bb index 3f2c90d..98319a3 100644 --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb @@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" inherit autotools gettext update-alternatives -SRC_URI = "http://sources.openembedded.org/${P}.tar.gz" +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" -S = "${WORKDIR}/${PN}" +S = "${WORKDIR}/${BPN}" PR = "r1" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/2] eject: fix multilib builds 2014-04-09 6:27 ` [meta-oe][PATCH 1/2] eject: fix multilib builds jackie.huang @ 2014-04-20 11:21 ` Martin Jansa 0 siblings, 0 replies; 9+ messages in thread From: Martin Jansa @ 2014-04-20 11:21 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1527 bytes --] On Wed, Apr 09, 2014 at 02:27:08PM +0800, jackie.huang@windriver.com wrote: > From: Jackie Huang <jackie.huang@windriver.com> > > Use BPN instead of PN, BP instead of P to fix the multilib builds. Merged, thanks! > > Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > --- > meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/recipes-support/eject/eject_2.1.5.bb b/meta-oe/recipes-support/eject/eject_2.1.5.bb > index 3f2c90d..98319a3 100644 > --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb > +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb > @@ -5,12 +5,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" > > inherit autotools gettext update-alternatives > > -SRC_URI = "http://sources.openembedded.org/${P}.tar.gz" > +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" > > SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" > SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" > > -S = "${WORKDIR}/${PN}" > +S = "${WORKDIR}/${BPN}" > > PR = "r1" > > -- > 1.7.9.5 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [meta-oe][PATCH 2/2] eject: Fix wrong return value 2014-04-09 6:27 [meta-oe][PATCH 0/2] eject: fix multilib builds and wrong return value of usage jackie.huang 2014-04-09 6:27 ` [meta-oe][PATCH 1/2] eject: fix multilib builds jackie.huang @ 2014-04-09 6:27 ` jackie.huang 2014-04-09 8:13 ` Khem Raj 1 sibling, 1 reply; 9+ messages in thread From: jackie.huang @ 2014-04-09 6:27 UTC (permalink / raw) To: openembedded-devel From: Jackie Huang <jackie.huang@windriver.com> Remove the unnecessary return(1) from function usage(), so that eject -h can return the right value. Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> --- .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 +++- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch diff --git a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch new file mode 100644 index 0000000..2cce3c3 --- /dev/null +++ b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch @@ -0,0 +1,10 @@ +Upstream-Status: Pending + +--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800 ++++ eject/eject.c 2013-09-11 18:09:05.000000000 +0800 +@@ -207,7 +207,6 @@ + "If omitted, name defaults to `%s'.\n" + "By default tries -r, -s, -f, and -q in order until success.\n"), + DEFAULTDEVICE); +- exit(1); + } diff --git a/meta-oe/recipes-support/eject/eject_2.1.5.bb b/meta-oe/recipes-support/eject/eject_2.1.5.bb index 98319a3..c47c653 100644 --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb @@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" inherit autotools gettext update-alternatives -SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \ + file://eject-2.1.5-error-return.patch \ +" SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value 2014-04-09 6:27 ` [meta-oe][PATCH 2/2] eject: Fix wrong return value jackie.huang @ 2014-04-09 8:13 ` Khem Raj 2014-04-09 8:35 ` Huang, Jie (Jackie) 0 siblings, 1 reply; 9+ messages in thread From: Khem Raj @ 2014-04-09 8:13 UTC (permalink / raw) To: openembedded-devel On Apr 8, 2014 8:27 PM, <jackie.huang@windriver.com> wrote: > > From: Jackie Huang <jackie.huang@windriver.com> > > Remove the unnecessary return(1) from function usage(), so that eject -h > can return the right value. this is an API change i wonder if other programs rely on the value being >0 > > Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > --- > .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ > meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 +++- > 2 files changed, 13 insertions(+), 1 deletion(-) > create mode 100644 meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > diff --git a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > new file mode 100644 > index 0000000..2cce3c3 > --- /dev/null > +++ b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > @@ -0,0 +1,10 @@ > +Upstream-Status: Pending > + > +--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800 > ++++ eject/eject.c 2013-09-11 18:09:05.000000000 +0800 > +@@ -207,7 +207,6 @@ > + "If omitted, name defaults to `%s'.\n" > + "By default tries -r, -s, -f, and -q in order until success.\n"), > + DEFAULTDEVICE); > +- exit(1); > + } > diff --git a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-support/eject/ eject_2.1.5.bb > index 98319a3..c47c653 100644 > --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb > +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb > @@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" > > inherit autotools gettext update-alternatives > > -SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" > +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \ > + file://eject-2.1.5-error-return.patch \ > +" > > SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" > SRC_URI[sha256sum] = "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" > -- > 1.7.9.5 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value 2014-04-09 8:13 ` Khem Raj @ 2014-04-09 8:35 ` Huang, Jie (Jackie) 2014-04-09 15:49 ` Khem Raj 0 siblings, 1 reply; 9+ messages in thread From: Huang, Jie (Jackie) @ 2014-04-09 8:35 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org > -----Original Message----- > From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel- > bounces@lists.openembedded.org] On Behalf Of Khem Raj > Sent: Wednesday, April 09, 2014 4:13 PM > To: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value > > On Apr 8, 2014 8:27 PM, <jackie.huang@windriver.com> wrote: > > > > From: Jackie Huang <jackie.huang@windriver.com> > > > > Remove the unnecessary return(1) from function usage(), so that eject > > -h can return the right value. > > this is an API change i wonder if other programs rely on the value being >0 I think the answer should be no, I don't see any reason to return 1 for the "-h" or "--help", almost all programs return 0 for that, right? Thanks, Jackie > > > > Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com> > > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > > --- > > .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ > > meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 +++- > > 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 > meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > diff --git > a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > new file mode 100644 > > index 0000000..2cce3c3 > > --- /dev/null > > +++ b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > @@ -0,0 +1,10 @@ > > +Upstream-Status: Pending > > + > > +--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800 > > ++++ eject/eject.c 2013-09-11 18:09:05.000000000 +0800 > > +@@ -207,7 +207,6 @@ > > + "If omitted, name defaults to `%s'.\n" > > + "By default tries -r, -s, -f, and -q in order until success.\n"), > > + DEFAULTDEVICE); > > +- exit(1); > > + } > > diff --git a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-support/eject/ > eject_2.1.5.bb > > index 98319a3..c47c653 100644 > > --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb > > +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb > > @@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = > "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" > > > > inherit autotools gettext update-alternatives > > > > -SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" > > +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \ > > + file://eject-2.1.5-error-return.patch \ > > +" > > > > SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" > > SRC_URI[sha256sum] = > "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" > > -- > > 1.7.9.5 > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value 2014-04-09 8:35 ` Huang, Jie (Jackie) @ 2014-04-09 15:49 ` Khem Raj 2014-04-10 1:14 ` Huang, Jie (Jackie) 0 siblings, 1 reply; 9+ messages in thread From: Khem Raj @ 2014-04-09 15:49 UTC (permalink / raw) To: openembedded-devel On Apr 8, 2014 10:36 PM, "Huang, Jie (Jackie)" <Jackie.Huang@windriver.com> wrote: > > > > > -----Original Message----- > > From: openembedded-devel-bounces@lists.openembedded.org [mailto: openembedded-devel- > > bounces@lists.openembedded.org] On Behalf Of Khem Raj > > Sent: Wednesday, April 09, 2014 4:13 PM > > To: openembedded-devel@lists.openembedded.org > > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value > > > > On Apr 8, 2014 8:27 PM, <jackie.huang@windriver.com> wrote: > > > > > > From: Jackie Huang <jackie.huang@windriver.com> > > > > > > Remove the unnecessary return(1) from function usage(), so that eject > > > -h can return the right value. > > > > this is an API change i wonder if other programs rely on the value being >0 > > I think the answer should be no, I don't see any reason to return 1 for the "-h" or > "--help", almost all programs return 0 for that, right? > mostly yes and change is ok too just discuss it with package community and see if this is ok. > Thanks, > Jackie > > > > > > > Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com> > > > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > > > --- > > > .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ > > > meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 +++- > > > 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 > > meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > > > diff --git > > a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > new file mode 100644 > > > index 0000000..2cce3c3 > > > --- /dev/null > > > +++ b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > @@ -0,0 +1,10 @@ > > > +Upstream-Status: Pending > > > + > > > +--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800 > > > ++++ eject/eject.c 2013-09-11 18:09:05.000000000 +0800 > > > +@@ -207,7 +207,6 @@ > > > + "If omitted, name defaults to `%s'.\n" > > > + "By default tries -r, -s, -f, and -q in order until success.\n"), > > > + DEFAULTDEVICE); > > > +- exit(1); > > > + } > > > diff --git a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-support/eject/ > > eject_2.1.5.bb > > > index 98319a3..c47c653 100644 > > > --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb > > > +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb > > > @@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = > > "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" > > > > > > inherit autotools gettext update-alternatives > > > > > > -SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" > > > +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \ > > > + file://eject-2.1.5-error-return.patch \ > > > +" > > > > > > SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" > > > SRC_URI[sha256sum] = > > "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" > > > -- > > > 1.7.9.5 > > > > > > -- > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value 2014-04-09 15:49 ` Khem Raj @ 2014-04-10 1:14 ` Huang, Jie (Jackie) 2014-04-22 8:23 ` Huang, Jie (Jackie) 0 siblings, 1 reply; 9+ messages in thread From: Huang, Jie (Jackie) @ 2014-04-10 1:14 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org > -----Original Message----- > From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel- > bounces@lists.openembedded.org] On Behalf Of Khem Raj > Sent: Wednesday, April 09, 2014 11:49 PM > To: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value > > On Apr 8, 2014 10:36 PM, "Huang, Jie (Jackie)" <Jackie.Huang@windriver.com> > wrote: > > > > > > > > > -----Original Message----- > > > From: openembedded-devel-bounces@lists.openembedded.org [mailto: > openembedded-devel- > > > bounces@lists.openembedded.org] On Behalf Of Khem Raj > > > Sent: Wednesday, April 09, 2014 4:13 PM > > > To: openembedded-devel@lists.openembedded.org > > > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value > > > > > > On Apr 8, 2014 8:27 PM, <jackie.huang@windriver.com> wrote: > > > > > > > > From: Jackie Huang <jackie.huang@windriver.com> > > > > > > > > Remove the unnecessary return(1) from function usage(), so that > > > > eject -h can return the right value. > > > > > > this is an API change i wonder if other programs rely on the value > being >0 > > > > I think the answer should be no, I don't see any reason to return 1 > > for > the "-h" or > > "--help", almost all programs return 0 for that, right? > > > > mostly yes and change is ok too just discuss it with package community and see if this is ok. Yeah, sure, I will send it to the community, thanks! Thanks, Jackie > > Thanks, > > Jackie > > > > > > > > > > Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com> > > > > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > > > > --- > > > > .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ > > > > meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 +++- > > > > 2 files changed, 13 insertions(+), 1 deletion(-) create mode > > > > 100644 > > > meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > > > > > diff --git > > > a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > new file mode 100644 > > > > index 0000000..2cce3c3 > > > > --- /dev/null > > > > +++ > b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > @@ -0,0 +1,10 @@ > > > > +Upstream-Status: Pending > > > > + > > > > +--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800 > > > > ++++ eject/eject.c 2013-09-11 18:09:05.000000000 +0800 > > > > +@@ -207,7 +207,6 @@ > > > > + "If omitted, name defaults to `%s'.\n" > > > > + "By default tries -r, -s, -f, and -q in order until success.\n"), > > > > + DEFAULTDEVICE); > > > > +- exit(1); > > > > + } > > > > diff --git > a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-support/eject/ > > > eject_2.1.5.bb > > > > index 98319a3..c47c653 100644 > > > > --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb > > > > +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb > > > > @@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = > > > "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" > > > > > > > > inherit autotools gettext update-alternatives > > > > > > > > -SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" > > > > +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \ > > > > + file://eject-2.1.5-error-return.patch \ " > > > > > > > > SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" > > > > SRC_URI[sha256sum] = > > > "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" > > > > -- > > > > 1.7.9.5 > > > > > > > > -- > > > > _______________________________________________ > > > > Openembedded-devel mailing list > > > > Openembedded-devel@lists.openembedded.org > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > -- > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] eject: Fix wrong return value 2014-04-10 1:14 ` Huang, Jie (Jackie) @ 2014-04-22 8:23 ` Huang, Jie (Jackie) 0 siblings, 0 replies; 9+ messages in thread From: Huang, Jie (Jackie) @ 2014-04-22 8:23 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org > -----Original Message----- > From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel- > bounces@lists.openembedded.org] On Behalf Of Huang, Jie (Jackie) > Sent: Thursday, April 10, 2014 9:15 AM > To: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value > > > > > -----Original Message----- > > From: openembedded-devel-bounces@lists.openembedded.org > > [mailto:openembedded-devel- bounces@lists.openembedded.org] On Behalf > > Of Khem Raj > > Sent: Wednesday, April 09, 2014 11:49 PM > > To: openembedded-devel@lists.openembedded.org > > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return value > > > > On Apr 8, 2014 10:36 PM, "Huang, Jie (Jackie)" > > <Jackie.Huang@windriver.com> > > wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: openembedded-devel-bounces@lists.openembedded.org [mailto: > > openembedded-devel- > > > > bounces@lists.openembedded.org] On Behalf Of Khem Raj > > > > Sent: Wednesday, April 09, 2014 4:13 PM > > > > To: openembedded-devel@lists.openembedded.org > > > > Subject: Re: [oe] [meta-oe][PATCH 2/2] eject: Fix wrong return > > > > value > > > > > > > > On Apr 8, 2014 8:27 PM, <jackie.huang@windriver.com> wrote: > > > > > > > > > > From: Jackie Huang <jackie.huang@windriver.com> > > > > > > > > > > Remove the unnecessary return(1) from function usage(), so that > > > > > eject -h can return the right value. > > > > > > > > this is an API change i wonder if other programs rely on the value > > being >0 > > > > > > I think the answer should be no, I don't see any reason to return 1 > > > for > > the "-h" or > > > "--help", almost all programs return 0 for that, right? > > > > > > > mostly yes and change is ok too just discuss it with package community and see if this is ok. > > Yeah, sure, I will send it to the community, thanks! The latest update on the upstream is 6 years ago: http://eject.cvs.sourceforge.net/viewvc/eject/eject/eject/ and the mailing list is no longer available. So I will update the Upstream-Status and send v2 for this. Thanks, Jackie > > Thanks, > Jackie > > > > > Thanks, > > > Jackie > > > > > > > > > > > > > Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com> > > > > > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > > > > > --- > > > > > .../eject/eject/eject-2.1.5-error-return.patch | 10 ++++++++++ > > > > > meta-oe/recipes-support/eject/eject_2.1.5.bb | 4 +++- > > > > > 2 files changed, 13 insertions(+), 1 deletion(-) create mode > > > > > 100644 > > > > meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > > > > > > > diff --git > > > > a/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.pat > > > > ch > > > > b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.pat > > > > ch > > > > > new file mode 100644 > > > > > index 0000000..2cce3c3 > > > > > --- /dev/null > > > > > +++ > > b/meta-oe/recipes-support/eject/eject/eject-2.1.5-error-return.patch > > > > > @@ -0,0 +1,10 @@ > > > > > +Upstream-Status: Pending > > > > > + > > > > > +--- eject/eject.c.orig 2013-09-11 18:08:36.000000000 +0800 > > > > > ++++ eject/eject.c 2013-09-11 18:09:05.000000000 +0800 > > > > > +@@ -207,7 +207,6 @@ > > > > > + "If omitted, name defaults to `%s'.\n" > > > > > + "By default tries -r, -s, -f, and -q in order until success.\n"), > > > > > + DEFAULTDEVICE); > > > > > +- exit(1); > > > > > + } > > > > > diff --git > > a/meta-oe/recipes-support/eject/eject_2.1.5.bbb/meta-oe/recipes-suppor > > t/eject/ > > > > eject_2.1.5.bb > > > > > index 98319a3..c47c653 100644 > > > > > --- a/meta-oe/recipes-support/eject/eject_2.1.5.bb > > > > > +++ b/meta-oe/recipes-support/eject/eject_2.1.5.bb > > > > > @@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = > > > > "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" > > > > > > > > > > inherit autotools gettext update-alternatives > > > > > > > > > > -SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz" > > > > > +SRC_URI = "http://sources.openembedded.org/${BP}.tar.gz \ > > > > > + file://eject-2.1.5-error-return.patch \ " > > > > > > > > > > SRC_URI[md5sum] = "b96a6d4263122f1711db12701d79f738" > > > > > SRC_URI[sha256sum] = > > > > "ef9f7906484cfde4ba223b2682a37058f9a3c7d3bb1adda7a34a67402e2ffe55" > > > > > -- > > > > > 1.7.9.5 > > > > > > > > > > -- > > > > > _______________________________________________ > > > > > Openembedded-devel mailing list > > > > > Openembedded-devel@lists.openembedded.org > > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-deve > > > > > l > > > > -- > > > > _______________________________________________ > > > > Openembedded-devel mailing list > > > > Openembedded-devel@lists.openembedded.org > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > -- > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-22 8:23 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-09 6:27 [meta-oe][PATCH 0/2] eject: fix multilib builds and wrong return value of usage jackie.huang 2014-04-09 6:27 ` [meta-oe][PATCH 1/2] eject: fix multilib builds jackie.huang 2014-04-20 11:21 ` Martin Jansa 2014-04-09 6:27 ` [meta-oe][PATCH 2/2] eject: Fix wrong return value jackie.huang 2014-04-09 8:13 ` Khem Raj 2014-04-09 8:35 ` Huang, Jie (Jackie) 2014-04-09 15:49 ` Khem Raj 2014-04-10 1:14 ` Huang, Jie (Jackie) 2014-04-22 8:23 ` Huang, Jie (Jackie)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.