From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [wireless-next][PATCH 1/2] b43: ssb: refuse to support more than IEEE 802.11 core
Date: Sun, 20 Apr 2014 20:54:52 +0200 [thread overview]
Message-ID: <20140420205452.79a95330@wiggum> (raw)
In-Reply-To: <1398018659-17263-1-git-send-email-zajec5@gmail.com>
On Sun, 20 Apr 2014 20:30:58 +0200
Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 69fc3d6..cf84cf2 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5486,39 +5486,42 @@ int b43_ssb_probe(struct ssb_device *sdev, const struct ssb_device_id *id)
> struct b43_bus_dev *dev;
> struct b43_wl *wl;
> int err;
> - int first = 0;
>
> dev = b43_bus_dev_ssb_init(sdev);
> if (!dev)
> return -ENOMEM;
>
> wl = ssb_get_devtypedata(sdev);
The whole "struct b43_wl" and "ssb_get_devtypedata" was to support multiple
cores of the same type in a single driver instance (= b43 multicore).
With multicore support being removed, everything in b43_wl could be merged into b43_wldev.
Also the use of ssb_get_devtypedata could probably be removed, too.
This will simplify a lot of the b43 startup and shutdown code.
--
Michael.
----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20140420/26c99456/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [wireless-next][PATCH 1/2] b43: ssb: refuse to support more than IEEE 802.11 core
Date: Sun, 20 Apr 2014 20:54:52 +0200 [thread overview]
Message-ID: <20140420205452.79a95330@wiggum> (raw)
In-Reply-To: <1398018659-17263-1-git-send-email-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]
On Sun, 20 Apr 2014 20:30:58 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 69fc3d6..cf84cf2 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5486,39 +5486,42 @@ int b43_ssb_probe(struct ssb_device *sdev, const struct ssb_device_id *id)
> struct b43_bus_dev *dev;
> struct b43_wl *wl;
> int err;
> - int first = 0;
>
> dev = b43_bus_dev_ssb_init(sdev);
> if (!dev)
> return -ENOMEM;
>
> wl = ssb_get_devtypedata(sdev);
The whole "struct b43_wl" and "ssb_get_devtypedata" was to support multiple
cores of the same type in a single driver instance (= b43 multicore).
With multicore support being removed, everything in b43_wl could be merged into b43_wldev.
Also the use of ssb_get_devtypedata could probably be removed, too.
This will simplify a lot of the b43 startup and shutdown code.
--
Michael.
----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-20 18:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 18:30 [wireless-next][PATCH 1/2] b43: ssb: refuse to support more than IEEE 802.11 core Rafał Miłecki
2014-04-20 18:30 ` Rafał Miłecki
2014-04-20 18:30 ` [wireless-next][PATCH 2/2] b43: remove leftover code for dual-core devices support Rafał Miłecki
2014-04-20 18:30 ` Rafał Miłecki
2014-04-21 8:54 ` [wireless-next][PATCH V2 2/2] b43: remove list of IEEE 802.11 devices Rafał Miłecki
2014-04-21 8:54 ` Rafał Miłecki
2014-04-20 18:54 ` Michael Büsch [this message]
2014-04-20 18:54 ` [wireless-next][PATCH 1/2] b43: ssb: refuse to support more than IEEE 802.11 core Michael Büsch
2014-04-20 19:29 ` Rafał Miłecki
2014-04-20 19:29 ` Rafał Miłecki
2014-04-20 22:36 ` Michael Büsch
2014-04-20 22:36 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420205452.79a95330@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.