Re: [meta-networking][PATCH 1/2] vsftpd: fix install warning

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

On Mon, Apr 21, 2014 at 01:53:27AM -0400, wenzong.fan@windriver.com wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> WARNING: QA Issue: vsftpd: Files/directories were installed but not shipped
>   /run
>   /run/vsftpd
>   /run/vsftpd/empty

I'm glad to see fix for QA, but I don't think that everybody is using
populate-volatile.sh for volatiles (e.g. images with systemd).

> Signed-off-by: Li Wang <li.wang@windriver.com>
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  .../recipes-daemons/vsftpd/vsftpd_3.0.0.bb         |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
> index 0698a63..2cf9ac3 100644
> --- a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
> +++ b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
> @@ -70,7 +70,6 @@ do_install() {
>          sed -i "s:/lib/security:${base_libdir}/security:" ${D}${sysconfdir}/pam.d/vsftpd
>          sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd
>      fi
> -    install -d ${D}${localstatedir}/run/vsftpd/empty
>  }
>  
>  INITSCRIPT_PACKAGES = "${PN}"
> @@ -82,3 +81,11 @@ USERADD_PARAM_${PN} = "--system --home-dir /var/lib/ftp --no-create-home -g ftp
>                         --shell /bin/false ftp "
>  GROUPADD_PARAM_${PN} = "-r ftp"
>  
> +pkg_postinst_${PN}() {
> +	if [ -n "$D" ]; then
> +		exit 0
> +	fi
> +	if [ -e /etc/init.d/populate-volatile.sh ]; then
> +		/etc/init.d/populate-volatile.sh update
> +	fi
> +}
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]