All of lore.kernel.org
 help / color / mirror / Atom feed
From: wenzong fan <wenzong.fan@windriver.com>
To: <openembedded-devel@lists.openembedded.org>,
	Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [meta-networking][PATCH 1/2] vsftpd: fix install warning - [withdrawn]
Date: Wed, 23 Apr 2014 16:31:40 +0800	[thread overview]
Message-ID: <53577A6C.9050006@windriver.com> (raw)
In-Reply-To: <20140421075832.GV2486@jama>

On 04/21/2014 03:58 PM, Martin Jansa wrote:
> On Mon, Apr 21, 2014 at 01:53:27AM -0400, wenzong.fan@windriver.com wrote:
>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>
>> WARNING: QA Issue: vsftpd: Files/directories were installed but not shipped
>>    /run
>>    /run/vsftpd
>>    /run/vsftpd/empty
>
> I'm glad to see fix for QA, but I don't think that everybody is using
> populate-volatile.sh for volatiles (e.g. images with systemd).

Good point, while I searching the thread I found there's another patch 
tried to process this issue but still not merged:

[oe] [meta-networking][PATCH] vsftpd: install volatiles file based on 
init system

I withdraw my patch and waiting for the upstream fixes:)

Thanks
Wenzong

>
>> Signed-off-by: Li Wang <li.wang@windriver.com>
>> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
>> ---
>>   .../recipes-daemons/vsftpd/vsftpd_3.0.0.bb         |    9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
>> index 0698a63..2cf9ac3 100644
>> --- a/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
>> +++ b/meta-networking/recipes-daemons/vsftpd/vsftpd_3.0.0.bb
>> @@ -70,7 +70,6 @@ do_install() {
>>           sed -i "s:/lib/security:${base_libdir}/security:" ${D}${sysconfdir}/pam.d/vsftpd
>>           sed -i "s:ftpusers:vsftpd.ftpusers:" ${D}${sysconfdir}/pam.d/vsftpd
>>       fi
>> -    install -d ${D}${localstatedir}/run/vsftpd/empty
>>   }
>>
>>   INITSCRIPT_PACKAGES = "${PN}"
>> @@ -82,3 +81,11 @@ USERADD_PARAM_${PN} = "--system --home-dir /var/lib/ftp --no-create-home -g ftp
>>                          --shell /bin/false ftp "
>>   GROUPADD_PARAM_${PN} = "-r ftp"
>>
>> +pkg_postinst_${PN}() {
>> +	if [ -n "$D" ]; then
>> +		exit 0
>> +	fi
>> +	if [ -e /etc/init.d/populate-volatile.sh ]; then
>> +		/etc/init.d/populate-volatile.sh update
>> +	fi
>> +}
>> --
>> 1.7.9.5
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>


  reply	other threads:[~2014-04-23  8:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21  5:53 [meta-networking][PATCH 0/2] some fixes for vsftpd and ntp scripts wenzong.fan
2014-04-21  5:53 ` [meta-networking][PATCH 1/2] vsftpd: fix install warning wenzong.fan
2014-04-21  7:58   ` Martin Jansa
2014-04-23  8:31     ` wenzong fan [this message]
2014-04-21  5:53 ` [meta-networking][PATCH 2/2] ntp: fix hardcode to /usr/bin/perl wenzong.fan
2014-04-25  1:21   ` Joe MacDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53577A6C.9050006@windriver.com \
    --to=wenzong.fan@windriver.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.