From: Andy Gross <agross@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/4] soc: qcom: Add GSBI driver
Date: Mon, 21 Apr 2014 12:11:18 -0500 [thread overview]
Message-ID: <20140421171117.GB32485@qualcomm.com> (raw)
In-Reply-To: <20140421165400.GA11778@joshc.qualcomm.com>
On Mon, Apr 21, 2014 at 11:54:00AM -0500, Josh Cartwright wrote:
<snip>
> > +
> > +struct gsbi_dev {
> > + struct device *dev;
> > + void __iomem *base;
>
> You don't really need these.
Old habits die hard. I'll remove.
<snip>
> > + if (of_property_read_u32(node, "qcom,mode", &mode)) {
> > + dev_err(gsbi->dev, "missing mode configuration\n");
> > + return -EINVAL;
> > + }
>
> I'm wondering if you should really be a (very simple) pinctrl driver
> proper.
Perhaps. But how would i reconcile more than one device node that uses the same
GSBI? One could still trounce the other unless I only allow one setting of the
GSBI.
<snip>
> > + clk_prepare_enable(gsbi->hclk);
> > +
> > + writel_relaxed((mode << GSBI_PROTOCOL_SHIFT), gsbi + GSBI_CTRL_REG);
>
> Did you mean: gsbi->base + GSBI_CTRL_REG ?
Ouch, how did this get munged. I'll fix this on resend.
<snip>
> > +
> > +static struct of_device_id gsbi_dt_match[] = {
>
> const
Will fix.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: agross@codeaurora.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] soc: qcom: Add GSBI driver
Date: Mon, 21 Apr 2014 12:11:18 -0500 [thread overview]
Message-ID: <20140421171117.GB32485@qualcomm.com> (raw)
In-Reply-To: <20140421165400.GA11778@joshc.qualcomm.com>
On Mon, Apr 21, 2014 at 11:54:00AM -0500, Josh Cartwright wrote:
<snip>
> > +
> > +struct gsbi_dev {
> > + struct device *dev;
> > + void __iomem *base;
>
> You don't really need these.
Old habits die hard. I'll remove.
<snip>
> > + if (of_property_read_u32(node, "qcom,mode", &mode)) {
> > + dev_err(gsbi->dev, "missing mode configuration\n");
> > + return -EINVAL;
> > + }
>
> I'm wondering if you should really be a (very simple) pinctrl driver
> proper.
Perhaps. But how would i reconcile more than one device node that uses the same
GSBI? One could still trounce the other unless I only allow one setting of the
GSBI.
<snip>
> > + clk_prepare_enable(gsbi->hclk);
> > +
> > + writel_relaxed((mode << GSBI_PROTOCOL_SHIFT), gsbi + GSBI_CTRL_REG);
>
> Did you mean: gsbi->base + GSBI_CTRL_REG ?
Ouch, how did this get munged. I'll fix this on resend.
<snip>
> > +
> > +static struct of_device_id gsbi_dt_match[] = {
>
> const
Will fix.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-21 17:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 5:30 [PATCH 0/4] Introduce drivers/soc and add QCOM GSBI driver Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 5:30 ` [PATCH 1/4] soc: Placeholder files for drivers/soc Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 5:30 ` [PATCH 2/4] soc: qcom: Add GSBI driver Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 16:54 ` Josh Cartwright
2014-04-21 16:54 ` Josh Cartwright
2014-04-21 17:11 ` Andy Gross [this message]
2014-04-21 17:11 ` Andy Gross
2014-04-21 17:26 ` Josh Cartwright
2014-04-21 17:26 ` Josh Cartwright
2014-04-21 5:30 ` [PATCH 3/4] soc: qcom: Add device tree binding for GSBI Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 16:55 ` Kumar Gala
2014-04-21 16:55 ` Kumar Gala
2014-04-21 5:30 ` [PATCH 4/4] tty: serial: msm: Remove direct access to GSBI Andy Gross
2014-04-21 5:30 ` Andy Gross
2014-04-21 13:48 ` [PATCH 0/4] Introduce drivers/soc and add QCOM GSBI driver Christopher Covington
2014-04-21 13:48 ` Christopher Covington
2014-04-21 16:21 ` Andy Gross
2014-04-21 16:21 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421171117.GB32485@qualcomm.com \
--to=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.