From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Heikki Krogerus
<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees
Date: Tue, 22 Apr 2014 17:18:40 +0200 [thread overview]
Message-ID: <20140422151840.GH24905@lukather> (raw)
In-Reply-To: <CACRpkdZ+3dnhoj1TS4KSVUP8iFHsjjwop-FG2Nf07YtH6aSO_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Hi Linus,
On Tue, Apr 22, 2014 at 05:00:17PM +0200, Linus Walleij wrote:
> On Tue, Apr 15, 2014 at 8:41 AM, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:
>
> > This patch enables gpio-names based gpiod lookup in device tree usage,
> > which ignores the index passed to gpiod_get_index. If this fails, fall
> > back to the original function-index ("con_id"-gpios) based lookup scheme,
> > for backward compatibility and any drivers needing more than one GPIO
> > for any function.
> >
> > Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
>
> This looks a bit scary and I cannot claim to realize the entire semantic
> effect of this patch, but if it's the way to go then OK.
> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Shall I just apply this to the GPIO tree or are you carrying it along with
> the other stuff?
This patch has a dependency on the first patch of this serie, since it
uses a binding that was documented there.
Maybe you'll want to wait for the ACK from the DT maintainers to merge
this one.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
Arnd Bergmann <arnd@arndb.de>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Alexandre Courbot <gnurou@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees
Date: Tue, 22 Apr 2014 17:18:40 +0200 [thread overview]
Message-ID: <20140422151840.GH24905@lukather> (raw)
In-Reply-To: <CACRpkdZ+3dnhoj1TS4KSVUP8iFHsjjwop-FG2Nf07YtH6aSO_Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Hi Linus,
On Tue, Apr 22, 2014 at 05:00:17PM +0200, Linus Walleij wrote:
> On Tue, Apr 15, 2014 at 8:41 AM, Chen-Yu Tsai <wens@csie.org> wrote:
>
> > This patch enables gpio-names based gpiod lookup in device tree usage,
> > which ignores the index passed to gpiod_get_index. If this fails, fall
> > back to the original function-index ("con_id"-gpios) based lookup scheme,
> > for backward compatibility and any drivers needing more than one GPIO
> > for any function.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> This looks a bit scary and I cannot claim to realize the entire semantic
> effect of this patch, but if it's the way to go then OK.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Shall I just apply this to the GPIO tree or are you carrying it along with
> the other stuff?
This patch has a dependency on the first patch of this serie, since it
uses a binding that was documented there.
Maybe you'll want to wait for the ACK from the DT maintainers to merge
this one.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees
Date: Tue, 22 Apr 2014 17:18:40 +0200 [thread overview]
Message-ID: <20140422151840.GH24905@lukather> (raw)
In-Reply-To: <CACRpkdZ+3dnhoj1TS4KSVUP8iFHsjjwop-FG2Nf07YtH6aSO_Q@mail.gmail.com>
Hi Linus,
On Tue, Apr 22, 2014 at 05:00:17PM +0200, Linus Walleij wrote:
> On Tue, Apr 15, 2014 at 8:41 AM, Chen-Yu Tsai <wens@csie.org> wrote:
>
> > This patch enables gpio-names based gpiod lookup in device tree usage,
> > which ignores the index passed to gpiod_get_index. If this fails, fall
> > back to the original function-index ("con_id"-gpios) based lookup scheme,
> > for backward compatibility and any drivers needing more than one GPIO
> > for any function.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> This looks a bit scary and I cannot claim to realize the entire semantic
> effect of this patch, but if it's the way to go then OK.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Shall I just apply this to the GPIO tree or are you carrying it along with
> the other stuff?
This patch has a dependency on the first patch of this serie, since it
uses a binding that was documented there.
Maybe you'll want to wait for the ACK from the DT maintainers to merge
this one.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140422/3fbc1df2/attachment.sig>
next prev parent reply other threads:[~2014-04-22 15:18 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 6:41 [PATCH 0/7] net: rfkill: gpio: Add device tree support Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
[not found] ` <1397544101-18135-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-04-15 6:41 ` [PATCH 1/7] gpiolib: gpiolib-of: Implement device tree gpio-names based lookup Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
[not found] ` <1397544101-18135-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-04-15 14:20 ` Maxime Ripard
2014-04-15 14:20 ` Maxime Ripard
2014-04-15 14:20 ` Maxime Ripard
2014-04-16 6:12 ` Alexandre Courbot
2014-04-16 6:12 ` Alexandre Courbot
2014-04-16 6:12 ` Alexandre Courbot
[not found] ` <CAAVeFuLDhTVGDnmYtnxEY8hhn6HE6tU9OB24WDPtmxEHjiRiuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-16 7:06 ` Alexandre Courbot
2014-04-16 7:06 ` Alexandre Courbot
2014-04-16 7:06 ` Alexandre Courbot
[not found] ` <CAAVeFu+rJXH=Uat5_qWPu6OfmDAFxHj2b+n=OSmwtSw4s+fv6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-16 9:56 ` Chen-Yu Tsai
2014-04-16 9:56 ` Chen-Yu Tsai
2014-04-16 9:56 ` Chen-Yu Tsai
2014-04-22 15:02 ` Linus Walleij
2014-04-22 15:02 ` Linus Walleij
2014-04-22 15:02 ` Linus Walleij
[not found] ` <CACRpkdZDjC1KxM2yJqsgpg2MxBamX1EObsuahB-2c+ShuBXm8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-23 1:49 ` Alexandre Courbot
2014-04-23 1:49 ` Alexandre Courbot
2014-04-23 1:49 ` Alexandre Courbot
[not found] ` <CAAVeFuL7B7kVw7ME=Vo_snhG27aBphKO8Uzvzen1gyD=R2ETNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-28 16:19 ` Chen-Yu Tsai
2014-04-28 16:19 ` [linux-sunxi] " Chen-Yu Tsai
2014-04-28 16:19 ` Chen-Yu Tsai
2014-04-15 6:41 ` [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
[not found] ` <1397544101-18135-3-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-04-22 15:00 ` Linus Walleij
2014-04-22 15:00 ` Linus Walleij
2014-04-22 15:00 ` Linus Walleij
[not found] ` <CACRpkdZ+3dnhoj1TS4KSVUP8iFHsjjwop-FG2Nf07YtH6aSO_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-22 15:18 ` Maxime Ripard [this message]
2014-04-22 15:18 ` Maxime Ripard
2014-04-22 15:18 ` Maxime Ripard
2014-04-23 13:55 ` Linus Walleij
2014-04-23 13:55 ` Linus Walleij
2014-04-23 13:55 ` Linus Walleij
2014-04-15 6:41 ` [PATCH 3/7] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 14:26 ` Maxime Ripard
2014-04-15 14:26 ` Maxime Ripard
2014-04-15 6:41 ` [PATCH 4/7] net: rfkill: gpio: fix reversed clock enable state Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
[not found] ` <1397544101-18135-5-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-04-15 14:27 ` Maxime Ripard
2014-04-15 14:27 ` Maxime Ripard
2014-04-15 14:27 ` Maxime Ripard
2014-04-15 6:41 ` [PATCH 5/7] net: rfkill: gpio: add device tree support Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 21:00 ` Stephen Warren
2014-04-15 21:00 ` Stephen Warren
2014-04-15 21:01 ` Stephen Warren
2014-04-15 21:01 ` Stephen Warren
2014-04-15 6:41 ` [PATCH 6/7] net: rfkill: gpio: add clock-frequency device tree property Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
[not found] ` <1397544101-18135-7-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-04-15 14:44 ` Maxime Ripard
2014-04-15 14:44 ` Maxime Ripard
2014-04-15 14:44 ` Maxime Ripard
2014-04-15 6:41 ` [PATCH 7/7] ARM: sun7i: cubietruck: enable bluetooth module Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
2014-04-15 6:41 ` Chen-Yu Tsai
[not found] ` <1397544101-18135-8-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-04-15 14:42 ` Maxime Ripard
2014-04-15 14:42 ` Maxime Ripard
2014-04-15 14:42 ` Maxime Ripard
2014-04-15 16:06 ` Chen-Yu Tsai
2014-04-15 16:06 ` [linux-sunxi] " Chen-Yu Tsai
2014-04-15 16:06 ` Chen-Yu Tsai
2014-04-15 16:18 ` One Thousand Gnomes
2014-04-15 16:18 ` One Thousand Gnomes
[not found] ` <CAGb2v643HyvFdhQ0znreB8ENXHWpcx6tFwdeU7VuU8KYWcT4ZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-16 9:44 ` Maxime Ripard
2014-04-16 9:44 ` [linux-sunxi] " Maxime Ripard
2014-04-16 9:44 ` Maxime Ripard
2014-04-16 10:39 ` Chen-Yu Tsai
2014-04-16 10:39 ` [linux-sunxi] " Chen-Yu Tsai
2014-04-16 10:39 ` Chen-Yu Tsai
[not found] ` <CAGb2v67HzB22a3huRRZyufXkdTFE410MhXqAHyC-MmVo0-GCFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-16 13:09 ` Hans de Goede
2014-04-16 13:09 ` Hans de Goede
2014-04-16 13:09 ` [linux-sunxi] " Hans de Goede
[not found] ` <534E8102.4070404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-17 7:43 ` Arend van Spriel
2014-04-17 7:43 ` Arend van Spriel
2014-04-17 7:43 ` [linux-sunxi] " Arend van Spriel
[not found] ` <534F862C.8010604-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2014-04-18 17:49 ` maxime.ripard
2014-04-18 17:49 ` maxime.ripard
2014-04-18 17:49 ` [linux-sunxi] " maxime.ripard
2014-04-18 17:49 ` maxime.ripard
2014-04-18 17:47 ` maxime.ripard
2014-04-18 17:47 ` [linux-sunxi] " maxime.ripard
2014-04-18 17:47 ` maxime.ripard
2014-04-16 13:08 ` Hans de Goede
2014-04-16 13:08 ` [linux-sunxi] " Hans de Goede
2014-04-16 13:08 ` Hans de Goede
2014-04-22 15:06 ` [PATCH 0/7] net: rfkill: gpio: Add device tree support Johannes Berg
2014-04-22 15:06 ` Johannes Berg
2014-04-22 15:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422151840.GH24905@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.