From: Huang Shijie <shijie8@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/2] mtd: m25p80: Revive dual read support
Date: Tue, 22 Apr 2014 23:48:08 +0800 [thread overview]
Message-ID: <20140422154806.GA4230@localhost.localdomain> (raw)
In-Reply-To: <1398170732-19773-1-git-send-email-geert+renesas@glider.be>
On Tue, Apr 22, 2014 at 02:45:31PM +0200, Geert Uytterhoeven wrote:
> Commit 03e296f613affcc2671c1e86d8c25ecad867204e ("mtd: m25p80: use the SPI
> nor framework") accidentally removed support for Dual SPI read transfers.
> Add it back.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/mtd/devices/m25p80.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 1557d8f672c1..ed7e0a1bed3c 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -221,6 +221,8 @@ static int m25p_probe(struct spi_device *spi)
>
> if (spi->mode & SPI_RX_QUAD)
> mode = SPI_NOR_QUAD;
> + else if (spi->mode & SPI_RX_DUAL)
> + mode = SPI_NOR_DUAL;
> ret = spi_nor_scan(nor, spi_get_device_id(spi), mode);
> if (ret)
> return ret;
sorry for the mistake.
Acked-by: Huang Shijie <shijie8@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <shijie8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Cc: Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] mtd: m25p80: Revive dual read support
Date: Tue, 22 Apr 2014 23:48:08 +0800 [thread overview]
Message-ID: <20140422154806.GA4230@localhost.localdomain> (raw)
In-Reply-To: <1398170732-19773-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
On Tue, Apr 22, 2014 at 02:45:31PM +0200, Geert Uytterhoeven wrote:
> Commit 03e296f613affcc2671c1e86d8c25ecad867204e ("mtd: m25p80: use the SPI
> nor framework") accidentally removed support for Dual SPI read transfers.
> Add it back.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> ---
> drivers/mtd/devices/m25p80.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 1557d8f672c1..ed7e0a1bed3c 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -221,6 +221,8 @@ static int m25p_probe(struct spi_device *spi)
>
> if (spi->mode & SPI_RX_QUAD)
> mode = SPI_NOR_QUAD;
> + else if (spi->mode & SPI_RX_DUAL)
> + mode = SPI_NOR_DUAL;
> ret = spi_nor_scan(nor, spi_get_device_id(spi), mode);
> if (ret)
> return ret;
sorry for the mistake.
Acked-by: Huang Shijie <shijie8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-22 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 12:45 [PATCH 1/2] mtd: m25p80: Revive dual read support Geert Uytterhoeven
2014-04-22 12:45 ` Geert Uytterhoeven
2014-04-22 12:45 ` [PATCH 2/2] mtd: spi-nor: Enable Dual and Quad SPI read transfers for s25sl032p Geert Uytterhoeven
2014-04-22 12:45 ` Geert Uytterhoeven
2014-05-12 20:22 ` Brian Norris
2014-05-12 20:22 ` Brian Norris
2014-04-22 15:48 ` Huang Shijie [this message]
2014-04-22 15:48 ` [PATCH 1/2] mtd: m25p80: Revive dual read support Huang Shijie
2014-05-12 20:21 ` Brian Norris
2014-05-12 20:21 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422154806.GA4230@localhost.localdomain \
--to=shijie8@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.