All of lore.kernel.org
 help / color / mirror / Atom feed
From: antoine.tenart@free-electrons.com (Antoine Ténart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP
Date: Wed, 23 Apr 2014 19:36:31 +0200	[thread overview]
Message-ID: <20140423173631.GA10464@kwain> (raw)
In-Reply-To: <5357F7BF.8000703@gmail.com>

Sebastian,

On Wed, Apr 23, 2014 at 07:26:23PM +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 10:27 AM, Antoine T?nart wrote:
> > Enable the SD Card reader and the internal eMMC on the Berlin BG2Q DMP
> > using two of the SDHCI nodes of the Berlin BG2Q.
> > 
> > Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> > ---
> >  arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > index 2da9c41e29d8..6ca8c9e52b08 100644
> > --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > @@ -26,3 +26,14 @@
> >  &uart0 {
> >  	status = "okay";
> >  };
> > +
> > +&sdhci1 {
> 
> Antoine,
> 
> nit: please sort referenced nodes alphabetically.
> 
> With your comments about mmc aliases, I can take both patches
> in now (and fixup ordering) if you like.

You can take them.

I talked with Jisheng about this and the plan is to make a following up
series for the aliases since it will require to modify the subsystem.

Thanks!

Antoine

> 
> Sebastian
> 
> > +	broken-cd;
> > +	sdhci,wp-inverted;
> > +	status = "okay";
> > +};
> > +
> > +&sdhci2 {
> > +	non-removable;
> > +	status = "okay";
> > +};
> > 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: zmxu@marvell.com, jszhang@marvell.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alexandre.belloni@free-electrons.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP
Date: Wed, 23 Apr 2014 19:36:31 +0200	[thread overview]
Message-ID: <20140423173631.GA10464@kwain> (raw)
In-Reply-To: <5357F7BF.8000703@gmail.com>

Sebastian,

On Wed, Apr 23, 2014 at 07:26:23PM +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 10:27 AM, Antoine Ténart wrote:
> > Enable the SD Card reader and the internal eMMC on the Berlin BG2Q DMP
> > using two of the SDHCI nodes of the Berlin BG2Q.
> > 
> > Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> > ---
> >  arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > index 2da9c41e29d8..6ca8c9e52b08 100644
> > --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > @@ -26,3 +26,14 @@
> >  &uart0 {
> >  	status = "okay";
> >  };
> > +
> > +&sdhci1 {
> 
> Antoine,
> 
> nit: please sort referenced nodes alphabetically.
> 
> With your comments about mmc aliases, I can take both patches
> in now (and fixup ordering) if you like.

You can take them.

I talked with Jisheng about this and the plan is to make a following up
series for the aliases since it will require to modify the subsystem.

Thanks!

Antoine

> 
> Sebastian
> 
> > +	broken-cd;
> > +	sdhci,wp-inverted;
> > +	status = "okay";
> > +};
> > +
> > +&sdhci2 {
> > +	non-removable;
> > +	status = "okay";
> > +};
> > 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-04-23 17:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  8:27 [PATCH v2 0/2] ARM: berlin: add SDHCI support Antoine Ténart
2014-04-22  8:27 ` Antoine Ténart
2014-04-22  8:27 ` Antoine Ténart
2014-04-22  8:27 ` [PATCH v2 1/2] ARM: dts: berlin: add the SDHCI nodes for the BG2Q Antoine Ténart
2014-04-22  8:27   ` Antoine Ténart
2014-04-22 17:35   ` Sebastian Hesselbarth
2014-04-22 17:35     ` Sebastian Hesselbarth
2014-04-22 17:35     ` Sebastian Hesselbarth
2014-04-23  9:02     ` Antoine Ténart
2014-04-23  9:02       ` Antoine Ténart
2014-04-23  9:02       ` Antoine Ténart
2014-04-22  8:27 ` [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP Antoine Ténart
2014-04-22  8:27   ` Antoine Ténart
2014-04-23 17:26   ` Sebastian Hesselbarth
2014-04-23 17:26     ` Sebastian Hesselbarth
2014-04-23 17:26     ` Sebastian Hesselbarth
2014-04-23 17:36     ` Antoine Ténart [this message]
2014-04-23 17:36       ` Antoine Ténart
2014-04-23 17:43       ` Sebastian Hesselbarth
2014-04-23 17:43         ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423173631.GA10464@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.