From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <aarapov@redhat.com>,
David Long <dave.long@linaro.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply()
Date: Thu, 24 Apr 2014 14:33:41 +0530 [thread overview]
Message-ID: <20140424090341.GA6437@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140423165830.GA29493@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
(with 2 nits that you can ignore)
> done = tu->filter.nr_systemwide ||
> - event->parent || event->attr.enable_on_exec ||
> + (event->hw.tp_target->flags & PF_EXITING) ||
> uprobe_filter_event(tu, event);
> - list_add(&event->hw.tp_list, &tu->filter.perf_events);
> } else {
> + tu->filter.nr_systemwide--;
> done = tu->filter.nr_systemwide;
> - tu->filter.nr_systemwide++;
> }
Nit: I think 2 lines can be made into
done = --tu->filter.nr_systemwide;
<snipped>
> done = tu->filter.nr_systemwide ||
> - (event->hw.tp_target->flags & PF_EXITING) ||
> + event->parent || event->attr.enable_on_exec ||
> uprobe_filter_event(tu, event);
> + list_add(&event->hw.tp_list, &tu->filter.perf_events);
> } else {
> - tu->filter.nr_systemwide--;
> done = tu->filter.nr_systemwide;
> + tu->filter.nr_systemwide++;
> }
Nit: Similarly lines can be made into
done = tu->filter.nr_systemwide++;
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2014-04-24 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 16:58 [PATCH 0/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply() Oleg Nesterov
2014-04-23 16:58 ` [PATCH 1/1] " Oleg Nesterov
2014-04-24 3:17 ` Steven Rostedt
2014-04-24 11:54 ` [PATCH v2 0/2] uprobes/tracing: uprobe_perf_open()->uprobe_apply() fix Oleg Nesterov
2014-04-24 11:55 ` [PATCH v2 1/2] uprobes/tracing: Make uprobe_perf_close() visible to uprobe_perf_open() Oleg Nesterov
2014-04-24 11:55 ` [PATCH v2 2/2] uprobes/tracing: Fix uprobe_perf_open() on uprobe_apply() failure Oleg Nesterov
2014-04-24 12:37 ` [PATCH v2 0/2] uprobes/tracing: uprobe_perf_open()->uprobe_apply() fix Steven Rostedt
2014-04-24 9:03 ` Srikar Dronamraju [this message]
2014-04-24 12:27 ` [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply() Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424090341.GA6437@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=aarapov@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dave.long@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.