From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 7/7] ARM: dma: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu]
Date: Thu, 24 Apr 2014 16:45:19 +0100 [thread overview]
Message-ID: <20140424154519.GE14110@arm.com> (raw)
In-Reply-To: <1398353407-2345-8-git-send-email-santosh.shilimkar@ti.com>
On Thu, Apr 24, 2014 at 04:30:07PM +0100, Santosh Shilimkar wrote:
> On a 32 bit ARM architecture with LPAE extension physical addresses
> cannot fit into unsigned long variable.
>
> So fix it by using phys_addr_t instead of unsigned long.
>
> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mm/dma-mapping.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index f62aa06..5260f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -885,7 +885,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
> static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr;
> + phys_addr_t paddr;
>
> dma_cache_maint_page(page, off, size, dir, dmac_map_area);
>
> @@ -901,7 +901,7 @@ static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> static void __dma_page_dev_to_cpu(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr = page_to_phys(page) + off;
> + phys_addr_t paddr = page_to_phys(page) + off;
>
> /* FIXME: non-speculating: not required */
> /* don't bother invalidating if DMA to device */
> --
> 1.7.9.5
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [PATCH v3 7/7] ARM: dma: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu]
Date: Thu, 24 Apr 2014 16:45:19 +0100 [thread overview]
Message-ID: <20140424154519.GE14110@arm.com> (raw)
In-Reply-To: <1398353407-2345-8-git-send-email-santosh.shilimkar@ti.com>
On Thu, Apr 24, 2014 at 04:30:07PM +0100, Santosh Shilimkar wrote:
> On a 32 bit ARM architecture with LPAE extension physical addresses
> cannot fit into unsigned long variable.
>
> So fix it by using phys_addr_t instead of unsigned long.
>
> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mm/dma-mapping.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index f62aa06..5260f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -885,7 +885,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
> static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr;
> + phys_addr_t paddr;
>
> dma_cache_maint_page(page, off, size, dir, dmac_map_area);
>
> @@ -901,7 +901,7 @@ static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> static void __dma_page_dev_to_cpu(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr = page_to_phys(page) + off;
> + phys_addr_t paddr = page_to_phys(page) + off;
>
> /* FIXME: non-speculating: not required */
> /* don't bother invalidating if DMA to device */
> --
> 1.7.9.5
>
>
next prev parent reply other threads:[~2014-04-24 15:45 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 15:30 [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 1/7] device: introduce per device dma_pfn_offset Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-05-02 1:01 ` Rob Herring
2014-05-02 1:01 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 2/7] of: introduce of_dma_get_range() helper Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-05-02 1:06 ` Rob Herring
2014-05-02 1:06 ` Rob Herring
2014-05-02 1:06 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 3/7] of: introduce of_dma_is_coherent() helper Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-05-02 0:56 ` Rob Herring
2014-05-02 0:56 ` Rob Herring
2014-05-02 0:56 ` Rob Herring
2014-05-05 21:45 ` Santosh Shilimkar
2014-05-05 21:45 ` Santosh Shilimkar
2014-05-05 22:06 ` Rob Herring
2014-05-05 22:06 ` Rob Herring
2014-05-05 22:06 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 4/7] of: configure the platform device dma parameters Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-29 14:41 ` Grant Likely
2014-04-29 14:41 ` Grant Likely
2014-04-29 14:41 ` Grant Likely
2014-04-30 14:19 ` Santosh Shilimkar
2014-04-30 14:19 ` Santosh Shilimkar
2014-04-30 14:19 ` Santosh Shilimkar
2014-05-01 13:12 ` Grant Likely
2014-05-01 13:12 ` Grant Likely
2014-05-01 13:12 ` Grant Likely
2014-05-01 13:16 ` Santosh Shilimkar
2014-05-01 13:16 ` Santosh Shilimkar
2014-05-01 13:16 ` Santosh Shilimkar
2014-05-02 9:58 ` Arnd Bergmann
2014-05-02 9:58 ` Arnd Bergmann
2014-05-02 9:58 ` Arnd Bergmann
2014-05-02 13:13 ` Santosh Shilimkar
2014-05-02 13:13 ` Santosh Shilimkar
2014-05-02 13:13 ` Santosh Shilimkar
2014-05-02 15:13 ` Arnd Bergmann
2014-05-02 15:13 ` Arnd Bergmann
2014-05-02 15:13 ` Arnd Bergmann
2014-05-27 12:56 ` Grant Likely
2014-05-27 12:56 ` Grant Likely
2014-05-27 12:56 ` Grant Likely
2014-05-27 13:30 ` Arnd Bergmann
2014-05-27 13:30 ` Arnd Bergmann
2014-05-28 8:23 ` Linus Walleij
2014-05-28 8:23 ` Linus Walleij
2014-05-28 13:29 ` Arnd Bergmann
2014-05-28 13:29 ` Arnd Bergmann
2014-05-28 13:29 ` Arnd Bergmann
2014-05-28 13:32 ` Linus Walleij
2014-05-28 13:32 ` Linus Walleij
2014-05-28 13:32 ` Linus Walleij
2014-05-28 14:04 ` Santosh Shilimkar
2014-05-28 14:04 ` Santosh Shilimkar
2014-05-28 14:04 ` Santosh Shilimkar
2014-05-29 14:01 ` Linus Walleij
2014-05-29 14:01 ` Linus Walleij
2014-05-29 14:08 ` Santosh Shilimkar
2014-05-29 14:08 ` Santosh Shilimkar
2014-05-29 19:24 ` Arnd Bergmann
2014-05-29 19:24 ` Arnd Bergmann
2014-05-29 19:24 ` Arnd Bergmann
2014-05-29 20:04 ` Santosh Shilimkar
2014-05-29 20:04 ` Santosh Shilimkar
2014-05-29 20:04 ` Santosh Shilimkar
2014-05-02 0:49 ` Rob Herring
2014-05-02 0:49 ` Rob Herring
2014-05-02 0:49 ` Rob Herring
2014-05-05 21:47 ` Santosh Shilimkar
2014-05-05 21:47 ` Santosh Shilimkar
2014-05-05 21:47 ` Santosh Shilimkar
2014-05-05 22:08 ` Rob Herring
2014-05-05 22:08 ` Rob Herring
2014-05-06 9:40 ` Arnd Bergmann
2014-05-06 9:40 ` Arnd Bergmann
2014-05-06 9:40 ` Arnd Bergmann
2014-05-06 20:44 ` Santosh Shilimkar
2014-05-06 20:44 ` Santosh Shilimkar
2014-05-06 20:44 ` Santosh Shilimkar
2014-05-07 13:24 ` Santosh Shilimkar
2014-05-07 13:24 ` Santosh Shilimkar
2014-05-02 16:54 ` Bjorn Helgaas
2014-05-02 16:54 ` Bjorn Helgaas
2014-05-02 16:54 ` Bjorn Helgaas
2014-05-02 18:59 ` Arnd Bergmann
2014-05-02 18:59 ` Arnd Bergmann
2014-05-05 20:45 ` Bjorn Helgaas
2014-05-05 20:45 ` Bjorn Helgaas
2014-05-05 20:45 ` Bjorn Helgaas
2014-05-05 20:55 ` Arnd Bergmann
2014-05-05 20:55 ` Arnd Bergmann
2014-05-05 20:55 ` Arnd Bergmann
2014-05-05 22:28 ` Bjorn Helgaas
2014-05-05 22:28 ` Bjorn Helgaas
2014-05-05 22:28 ` Bjorn Helgaas
2014-05-06 3:44 ` Benjamin Herrenschmidt
2014-05-06 3:44 ` Benjamin Herrenschmidt
2014-05-06 9:54 ` Arnd Bergmann
2014-05-06 9:54 ` Arnd Bergmann
2014-05-06 9:54 ` Arnd Bergmann
2014-05-06 13:32 ` Santosh Shilimkar
2014-05-06 13:32 ` Santosh Shilimkar
2014-05-06 13:32 ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 5/7] ARM: dma: Use dma_pfn_offset for dma address translation Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-05-02 14:32 ` Rob Herring
2014-05-02 14:32 ` Rob Herring
2014-05-02 14:32 ` Rob Herring
2014-05-02 14:58 ` Russell King - ARM Linux
2014-05-02 14:58 ` Russell King - ARM Linux
2014-05-02 15:05 ` Santosh Shilimkar
2014-05-02 15:05 ` Santosh Shilimkar
2014-05-02 15:05 ` Santosh Shilimkar
2014-05-05 19:50 ` Russell King - ARM Linux
2014-05-05 19:50 ` Russell King - ARM Linux
2014-05-05 21:43 ` Santosh Shilimkar
2014-05-05 21:43 ` Santosh Shilimkar
2014-05-05 21:43 ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 6/7] ARM: dma: implement set_arch_dma_coherent_ops() Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-05-02 0:58 ` Rob Herring
2014-05-02 0:58 ` Rob Herring
2014-05-02 0:58 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 7/7] ARM: dma: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu] Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:30 ` Santosh Shilimkar
2014-04-24 15:45 ` Will Deacon [this message]
2014-04-24 15:45 ` Will Deacon
2014-05-01 13:19 ` [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-05-01 13:19 ` Santosh Shilimkar
2014-05-01 13:19 ` Santosh Shilimkar
2014-05-01 13:25 ` Russell King - ARM Linux
2014-05-01 13:25 ` Russell King - ARM Linux
2014-05-01 14:06 ` Santosh Shilimkar
2014-05-01 14:06 ` Santosh Shilimkar
2014-05-01 14:06 ` Santosh Shilimkar
2014-05-02 14:41 ` Rob Herring
2014-05-02 14:41 ` Rob Herring
2014-05-02 14:41 ` Rob Herring
2014-05-02 16:41 ` Santosh Shilimkar
2014-05-02 16:41 ` Santosh Shilimkar
2014-05-14 10:12 ` Grant Likely
2014-05-14 10:12 ` Grant Likely
2014-05-14 10:12 ` Grant Likely
2014-06-02 6:37 ` Shawn Guo
2014-06-02 6:37 ` Shawn Guo
2014-06-02 6:37 ` Shawn Guo
2014-06-02 13:24 ` Santosh Shilimkar
2014-06-02 13:24 ` Santosh Shilimkar
2014-06-02 15:06 ` Arnd Bergmann
2014-06-02 15:06 ` Arnd Bergmann
2014-06-02 15:06 ` Arnd Bergmann
2014-06-02 15:54 ` Santosh Shilimkar
2014-06-02 15:54 ` Santosh Shilimkar
2014-06-02 15:54 ` Santosh Shilimkar
2014-06-02 19:00 ` Arnd Bergmann
2014-06-02 19:00 ` Arnd Bergmann
2014-06-02 19:08 ` Santosh Shilimkar
2014-06-02 19:08 ` Santosh Shilimkar
2014-06-02 19:08 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424154519.GE14110@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.