All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linux-zigbee-devel@lists.sourceforge.net,
	David Miller <davem@davemloft.net>,
	Johannes Berg <johannes@sipsolutions.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"backports@vger.kernel.org" <backports@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-zigbee-devel] [PATCH] 6lowpan: nuke net_ieee802154_lowpan() accessor when 6lowpan is disabled
Date: Thu, 24 Apr 2014 19:33:35 +0200	[thread overview]
Message-ID: <20140424173333.GA21799@omega> (raw)
In-Reply-To: <CAB=NE6XS9-Zu9sb5geO2WTnnvv6KqyT+QnL5bRf1fiRx3=ocrg@mail.gmail.com>

Hi Luis,

On Thu, Apr 24, 2014 at 10:25:58AM -0700, Luis R. Rodriguez wrote:
> On Thu, Apr 24, 2014 at 9:44 AM, Alexander Aring <alex.aring@gmail.com> wrote:
> > Hi,
> >
> > On Tue, Apr 22, 2014 at 12:03:58PM -0700, Luis R. Rodriguez wrote:
> >> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >>
> >> Johannes noted this is not needed, all of the fragment
> >> accessors don't need CONFIG_NET_NS. This goes test compiled with
> >> CONFIG_BT_6LOWPAN=y and a disabled CONFIG_NET_NS.
> >>
> >
> > a little note about this here. There exists two 6LoWPAN standard. One
> > for bluetooth low energy and one for IEEE 802.15.4.
> >
> > The actual namespace is only for IEEE 802.15.4, because we need
> > fragmentation there. 6LoWPAN fragmentation for bluetooth low energy is
> > already handled by the MAC-Layer. So this has nothing to do with
> > CONFIG_BT_6LOWPAN.
> 
> Thanks for the clarification, I actually did mean
> CONFIG_IEEE802154_6LOWPAN however, I goofed that on the commit log.
> 

ok. But I need to say thanks for sending this patch! :-)

It's nice to see that the community helps to improving the code which I
produced and it's really not perfect at the moment. (I was a little bit
shocked that somebody makes the effort to making a backport about that).

- Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Aring <alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Luis R. Rodriguez" <mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
Cc: Alexander Smirnov
	<alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dmitry Eremin-Solenikov
	<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"backports-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<backports-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [Linux-zigbee-devel] [PATCH] 6lowpan: nuke net_ieee802154_lowpan() accessor when 6lowpan is disabled
Date: Thu, 24 Apr 2014 19:33:35 +0200	[thread overview]
Message-ID: <20140424173333.GA21799@omega> (raw)
In-Reply-To: <CAB=NE6XS9-Zu9sb5geO2WTnnvv6KqyT+QnL5bRf1fiRx3=ocrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Luis,

On Thu, Apr 24, 2014 at 10:25:58AM -0700, Luis R. Rodriguez wrote:
> On Thu, Apr 24, 2014 at 9:44 AM, Alexander Aring <alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > Hi,
> >
> > On Tue, Apr 22, 2014 at 12:03:58PM -0700, Luis R. Rodriguez wrote:
> >> From: "Luis R. Rodriguez" <mcgrof-IBi9RG/b67k@public.gmane.org>
> >>
> >> Johannes noted this is not needed, all of the fragment
> >> accessors don't need CONFIG_NET_NS. This goes test compiled with
> >> CONFIG_BT_6LOWPAN=y and a disabled CONFIG_NET_NS.
> >>
> >
> > a little note about this here. There exists two 6LoWPAN standard. One
> > for bluetooth low energy and one for IEEE 802.15.4.
> >
> > The actual namespace is only for IEEE 802.15.4, because we need
> > fragmentation there. 6LoWPAN fragmentation for bluetooth low energy is
> > already handled by the MAC-Layer. So this has nothing to do with
> > CONFIG_BT_6LOWPAN.
> 
> Thanks for the clarification, I actually did mean
> CONFIG_IEEE802154_6LOWPAN however, I goofed that on the commit log.
> 

ok. But I need to say thanks for sending this patch! :-)

It's nice to see that the community helps to improving the code which I
produced and it's really not perfect at the moment. (I was a little bit
shocked that somebody makes the effort to making a backport about that).

- Alex

  reply	other threads:[~2014-04-24 17:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 19:03 [PATCH] 6lowpan: nuke net_ieee802154_lowpan() accessor when 6lowpan is disabled Luis R. Rodriguez
2014-04-22 19:03 ` Luis R. Rodriguez
2014-04-24 16:36 ` David Miller
2014-04-24 16:36   ` David Miller
2014-04-24 16:44 ` [Linux-zigbee-devel] " Alexander Aring
2014-04-24 16:44   ` Alexander Aring
2014-04-24 17:25   ` [Linux-zigbee-devel] " Luis R. Rodriguez
2014-04-24 17:25     ` Luis R. Rodriguez
2014-04-24 17:33     ` Alexander Aring [this message]
2014-04-24 17:33       ` [Linux-zigbee-devel] " Alexander Aring
2014-04-24 17:57       ` Luis R. Rodriguez
2014-04-24 17:57         ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140424173333.GA21799@omega \
    --to=alex.aring@gmail.com \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=backports@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dbaryshkov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=mcgrof@do-not-panic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.