[meta-qt5]remove -reduce-relocations on arm platform

[meta-qt5]remove -reduce-relocations on arm platform

[Neuer User]

On arm platform the compiler does not implement "-reduce-relocations",
see here: https://bugreports.qt-project.org/browse/QTBUG-36129

The meta-qt5 layer, however, uses this option, so configure will fail
for qtbase.

This patch fixes the problem for me, but it should better test on the
platform and only apply it, when it is an arm platform:

diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
index 89736be..f23236a 100644
--- a/recipes-qt/qt5/qtbase.inc
+++ b/recipes-qt/qt5/qtbase.inc
@@ -126,7 +126,6 @@ PACKAGECONFIG[nis] = "-nis,-no-nis"
 PACKAGECONFIG[widgets] = "-widgets,-no-widgets"

 QT_CONFIG_FLAGS += " \
-    -reduce-relocations \
     -shared \
     -silent \
     -no-pch \

Re: [meta-qt5]remove -reduce-relocations on arm platform

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On Fri, Apr 25, 2014 at 08:16:09AM +0200, Neuer User wrote:
> On arm platform the compiler does not implement "-reduce-relocations",
> see here: https://bugreports.qt-project.org/browse/QTBUG-36129
> 
> The meta-qt5 layer, however, uses this option, so configure will fail
> for qtbase.
> 
> This patch fixes the problem for me, but it should better test on the
> platform and only apply it, when it is an arm platform:

This doesn't remove it only for arm and it's also missing SOB line.
> 
> diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
> index 89736be..f23236a 100644
> --- a/recipes-qt/qt5/qtbase.inc
> +++ b/recipes-qt/qt5/qtbase.inc
> @@ -126,7 +126,6 @@ PACKAGECONFIG[nis] = "-nis,-no-nis"
>  PACKAGECONFIG[widgets] = "-widgets,-no-widgets"
> 
>  QT_CONFIG_FLAGS += " \
> -    -reduce-relocations \
>      -shared \
>      -silent \
>      -no-pch \
> 
> 
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-qt5]remove -reduce-relocations on arm platform

[Jacob Kroon]

On Fri, Apr 25, 2014 at 8:16 AM, Neuer User <auslands-kv@gmx.de> wrote:

> On arm platform the compiler does not implement "-reduce-relocations",
> see here: https://bugreports.qt-project.org/browse/QTBUG-36129
>
> The meta-qt5 layer, however, uses this option, so configure will fail
> for qtbase.
>
>
I'm building for Wandboard, ARM Cortex-A9, but I haven't had any problems
building qtbase.
Is this more of a runtime bug ?

/Jacob

Re: [meta-qt5]remove -reduce-relocations on arm platform

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On Fri, Apr 25, 2014 at 03:02:17PM +0200, Jacob Kroon wrote:
> On Fri, Apr 25, 2014 at 8:16 AM, Neuer User <auslands-kv@gmx.de> wrote:
> 
> > On arm platform the compiler does not implement "-reduce-relocations",
> > see here: https://bugreports.qt-project.org/browse/QTBUG-36129
> >
> > The meta-qt5 layer, however, uses this option, so configure will fail
> > for qtbase.
> >
> >
> I'm building for Wandboard, ARM Cortex-A9, but I haven't had any problems
> building qtbase.
> Is this more of a runtime bug ?

It's catched in configure in 5.3.* version - not sure if it influences
older versions as well - we were seeing runtime issues with older gcc
and 5.2.1 (but we've upgraded gcc and haven't tried to remove
-reduce-relocations).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-qt5]remove -reduce-relocations on arm platform

[Khem Raj]

On Fri, Apr 25, 2014 at 6:02 AM, Jacob Kroon <jacob.kroon@gmail.com> wrote:
> I'm building for Wandboard, ARM Cortex-A9, but I haven't had any problems
> building qtbase.
> Is this more of a runtime bug ?

are you using Linaro toolchain ?

Re: [meta-qt5]remove -reduce-relocations on arm platform

[Jacob Kroon]

On Sat, Apr 26, 2014 at 9:44 PM, Khem Raj <raj.khem@gmail.com> wrote:

> On Fri, Apr 25, 2014 at 6:02 AM, Jacob Kroon <jacob.kroon@gmail.com>
> wrote:
> > I'm building for Wandboard, ARM Cortex-A9, but I haven't had any problems
> > building qtbase.
> > Is this more of a runtime bug ?
>
> are you using Linaro toolchain ?
>

No, I've been using the vanilla gcc toolchain that is built by OE, without
meta-linaro. But I may not have exercised Qt5 enough in my application to
have noticed this bug.

Re: [meta-qt5]remove -reduce-relocations on arm platform

[Khem Raj]

On Thu, Apr 24, 2014 at 11:16 PM, Neuer User <auslands-kv@gmx.de> wrote:
> On arm platform the compiler does not implement "-reduce-relocations",
> see here: https://bugreports.qt-project.org/browse/QTBUG-36129
>
> The meta-qt5 layer, however, uses this option, so configure will fail
> for qtbase.
>
> This patch fixes the problem for me, but it should better test on the
> platform and only apply it, when it is an arm platform:
>
> diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
> index 89736be..f23236a 100644
> --- a/recipes-qt/qt5/qtbase.inc
> +++ b/recipes-qt/qt5/qtbase.inc
> @@ -126,7 +126,6 @@ PACKAGECONFIG[nis] = "-nis,-no-nis"
>  PACKAGECONFIG[widgets] = "-widgets,-no-widgets"
>
>  QT_CONFIG_FLAGS += " \
> -    -reduce-relocations \
>      -shared \
>      -silent \
>      -no-pch \

i would rather prefer
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=97323ad11305610185a0265392cabcd37510f50e

to be back ported to OE-Core master/daisy binutils instead