From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/18] usb: host: xhci-plat: Add support for the Armada 38x
Date: Fri, 25 Apr 2014 16:18:49 +0200 [thread overview]
Message-ID: <20140425161849.5616821e@skate> (raw)
In-Reply-To: <1398434836-18908-4-git-send-email-gregory.clement@free-electrons.com>
Dear Gregory CLEMENT,
On Fri, 25 Apr 2014 16:07:01 +0200, Gregory CLEMENT wrote:
> +#define USB3_MAX_WINDOWS 4
> +#define USB3_WIN_CTRL(w) (0x0 + ((w) * 8))
> +#define USB3_WIN_BASE(w) (0x4 + ((w) * 8))
> +
> +static void __init mv_usb3_conf_mbus_windows(void __iomem *base,
> + const struct mbus_dram_target_info *dram)
That's a nitpick, but the name of this function looks like it was
copy/pasted from the Marvell LSP, and isn't very consistent with the
other function name. What about:
xhci_mvebu_mbus_config()
instead, or something like that?
> +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev)
I believe this should give you a warning about section mismatch: you
have a non-init function calling an __init function, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 03/18] usb: host: xhci-plat: Add support for the Armada 38x
Date: Fri, 25 Apr 2014 16:18:49 +0200 [thread overview]
Message-ID: <20140425161849.5616821e@skate> (raw)
In-Reply-To: <1398434836-18908-4-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Dear Gregory CLEMENT,
On Fri, 25 Apr 2014 16:07:01 +0200, Gregory CLEMENT wrote:
> +#define USB3_MAX_WINDOWS 4
> +#define USB3_WIN_CTRL(w) (0x0 + ((w) * 8))
> +#define USB3_WIN_BASE(w) (0x4 + ((w) * 8))
> +
> +static void __init mv_usb3_conf_mbus_windows(void __iomem *base,
> + const struct mbus_dram_target_info *dram)
That's a nitpick, but the name of this function looks like it was
copy/pasted from the Marvell LSP, and isn't very consistent with the
other function name. What about:
xhci_mvebu_mbus_config()
instead, or something like that?
> +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev)
I believe this should give you a warning about section mismatch: you
have a non-init function calling an __init function, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
devicetree@vger.kernel.org, Nadav Haklai <nadavh@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Grant Likely <grant.likely@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 03/18] usb: host: xhci-plat: Add support for the Armada 38x
Date: Fri, 25 Apr 2014 16:18:49 +0200 [thread overview]
Message-ID: <20140425161849.5616821e@skate> (raw)
In-Reply-To: <1398434836-18908-4-git-send-email-gregory.clement@free-electrons.com>
Dear Gregory CLEMENT,
On Fri, 25 Apr 2014 16:07:01 +0200, Gregory CLEMENT wrote:
> +#define USB3_MAX_WINDOWS 4
> +#define USB3_WIN_CTRL(w) (0x0 + ((w) * 8))
> +#define USB3_WIN_BASE(w) (0x4 + ((w) * 8))
> +
> +static void __init mv_usb3_conf_mbus_windows(void __iomem *base,
> + const struct mbus_dram_target_info *dram)
That's a nitpick, but the name of this function looks like it was
copy/pasted from the Marvell LSP, and isn't very consistent with the
other function name. What about:
xhci_mvebu_mbus_config()
instead, or something like that?
> +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev)
I believe this should give you a warning about section mismatch: you
have a non-init function calling an __init function, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-25 14:18 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 14:06 [PATCH v2 00/18] USB support for Armada 38x and Armada 375 Gregory CLEMENT
2014-04-25 14:06 ` Gregory CLEMENT
2014-04-25 14:06 ` Gregory CLEMENT
2014-04-25 14:06 ` [PATCH v2 01/18] usb: host: xhci-plat: Sort the headers in alphabetic order Gregory CLEMENT
2014-04-25 14:06 ` Gregory CLEMENT
2014-04-25 14:06 ` Gregory CLEMENT
2014-04-25 14:55 ` Felipe Balbi
2014-04-25 14:55 ` Felipe Balbi
2014-04-25 14:55 ` Felipe Balbi
2014-04-25 14:07 ` [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:15 ` Thomas Petazzoni
2014-04-25 14:15 ` Thomas Petazzoni
2014-04-25 14:44 ` Gregory CLEMENT
2014-04-25 14:44 ` Gregory CLEMENT
2014-04-25 14:48 ` Gregory CLEMENT
2014-04-25 14:48 ` Gregory CLEMENT
2014-04-25 14:48 ` Gregory CLEMENT
2014-04-25 14:20 ` Russell King - ARM Linux
2014-04-25 14:20 ` Russell King - ARM Linux
2014-04-25 14:20 ` Russell King - ARM Linux
2014-04-25 15:02 ` Felipe Balbi
2014-04-25 15:02 ` Felipe Balbi
2014-04-25 15:02 ` Felipe Balbi
2014-04-25 15:47 ` Andrew Lunn
2014-04-25 15:47 ` Andrew Lunn
2014-04-25 15:47 ` Andrew Lunn
2014-04-25 14:07 ` [PATCH v2 03/18] usb: host: xhci-plat: Add support for the Armada 38x Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:18 ` Thomas Petazzoni [this message]
2014-04-25 14:18 ` Thomas Petazzoni
2014-04-25 14:18 ` Thomas Petazzoni
2014-04-25 15:04 ` Felipe Balbi
2014-04-25 15:04 ` Felipe Balbi
2014-04-25 15:04 ` Felipe Balbi
2014-04-25 20:01 ` Arnd Bergmann
2014-04-25 20:01 ` Arnd Bergmann
2014-04-25 20:10 ` Felipe Balbi
2014-04-25 20:10 ` Felipe Balbi
2014-04-25 20:10 ` Felipe Balbi
2014-04-25 20:25 ` Thomas Petazzoni
2014-04-25 20:25 ` Thomas Petazzoni
2014-04-25 20:25 ` Thomas Petazzoni
2014-04-25 14:07 ` [PATCH v2 04/18] xhci-platform: Add a new controller using xhci: " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 17:55 ` Sergei Shtylyov
2014-04-25 17:55 ` Sergei Shtylyov
2014-04-25 14:07 ` [PATCH v2 05/18] ARM: mvebu: Add Device Tree description of xHCI hosts on " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 15:53 ` Andrew Lunn
2014-04-25 15:53 ` Andrew Lunn
2014-04-25 14:07 ` [PATCH v2 06/18] ARM: mvebu: Add Device Tree description of EHCI " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 07/18] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 08/18] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 09/18] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 10/18] usb: host: xhci-plat: Add support for the Armada 375 Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 11/18] xhci-platform: Add a new controller using xhci: " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 12/18] ARM: mvebu: Add Device Tree description of USB cluster controller on " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 13/18] dt: binding: Armada 375 USB cluster Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 14/18] ARM: mvebu: Add support for USB cluster on the Armada 375 SoC Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 15:43 ` Ezequiel Garcia
2014-04-25 15:43 ` Ezequiel Garcia
2014-04-25 15:43 ` Ezequiel Garcia
2014-04-25 15:59 ` Andrew Lunn
2014-04-25 15:59 ` Andrew Lunn
2014-04-25 16:07 ` Andrew Lunn
2014-04-25 16:07 ` Andrew Lunn
2014-04-25 16:13 ` Felipe Balbi
2014-04-25 16:13 ` Felipe Balbi
2014-04-25 16:13 ` Felipe Balbi
2014-04-25 14:07 ` [PATCH v2 15/18] ARM: mvebu: Add USB3 support for Armada 375 Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 16/18] ARM: mvebu: add USB3 controller Device Tree details " Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 17/18] ARM: mvebu: dts: Enable USB3 in Armada 375 DB Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
2014-04-25 14:07 ` [PATCH v2 18/18] ARM: mvebu: Add Device Tree description of EHCI hosts on Armada 375 Gregory CLEMENT
2014-04-25 14:07 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425161849.5616821e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.