* [PATCH 1/1] ARM: dts: omap3-igep0020: use SMSC9221 timings
@ 2014-04-24 16:53 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2014-04-24 16:53 UTC (permalink / raw)
To: Tony Lindgren
Cc: Benoît Cousson, Enric Balletbo i Serra, linux-omap,
linux-arm-kernel, Javier Martinez Canillas
The IGEPv2 board has a SMSC LAN9221i ethernet chip and not a
SMSC LAN911x connected to the GPMC. Each chip needs different
timings in order to operate correctly so is wrong to include
omap-gpmc-smsc911x.dtsi instead of omap-gpmc-smsc9221.dtsi.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Hi Tony,
I see no performance difference when measuring network throughput using
iperf(1) but this change is the correct one nonetheless since if we later
better adjust the timings it will already include the right dtsi.
Best regards,
Javier
arch/arm/boot/dts/omap3-igep.dtsi | 2 +-
arch/arm/boot/dts/omap3-igep0020.dts | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index b97736d..e2d163b 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -107,7 +107,7 @@
>;
};
- smsc911x_pins: pinmux_smsc911x_pins {
+ smsc9221_pins: pinmux_smsc9221_pins {
pinctrl-single,pins = <
0x1a2 (PIN_INPUT | MUX_MODE4) /* mcspi1_cs2.gpio_176 */
>;
diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index 7abd64f..b22caaa 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -10,7 +10,7 @@
*/
#include "omap3-igep.dtsi"
-#include "omap-gpmc-smsc911x.dtsi"
+#include "omap-gpmc-smsc9221.dtsi"
/ {
model = "IGEPv2 (TI OMAP AM/DM37x)";
@@ -248,7 +248,7 @@
ethernet@gpmc {
pinctrl-names = "default";
- pinctrl-0 = <&smsc911x_pins>;
+ pinctrl-0 = <&smsc9221_pins>;
reg = <5 0 0xff>;
interrupt-parent = <&gpio6>;
interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] ARM: dts: omap3-igep0020: use SMSC9221 timings
@ 2014-04-24 16:53 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2014-04-24 16:53 UTC (permalink / raw)
To: linux-arm-kernel
The IGEPv2 board has a SMSC LAN9221i ethernet chip and not a
SMSC LAN911x connected to the GPMC. Each chip needs different
timings in order to operate correctly so is wrong to include
omap-gpmc-smsc911x.dtsi instead of omap-gpmc-smsc9221.dtsi.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Hi Tony,
I see no performance difference when measuring network throughput using
iperf(1) but this change is the correct one nonetheless since if we later
better adjust the timings it will already include the right dtsi.
Best regards,
Javier
arch/arm/boot/dts/omap3-igep.dtsi | 2 +-
arch/arm/boot/dts/omap3-igep0020.dts | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index b97736d..e2d163b 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -107,7 +107,7 @@
>;
};
- smsc911x_pins: pinmux_smsc911x_pins {
+ smsc9221_pins: pinmux_smsc9221_pins {
pinctrl-single,pins = <
0x1a2 (PIN_INPUT | MUX_MODE4) /* mcspi1_cs2.gpio_176 */
>;
diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index 7abd64f..b22caaa 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -10,7 +10,7 @@
*/
#include "omap3-igep.dtsi"
-#include "omap-gpmc-smsc911x.dtsi"
+#include "omap-gpmc-smsc9221.dtsi"
/ {
model = "IGEPv2 (TI OMAP AM/DM37x)";
@@ -248,7 +248,7 @@
ethernet at gpmc {
pinctrl-names = "default";
- pinctrl-0 = <&smsc911x_pins>;
+ pinctrl-0 = <&smsc9221_pins>;
reg = <5 0 0xff>;
interrupt-parent = <&gpio6>;
interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] ARM: dts: omap3-igep0020: use SMSC9221 timings
2014-04-24 16:53 ` Javier Martinez Canillas
@ 2014-04-25 16:30 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-04-25 16:30 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Benoît Cousson, Enric Balletbo i Serra, linux-omap,
linux-arm-kernel
* Javier Martinez Canillas <javier.martinez@collabora.co.uk> [140424 09:54]:
> The IGEPv2 board has a SMSC LAN9221i ethernet chip and not a
> SMSC LAN911x connected to the GPMC. Each chip needs different
> timings in order to operate correctly so is wrong to include
> omap-gpmc-smsc911x.dtsi instead of omap-gpmc-smsc9221.dtsi.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Hi Tony,
>
> I see no performance difference when measuring network throughput using
> iperf(1) but this change is the correct one nonetheless since if we later
> better adjust the timings it will already include the right dtsi.
Yes, let's fix this as wrong timings can cause memory corruption.
Applying into omap-for-v3.15/fixes-v2.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM: dts: omap3-igep0020: use SMSC9221 timings
@ 2014-04-25 16:30 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-04-25 16:30 UTC (permalink / raw)
To: linux-arm-kernel
* Javier Martinez Canillas <javier.martinez@collabora.co.uk> [140424 09:54]:
> The IGEPv2 board has a SMSC LAN9221i ethernet chip and not a
> SMSC LAN911x connected to the GPMC. Each chip needs different
> timings in order to operate correctly so is wrong to include
> omap-gpmc-smsc911x.dtsi instead of omap-gpmc-smsc9221.dtsi.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Hi Tony,
>
> I see no performance difference when measuring network throughput using
> iperf(1) but this change is the correct one nonetheless since if we later
> better adjust the timings it will already include the right dtsi.
Yes, let's fix this as wrong timings can cause memory corruption.
Applying into omap-for-v3.15/fixes-v2.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-25 16:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-24 16:53 [PATCH 1/1] ARM: dts: omap3-igep0020: use SMSC9221 timings Javier Martinez Canillas
2014-04-24 16:53 ` Javier Martinez Canillas
2014-04-25 16:30 ` Tony Lindgren
2014-04-25 16:30 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.