From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
wim@iguana.be, dbaryshkov@gmail.com, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/5] power: reset: Add Allwinner A31 reset code
Date: Mon, 28 Apr 2014 16:11:08 -0700 [thread overview]
Message-ID: <20140428231108.GO3134@lukather> (raw)
In-Reply-To: <535BD18B.2070902@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
Hi,
On Sat, Apr 26, 2014 at 08:32:27AM -0700, Guenter Roeck wrote:
> On 04/23/2014 08:04 AM, Maxime Ripard wrote:
> >That code used to be in the machine code, but it's more fit here with other
> >restart hooks.
> >
> >That will allow to cleanup the machine directory, while waiting for a proper
> >watchdog driver for the A31.
> >
> >Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> I am a bit lost here. Why is this a separate driver, accessing watchdog registers,
> while the other reset functions are being moved into the watchdog code ?
>
> Any chance to handle all platforms the same ? Seems to me that would be less messy.
The A31 watchdog is actually a different watchdog from the one in the
other Allwinner SoCs, that probably needs a driver of its own, or at
least, a significant refactoring.
No one did this yet, but eventually this will probably happen.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] power: reset: Add Allwinner A31 reset code
Date: Mon, 28 Apr 2014 16:11:08 -0700 [thread overview]
Message-ID: <20140428231108.GO3134@lukather> (raw)
In-Reply-To: <535BD18B.2070902@roeck-us.net>
Hi,
On Sat, Apr 26, 2014 at 08:32:27AM -0700, Guenter Roeck wrote:
> On 04/23/2014 08:04 AM, Maxime Ripard wrote:
> >That code used to be in the machine code, but it's more fit here with other
> >restart hooks.
> >
> >That will allow to cleanup the machine directory, while waiting for a proper
> >watchdog driver for the A31.
> >
> >Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> I am a bit lost here. Why is this a separate driver, accessing watchdog registers,
> while the other reset functions are being moved into the watchdog code ?
>
> Any chance to handle all platforms the same ? Seems to me that would be less messy.
The A31 watchdog is actually a different watchdog from the one in the
other Allwinner SoCs, that probably needs a driver of its own, or at
least, a significant refactoring.
No one did this yet, but eventually this will probably happen.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140428/155f63fb/attachment.sig>
next prev parent reply other threads:[~2014-04-28 23:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 15:04 [PATCH 0/5] ARM: sunxi: Machine code cleanup Maxime Ripard
2014-04-23 15:04 ` Maxime Ripard
2014-04-23 15:04 ` [PATCH 1/5] wdt: sunxi: Move restart code to the watchdog driver Maxime Ripard
2014-04-23 15:04 ` Maxime Ripard
2014-04-23 15:57 ` Arnd Bergmann
2014-04-23 15:57 ` Arnd Bergmann
2014-04-26 15:31 ` Guenter Roeck
2014-04-26 15:31 ` Guenter Roeck
2014-04-28 23:07 ` Maxime Ripard
2014-04-28 23:07 ` Maxime Ripard
2014-04-23 15:04 ` [PATCH 2/5] power: reset: Add Allwinner A31 reset code Maxime Ripard
2014-04-23 15:04 ` Maxime Ripard
2014-04-23 15:58 ` Arnd Bergmann
2014-04-23 15:58 ` Arnd Bergmann
2014-04-26 15:32 ` Guenter Roeck
2014-04-26 15:32 ` Guenter Roeck
2014-04-28 23:11 ` Maxime Ripard [this message]
2014-04-28 23:11 ` Maxime Ripard
2014-04-23 15:04 ` [PATCH 3/5] ARM: sunxi: Select restart drivers Maxime Ripard
2014-04-23 15:04 ` Maxime Ripard
2014-04-23 16:00 ` Arnd Bergmann
2014-04-23 16:00 ` Arnd Bergmann
2014-04-24 12:57 ` Maxime Ripard
2014-04-24 12:57 ` Maxime Ripard
2014-04-23 15:04 ` [PATCH 4/5] ARM: sunxi: Remove reset code from the platform Maxime Ripard
2014-04-23 15:04 ` Maxime Ripard
2014-04-23 16:00 ` Arnd Bergmann
2014-04-23 16:00 ` Arnd Bergmann
2014-04-23 15:04 ` [PATCH 5/5] ARM: sunxi: Remove sun4i and sun7i machine definitions Maxime Ripard
2014-04-23 15:04 ` Maxime Ripard
2014-04-23 16:02 ` Arnd Bergmann
2014-04-23 16:02 ` Arnd Bergmann
2014-04-24 12:59 ` Maxime Ripard
2014-04-24 12:59 ` Maxime Ripard
2014-04-29 1:08 ` Olof Johansson
2014-04-29 1:08 ` Olof Johansson
2014-04-30 18:31 ` Maxime Ripard
2014-04-30 18:31 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428231108.GO3134@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.