* [patch] [SCSI] osst: indent for loop body
@ 2014-04-29 12:39 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-29 12:39 UTC (permalink / raw)
To: Willem Riede
Cc: James E.J. Bottomley, osst-users, linux-scsi, kernel-janitors
The for body loop isn't indented at all so it's confusing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 21883a2..3074f6b 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -5430,7 +5430,7 @@ static int append_to_buffer(const char __user *ubp, struct osst_buffer *st_bp, i
for (i=0, offset=st_bp->buffer_bytes;
i < st_bp->sg_segs && offset >= st_bp->sg[i].length; i++)
- offset -= st_bp->sg[i].length;
+ offset -= st_bp->sg[i].length;
if (i = st_bp->sg_segs) { /* Should never happen */
printk(KERN_WARNING "osst :A: Append_to_buffer offset overflow.\n");
return (-EIO);
^ permalink raw reply related [flat|nested] 2+ messages in thread* [patch] [SCSI] osst: indent for loop body
@ 2014-04-29 12:39 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-29 12:39 UTC (permalink / raw)
To: Willem Riede
Cc: James E.J. Bottomley, osst-users, linux-scsi, kernel-janitors
The for body loop isn't indented at all so it's confusing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 21883a2..3074f6b 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -5430,7 +5430,7 @@ static int append_to_buffer(const char __user *ubp, struct osst_buffer *st_bp, i
for (i=0, offset=st_bp->buffer_bytes;
i < st_bp->sg_segs && offset >= st_bp->sg[i].length; i++)
- offset -= st_bp->sg[i].length;
+ offset -= st_bp->sg[i].length;
if (i == st_bp->sg_segs) { /* Should never happen */
printk(KERN_WARNING "osst :A: Append_to_buffer offset overflow.\n");
return (-EIO);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-29 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 12:39 [patch] [SCSI] osst: indent for loop body Dan Carpenter
2014-04-29 12:39 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.