From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>
Cc: Sreekanth Reddy <Sreekanth.Reddy@lsi.com>,
support@lsi.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
DL-MPTFusionLinux@lsi.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [SCSI] mpt3sas: tidy up output slightly
Date: Tue, 29 Apr 2014 12:45:22 +0000 [thread overview]
Message-ID: <20140429124522.GR4963@mwanda> (raw)
In-Reply-To: <20140328083901.GQ25192@mwanda>
Hi Nagalakshmi,
Welcome back from vacation. Please Ack this patch because output is
still badly fromatted in linux-next.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 11:39:01AM +0300, Dan Carpenter wrote:
> The indenting here for "pr_info("\n");" is not correct. It's not part
> of the if condition.
>
> Also using pr_info() would put extra characters in the middle of the
> line. I suppose that people could complain that pr_cont() is racy but
> at least it's better than the original code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 0cf4f70..aa0e042 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -585,9 +585,9 @@ _base_display_event_data(struct MPT3SAS_ADAPTER *ioc,
> (event_data->ReasonCode = MPI2_EVENT_SAS_DISC_RC_STARTED) ?
> "start" : "stop");
> if (event_data->DiscoveryStatus)
> - pr_info("discovery_status(0x%08x)",
> + pr_cont("discovery_status(0x%08x)",
> le32_to_cpu(event_data->DiscoveryStatus));
> - pr_info("\n");
> + pr_cont("\n");
> return;
> }
> case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>
Cc: Sreekanth Reddy <Sreekanth.Reddy@lsi.com>,
support@lsi.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
DL-MPTFusionLinux@lsi.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [SCSI] mpt3sas: tidy up output slightly
Date: Tue, 29 Apr 2014 15:45:22 +0300 [thread overview]
Message-ID: <20140429124522.GR4963@mwanda> (raw)
In-Reply-To: <20140328083901.GQ25192@mwanda>
Hi Nagalakshmi,
Welcome back from vacation. Please Ack this patch because output is
still badly fromatted in linux-next.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 11:39:01AM +0300, Dan Carpenter wrote:
> The indenting here for "pr_info("\n");" is not correct. It's not part
> of the if condition.
>
> Also using pr_info() would put extra characters in the middle of the
> line. I suppose that people could complain that pr_cont() is racy but
> at least it's better than the original code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 0cf4f70..aa0e042 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -585,9 +585,9 @@ _base_display_event_data(struct MPT3SAS_ADAPTER *ioc,
> (event_data->ReasonCode == MPI2_EVENT_SAS_DISC_RC_STARTED) ?
> "start" : "stop");
> if (event_data->DiscoveryStatus)
> - pr_info("discovery_status(0x%08x)",
> + pr_cont("discovery_status(0x%08x)",
> le32_to_cpu(event_data->DiscoveryStatus));
> - pr_info("\n");
> + pr_cont("\n");
> return;
> }
> case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
next prev parent reply other threads:[~2014-04-29 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 8:39 [patch] [SCSI] mpt3sas: tidy up output slightly Dan Carpenter
2014-03-28 8:39 ` Dan Carpenter
2014-04-29 12:45 ` Dan Carpenter [this message]
2014-04-29 12:45 ` Dan Carpenter
2014-05-02 11:44 ` Reddy, Sreekanth
2014-05-02 11:44 ` Reddy, Sreekanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429124522.GR4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=JBottomley@parallels.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=support@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.