From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: add SD wp-gpios to Venice2 DT
Date: Tue, 29 Apr 2014 15:34:50 +0200 [thread overview]
Message-ID: <20140429133449.GA23699@ulmo> (raw)
In-Reply-To: <1398711219-23029-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
On Mon, Apr 28, 2014 at 12:53:39PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Venice2 can detect write-protect on the SD card. Add the required
> DT entries to allow this.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Thierry, could you test this for me; my Venice2 has been sent away for
> a few days for some rework. You should find that if you write-protect
> your SD card, the kernel fails/panics trying to mount it as a r/w root
> fs, whereas if the card is not write-protected, everything still works
> fine. Thanks.
> ---
> arch/arm/boot/dts/tegra124-venice2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
> index 84a6ec039e1d..00e741ba6927 100644
> --- a/arch/arm/boot/dts/tegra124-venice2.dts
> +++ b/arch/arm/boot/dts/tegra124-venice2.dts
> @@ -943,6 +943,7 @@
> sdhci@0,700b0400 {
> cd-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> power-gpios = <&gpio TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>;
> + wp-gpios = <&gpio TEGRA_GPIO(Q, 4) GPIO_ACTIVE_HIGH>;
I need to make this GPIO_ACTIVE_LOW for this to work properly on my
Venice2. With that I can see the initrd reporting:
mount: /dev/mmcblk0p1 is write-protected, mounting read-only
So with that changed:
Tested-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add SD wp-gpios to Venice2 DT
Date: Tue, 29 Apr 2014 15:34:50 +0200 [thread overview]
Message-ID: <20140429133449.GA23699@ulmo> (raw)
In-Reply-To: <1398711219-23029-1-git-send-email-swarren@wwwdotorg.org>
On Mon, Apr 28, 2014 at 12:53:39PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Venice2 can detect write-protect on the SD card. Add the required
> DT entries to allow this.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Thierry, could you test this for me; my Venice2 has been sent away for
> a few days for some rework. You should find that if you write-protect
> your SD card, the kernel fails/panics trying to mount it as a r/w root
> fs, whereas if the card is not write-protected, everything still works
> fine. Thanks.
> ---
> arch/arm/boot/dts/tegra124-venice2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
> index 84a6ec039e1d..00e741ba6927 100644
> --- a/arch/arm/boot/dts/tegra124-venice2.dts
> +++ b/arch/arm/boot/dts/tegra124-venice2.dts
> @@ -943,6 +943,7 @@
> sdhci at 0,700b0400 {
> cd-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> power-gpios = <&gpio TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>;
> + wp-gpios = <&gpio TEGRA_GPIO(Q, 4) GPIO_ACTIVE_HIGH>;
I need to make this GPIO_ACTIVE_LOW for this to work properly on my
Venice2. With that I can see the initrd reporting:
mount: /dev/mmcblk0p1 is write-protected, mounting read-only
So with that changed:
Tested-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140429/b3a92f2a/attachment.sig>
next prev parent reply other threads:[~2014-04-29 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 18:53 [PATCH] ARM: tegra: add SD wp-gpios to Venice2 DT Stephen Warren
2014-04-28 18:53 ` Stephen Warren
[not found] ` <1398711219-23029-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-29 13:34 ` Thierry Reding [this message]
2014-04-29 13:34 ` Thierry Reding
2014-05-06 17:04 ` Stephen Warren
2014-05-06 17:04 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429133449.GA23699@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.