All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: mst@redhat.com, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org, jhs@mojatatu.com,
	john.r.fastabend@intel.com, shemminger@vyatta.com
Subject: Re: [Bridge] [RFC PATCH v2 net-next 0/7] Non-promisc bidge ports support
Date: Wed, 30 Apr 2014 10:22:41 -0700	[thread overview]
Message-ID: <20140430102241.2fa8ac7b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1398806428-640-1-git-send-email-vyasevic@redhat.com>

On Tue, 29 Apr 2014 17:20:21 -0400
Vlad Yasevich <vyasevic@redhat.com> wrote:

> This patch series is a re-implementation of prior attempts to support
> non-promiscuous bridge ports.
> 
> The basic concept is the same as before.  The bridge keeps
> track of the ports that support learning and flooding packets
> to unknown destinations.  We call these ports auto-discovery
> ports since they automatically discover who is behind them through
> learning and flooding.  
> 
> If flooding and learning are disabled via flags, then the port
> requires static configuration to tell it which mac addresses
> are behind it.  This is accomplished through adding of fdbs.
> These fdbs should be static as dynamic fdbs can expire and systems
> will become unreachable due to lack of flooding.
> 
> If the user marks all ports are needing static configuration then
> we can safely make them non-promiscuous, we will know all the
> information about them.
> 
> If the user leaves only 1 port as automatic, then we can mark
> that port as not-promiscuous as well.  One could think of
> this a edge relay similar to what's support by embedded switches
> in SRIOV devices.  Since we have all the information about the
> other ports, we can just program the mac addresses into the
> single automatic port to receive all necessary traffic.
> 
> In other cases, we keep all ports promiscuous as before.
> 
> There are some other cases when promiscuous mode has to be turned
> back on.  One is when the bridge itself if placed in promiscuous
> mode (use sets promisc flag).  The other is if vlan filtering is
> turned off.  Since this is the default configuration, the default
> bridge operation is not changed.

I like this because it does the right thing and is transparent to
the user. You might also not want to do it if the underlying device
does not support multiple MAC addresses 
ie !(dev->priv_flags & IFF_UNICAST_FLT)


You could even go into looking at L2 offload on lower device.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	shemminger@vyatta.com, jhs@mojatatu.com,
	john.r.fastabend@intel.com, mst@redhat.com
Subject: Re: [RFC PATCH v2 net-next 0/7] Non-promisc bidge ports support
Date: Wed, 30 Apr 2014 10:22:41 -0700	[thread overview]
Message-ID: <20140430102241.2fa8ac7b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1398806428-640-1-git-send-email-vyasevic@redhat.com>

On Tue, 29 Apr 2014 17:20:21 -0400
Vlad Yasevich <vyasevic@redhat.com> wrote:

> This patch series is a re-implementation of prior attempts to support
> non-promiscuous bridge ports.
> 
> The basic concept is the same as before.  The bridge keeps
> track of the ports that support learning and flooding packets
> to unknown destinations.  We call these ports auto-discovery
> ports since they automatically discover who is behind them through
> learning and flooding.  
> 
> If flooding and learning are disabled via flags, then the port
> requires static configuration to tell it which mac addresses
> are behind it.  This is accomplished through adding of fdbs.
> These fdbs should be static as dynamic fdbs can expire and systems
> will become unreachable due to lack of flooding.
> 
> If the user marks all ports are needing static configuration then
> we can safely make them non-promiscuous, we will know all the
> information about them.
> 
> If the user leaves only 1 port as automatic, then we can mark
> that port as not-promiscuous as well.  One could think of
> this a edge relay similar to what's support by embedded switches
> in SRIOV devices.  Since we have all the information about the
> other ports, we can just program the mac addresses into the
> single automatic port to receive all necessary traffic.
> 
> In other cases, we keep all ports promiscuous as before.
> 
> There are some other cases when promiscuous mode has to be turned
> back on.  One is when the bridge itself if placed in promiscuous
> mode (use sets promisc flag).  The other is if vlan filtering is
> turned off.  Since this is the default configuration, the default
> bridge operation is not changed.

I like this because it does the right thing and is transparent to
the user. You might also not want to do it if the underlying device
does not support multiple MAC addresses 
ie !(dev->priv_flags & IFF_UNICAST_FLT)


You could even go into looking at L2 offload on lower device.

  parent reply	other threads:[~2014-04-30 17:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29 21:20 [Bridge] [RFC PATCH v2 net-next 0/7] Non-promisc bidge ports support Vlad Yasevich
2014-04-29 21:20 ` Vlad Yasevich
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 1/7] bridge: Turn flag change macro into a function Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 2/7] bridge: Keep track of ports capable of automatic discovery Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-30 10:18   ` [Bridge] " Michael S. Tsirkin
2014-04-30 10:18     ` Michael S. Tsirkin
2014-04-30 13:47     ` [Bridge] " Vlad Yasevich
2014-04-30 13:47       ` Vlad Yasevich
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 3/7] bridge: Add functionality to sync static fdb entries to hw Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 4/7] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-30 11:46   ` [Bridge] " Michael S. Tsirkin
2014-04-30 11:46     ` Michael S. Tsirkin
2014-04-30 14:17     ` [Bridge] " Vlad Yasevich
2014-04-30 14:17       ` Vlad Yasevich
2014-04-30 15:38       ` [Bridge] " Michael S. Tsirkin
2014-04-30 15:38         ` Michael S. Tsirkin
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 5/7] bridge: Add addresses from static fdbs to non-promisc ports Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 6/7] bridge: Correctly manage promiscuity when user requested it Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-29 21:20 ` [Bridge] [RFC PATCH v2 net-next 7/7] bridge: Automatically manage promisc mode when vlan filtering is on Vlad Yasevich
2014-04-29 21:20   ` Vlad Yasevich
2014-04-30 17:22 ` Stephen Hemminger [this message]
2014-04-30 17:22   ` [RFC PATCH v2 net-next 0/7] Non-promisc bidge ports support Stephen Hemminger
2014-04-30 17:37   ` [Bridge] " Michael S. Tsirkin
2014-04-30 17:37     ` Michael S. Tsirkin
2014-04-30 18:50   ` [Bridge] " Vlad Yasevich
2014-04-30 18:50     ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430102241.2fa8ac7b@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.