From: Stephen Boyd <sboyd@codeaurora.org>
To: Mike Turquette <mturquette@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: Various fixes for MSM8960's global clock controller
Date: Wed, 30 Apr 2014 08:53:08 -0700 [thread overview]
Message-ID: <20140430155308.GE20486@codeaurora.org> (raw)
In-Reply-To: <20140429065114.7224.13620@quantum>
On 04/28, Mike Turquette wrote:
> Quoting Kumar Gala (2014-04-04 09:32:56)
> > diff --git a/include/dt-bindings/clock/qcom,gcc-msm8960.h b/include/dt-bindings/clock/qcom,gcc-msm8960.h
> > index 03bbf49..f9f5471 100644
> > --- a/include/dt-bindings/clock/qcom,gcc-msm8960.h
> > +++ b/include/dt-bindings/clock/qcom,gcc-msm8960.h
> > @@ -51,7 +51,7 @@
> > #define QDSS_TSCTR_CLK 34
> > #define SFAB_ADM0_M0_A_CLK 35
> > #define SFAB_ADM0_M1_A_CLK 36
> > -#define SFAB_ADM0_M2_A_CLK 37
> > +#define SFAB_ADM0_M2_H_CLK 37
>
> Technically these changes break backwards compatibility, but I guess
> that field updates to newer kernel images for this SoC are not a
> concern?
I thought only the number was the ABI. The #defines are just here
to make it easier to speak about the same numbers in the driver
and the DT. Technically we could have made two #defines for 37
but since nobody is using it so far, it seems easier to just
rename it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: qcom: Various fixes for MSM8960's global clock controller
Date: Wed, 30 Apr 2014 08:53:08 -0700 [thread overview]
Message-ID: <20140430155308.GE20486@codeaurora.org> (raw)
In-Reply-To: <20140429065114.7224.13620@quantum>
On 04/28, Mike Turquette wrote:
> Quoting Kumar Gala (2014-04-04 09:32:56)
> > diff --git a/include/dt-bindings/clock/qcom,gcc-msm8960.h b/include/dt-bindings/clock/qcom,gcc-msm8960.h
> > index 03bbf49..f9f5471 100644
> > --- a/include/dt-bindings/clock/qcom,gcc-msm8960.h
> > +++ b/include/dt-bindings/clock/qcom,gcc-msm8960.h
> > @@ -51,7 +51,7 @@
> > #define QDSS_TSCTR_CLK 34
> > #define SFAB_ADM0_M0_A_CLK 35
> > #define SFAB_ADM0_M1_A_CLK 36
> > -#define SFAB_ADM0_M2_A_CLK 37
> > +#define SFAB_ADM0_M2_H_CLK 37
>
> Technically these changes break backwards compatibility, but I guess
> that field updates to newer kernel images for this SoC are not a
> concern?
I thought only the number was the ABI. The #defines are just here
to make it easier to speak about the same numbers in the driver
and the DT. Technically we could have made two #defines for 37
but since nobody is using it so far, it seems easier to just
rename it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-30 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 16:32 [PATCH] clk: qcom: Various fixes for MSM8960's global clock controller Kumar Gala
2014-04-04 16:32 ` Kumar Gala
2014-04-04 18:18 ` Stephen Boyd
2014-04-04 18:18 ` Stephen Boyd
2014-04-29 6:51 ` Mike Turquette
2014-04-29 6:51 ` Mike Turquette
2014-04-30 15:53 ` Stephen Boyd [this message]
2014-04-30 15:53 ` Stephen Boyd
2014-04-30 19:14 ` Mike Turquette
2014-04-30 19:14 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430155308.GE20486@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.