Re: [lm-sensors] [PATCH v2] mfd: vexpress: Convert custom func API to regmap

From: Guenter Roeck <linux@roeck-us.net>
To: Pawel Moll <pawel.moll@arm.com>
Cc: Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Russell King <linux@arm.linux.org.uk>,
	Mike Turquette <mturquette@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Jean Delvare <jdelvare@suse.de>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	arm@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [PATCH v2] mfd: vexpress: Convert custom func API to regmap
Date: Wed, 30 Apr 2014 17:05:25 +0000	[thread overview]
Message-ID: <20140430170525.GA3389@roeck-us.net> (raw)
In-Reply-To: <1398873686-8618-1-git-send-email-pawel.moll@arm.com>

On Wed, Apr 30, 2014 at 05:01:26PM +0100, Pawel Moll wrote:
> Components of the Versatile Express platform (configuration
> microcontrollers on motherboard and daughterboards in particular)
> talk to each other over a custom configuration bus. They
> provide miscellaneous functions (from clock generator control
> to energy sensors) which are represented as platform devices
> (and Device Tree nodes). The transactions on the bus can
> be generated by different "bridges" in the system, some
> of which are universal for the whole platform (for the price
> of high transfer latencies), others restricted to a subsystem
> (but much faster).
> 
> Until now drivers for such functions were using custom "func"
> API, which is being replaced in this patch by regmap calls.
> This required:
> 
> * a rework (and move to drivers/bus directory, as suggested
>   by Samuel and Arnd) of the config bus core, which is much
>   simpler now and uses device model infrastructure (class)
>   to keep track of the bridges; non-DT case (soon to be
>   retired anyway) is simply covered by a special device
>   registration function
> 
> * the new config-bus driver also takes over device population,
>   so there is no need for special matching table for
>   of_platform_populate nor "simple-bus" hack in the arm64
>   model dtsi file (relevant bindings documentation has
>   been updated); this allows all the vexpress devices
>   fit into normal device model, making it possible
>   to remove plenty of early inits and other hacks in
>   the near future
> 
> * adaptation of the syscfg bridge implementation in the
>   sysreg driver, again making it much simpler; there is
>   a special case of the "energy" function spanning two
>   registers, where they should be both defined in the tree
>   now, but backward compatibility is maintained in the code
> 
> * modification of the relevant drivers:
> 
>   * hwmon - just a straight-forward API change
>   * power/reset driver - API change
>   * regulator - API change plus error handling
>     simplification
>   * osc clock driver - this one required larger rework
>     in order to turn in into a standard platform driver
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> Acked-by: Mark Brown <broonie@linaro.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>

For hwmon:

Acked-by: Guenter Roeck <linux@roeck-us.net>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors