All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Wolfram Sang
	<wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
Subject: Re: [RFC] i2c: sh_mobile: WIP! Fix clock calculation for newer SoCs
Date: Thu, 1 May 2014 18:50:22 +0200	[thread overview]
Message-ID: <20140501165019.GA2602@katana> (raw)
In-Reply-To: <CAMuHMdUVCP-dwJ-HMD1xHb9qR_qm-n0YTpYVq9w37DvD=E=X=w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On Thu, May 01, 2014 at 03:26:15PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Thu, May 1, 2014 at 1:59 PM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> > +static const struct of_device_id sh_mobile_i2c_dt_ids[] = {
> > +       { .compatible = "renesas,rmobile-iic", .data = (void *)1 },
> > +       { .compatible = "renesas,iic-r8a7790", .data = (void *)2 },
> > +       { .compatible = "renesas,iic-r8a7791", .data = (void *)2 },
> > +       {},
> > +};
> > +MODULE_DEVICE_TABLE(of, sh_mobile_i2c_dt_ids);
> 
> > +               const struct of_device_id *match;
> > +
> > +               match = of_match_device(sh_mobile_i2c_dt_ids, &dev->dev);
> > +               pd->clks_per_count = match->data;
> 
> Missing cast "(int)match->data"?

"This patch still needs some improvements, but already shows what I am
aiming for." :)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Wolfram Sang
	<wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
Subject: Re: [RFC] i2c: sh_mobile: WIP! Fix clock calculation for newer SoCs
Date: Thu, 01 May 2014 16:50:22 +0000	[thread overview]
Message-ID: <20140501165019.GA2602@katana> (raw)
In-Reply-To: <CAMuHMdUVCP-dwJ-HMD1xHb9qR_qm-n0YTpYVq9w37DvD=E=X=w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On Thu, May 01, 2014 at 03:26:15PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Thu, May 1, 2014 at 1:59 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > +static const struct of_device_id sh_mobile_i2c_dt_ids[] = {
> > +       { .compatible = "renesas,rmobile-iic", .data = (void *)1 },
> > +       { .compatible = "renesas,iic-r8a7790", .data = (void *)2 },
> > +       { .compatible = "renesas,iic-r8a7791", .data = (void *)2 },
> > +       {},
> > +};
> > +MODULE_DEVICE_TABLE(of, sh_mobile_i2c_dt_ids);
> 
> > +               const struct of_device_id *match;
> > +
> > +               match = of_match_device(sh_mobile_i2c_dt_ids, &dev->dev);
> > +               pd->clks_per_count = match->data;
> 
> Missing cast "(int)match->data"?

"This patch still needs some improvements, but already shows what I am
aiming for." :)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-05-01 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 11:59 [RFC] i2c: sh_mobile: WIP! Fix clock calculation for newer SoCs Wolfram Sang
2014-05-01 11:59 ` Wolfram Sang
     [not found] ` <1398945555-12928-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-05-01 13:26   ` Geert Uytterhoeven
2014-05-01 13:26     ` Geert Uytterhoeven
2014-05-01 16:50     ` Wolfram Sang [this message]
2014-05-01 16:50       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140501165019.GA2602@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.