From: Mark Brown <broonie@kernel.org>
To: Xia Kaixu <kaixu.xia@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
arnd@arndb.de, Liam Girdwood <lgirdwood@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 11/15] ASoC: WM0010 needs SPI
Date: Thu, 1 May 2014 12:08:42 -0700 [thread overview]
Message-ID: <20140501190842.GZ3245@sirena.org.uk> (raw)
In-Reply-To: <1398770316-19715-12-git-send-email-kaixu.xia@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
On Tue, Apr 29, 2014 at 07:18:32PM +0800, Xia Kaixu wrote:
> @@ -201,7 +201,7 @@ config SND_SOC_SPEYSIDE
> select SND_SAMSUNG_I2S
> select SND_SOC_WM8996
> select SND_SOC_WM9081
> - select SND_SOC_WM0010
> + select SND_SOC_WM0010 if SPI
> select SND_SOC_WM1250_EV1
No, this is broken. The driver won't work if all the components it uses
don't load and the dependency for SPI isn't SPI, it's SPI_MASTER.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/15] ASoC: WM0010 needs SPI
Date: Thu, 1 May 2014 12:08:42 -0700 [thread overview]
Message-ID: <20140501190842.GZ3245@sirena.org.uk> (raw)
In-Reply-To: <1398770316-19715-12-git-send-email-kaixu.xia@linaro.org>
On Tue, Apr 29, 2014 at 07:18:32PM +0800, Xia Kaixu wrote:
> @@ -201,7 +201,7 @@ config SND_SOC_SPEYSIDE
> select SND_SAMSUNG_I2S
> select SND_SOC_WM8996
> select SND_SOC_WM9081
> - select SND_SOC_WM0010
> + select SND_SOC_WM0010 if SPI
> select SND_SOC_WM1250_EV1
No, this is broken. The driver won't work if all the components it uses
don't load and the dependency for SPI isn't SPI, it's SPI_MASTER.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140501/7b3f6f04/attachment.sig>
next prev parent reply other threads:[~2014-05-01 19:08 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 11:18 [PATCH 00/15] ASoC: Arnds randconfig fixes for ASoC Xia Kaixu
2014-04-29 11:18 ` [PATCH 01/15] ASoC: CS42L51 and WM8962 codecs depend on INPUT Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-04-30 2:31 ` Brian Austin
2014-04-30 2:31 ` [alsa-devel] " Brian Austin
2014-04-30 2:31 ` Brian Austin
2014-05-01 1:31 ` Mark Brown
2014-05-01 1:31 ` Mark Brown
2014-05-01 1:54 ` Austin, Brian
2014-05-01 1:54 ` [alsa-devel] " Austin, Brian
2014-05-01 1:54 ` Austin, Brian
2014-05-01 2:16 ` Austin, Brian
2014-05-01 2:16 ` [alsa-devel] " Austin, Brian
2014-05-01 2:16 ` Austin, Brian
2014-05-01 3:27 ` Mark Brown
2014-05-01 3:27 ` Mark Brown
2014-05-01 12:26 ` Austin, Brian
2014-05-01 12:26 ` [alsa-devel] " Austin, Brian
2014-05-01 12:26 ` Austin, Brian
2014-05-01 1:30 ` Mark Brown
2014-05-01 1:30 ` Mark Brown
2014-04-29 11:18 ` [PATCH 02/15] ASoC: davinci: add dependencies for SND_SOC_TLV320AIC3X Xia Kaixu
2014-05-01 3:29 ` Mark Brown
2014-04-29 11:18 ` [PATCH 03/15] ASoC: SMDK_WM8580_PCM needs REGMAP_I2C Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 3:30 ` Mark Brown
2014-05-01 3:30 ` Mark Brown
2014-04-29 11:18 ` [PATCH 04/15] ASoC: samsung-idma: avoid 64-bit division Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-04-30 3:50 ` Tushar Behera
2014-04-30 3:50 ` Tushar Behera
2014-05-01 3:31 ` Mark Brown
2014-05-01 3:31 ` Mark Brown
2014-04-29 11:18 ` [PATCH 05/15] ASoC: nuc900: export nuc900_ac97_data Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 3:32 ` Mark Brown
2014-05-01 3:32 ` Mark Brown
2014-04-29 11:18 ` [PATCH 06/15] ASoC: RX-51 audio needs I2C Xia Kaixu
2014-05-01 17:59 ` Mark Brown
2014-04-29 11:18 ` [PATCH 07/15] ASoC: UDA1380 " Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 17:59 ` Mark Brown
2014-05-01 17:59 ` Mark Brown
2014-04-29 11:18 ` [PATCH 08/15] ASoC: TTC DKB audio " Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 18:01 ` Mark Brown
2014-05-01 18:01 ` Mark Brown
2014-04-29 11:18 ` [PATCH 09/15] ASoC: Migo-R sound " Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 20:30 ` Mark Brown
2014-05-01 20:30 ` Mark Brown
2014-04-29 11:18 ` [PATCH 10/15] ASoC: TLV320AIC23 and Simtec Hermes audio Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 20:29 ` Mark Brown
2014-05-01 20:29 ` Mark Brown
2014-04-29 11:18 ` [PATCH 11/15] ASoC: WM0010 needs SPI Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 19:08 ` Mark Brown [this message]
2014-05-01 19:08 ` Mark Brown
2014-04-29 11:18 ` [PATCH 12/15] ASoC: Atmel WM8904 codec support needs I2C Xia Kaixu
2014-05-01 19:09 ` Mark Brown
2014-04-29 11:18 ` [PATCH 13/15] ASoC: SND_S3C_DMA_LEGACY needs S3C24XX_DMA Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
2014-05-01 19:11 ` Mark Brown
2014-05-01 19:11 ` Mark Brown
2014-05-01 22:35 ` Arnd Bergmann
2014-05-01 22:35 ` Arnd Bergmann
2014-05-02 10:25 ` Heiko Stübner
2014-05-02 10:25 ` Heiko Stübner
2014-05-02 16:10 ` Arnd Bergmann
2014-05-02 16:10 ` Arnd Bergmann
2014-05-02 16:10 ` Arnd Bergmann
2014-05-02 17:26 ` Mark Brown
2014-05-02 17:26 ` Mark Brown
2014-05-02 17:24 ` Mark Brown
2014-05-02 17:24 ` Mark Brown
2014-04-29 11:18 ` [PATCH 14/15] ASoC: Amstrad E3 needs TTY support for codec Xia Kaixu
2014-05-01 20:31 ` Mark Brown
2014-04-29 11:18 ` [PATCH 15/15] ASoC: pxa: remove mach header dependency Xia Kaixu
2014-04-29 11:18 ` Xia Kaixu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501190842.GZ3245@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=kaixu.xia@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.