From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: dri-devel@lists.freedesktop.org, Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] Use signed location for drmModeSetPlane
Date: Thu, 1 May 2014 23:41:33 +0300 [thread overview]
Message-ID: <20140501204133.GQ18465@intel.com> (raw)
In-Reply-To: <1398945403-19018-1-git-send-email-djkurtz@chromium.org>
On Thu, May 01, 2014 at 07:56:43PM +0800, Daniel Kurtz wrote:
> DRM_IOCTL_MODE_SETPLANE crtc_x, crtc_y are s32.
> This is to allow a destination location that is partially off screen.
>
> Make this more obvious to users of libdrm by using signed crtc_x/_y
> parameters for drmModeSetPlane() as well.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
and pushed.
> ---
> xf86drmMode.c | 2 +-
> xf86drmMode.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xf86drmMode.c b/xf86drmMode.c
> index a6bb2ee..7ca89b3 100644
> --- a/xf86drmMode.c
> +++ b/xf86drmMode.c
> @@ -906,7 +906,7 @@ int drmModePageFlip(int fd, uint32_t crtc_id, uint32_t fb_id,
>
> int drmModeSetPlane(int fd, uint32_t plane_id, uint32_t crtc_id,
> uint32_t fb_id, uint32_t flags,
> - uint32_t crtc_x, uint32_t crtc_y,
> + int32_t crtc_x, int32_t crtc_y,
> uint32_t crtc_w, uint32_t crtc_h,
> uint32_t src_x, uint32_t src_y,
> uint32_t src_w, uint32_t src_h)
> diff --git a/xf86drmMode.h b/xf86drmMode.h
> index 9bcb1d1..6eab565 100644
> --- a/xf86drmMode.h
> +++ b/xf86drmMode.h
> @@ -445,7 +445,7 @@ extern drmModePlaneResPtr drmModeGetPlaneResources(int fd);
> extern drmModePlanePtr drmModeGetPlane(int fd, uint32_t plane_id);
> extern int drmModeSetPlane(int fd, uint32_t plane_id, uint32_t crtc_id,
> uint32_t fb_id, uint32_t flags,
> - uint32_t crtc_x, uint32_t crtc_y,
> + int32_t crtc_x, int32_t crtc_y,
> uint32_t crtc_w, uint32_t crtc_h,
> uint32_t src_x, uint32_t src_y,
> uint32_t src_w, uint32_t src_h);
> --
> 1.9.1.423.g4596e3a
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2014-05-01 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 11:56 [PATCH] Use signed location for drmModeSetPlane Daniel Kurtz
2014-05-01 20:41 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501204133.GQ18465@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.