From: "Linus Lüssing" <linus.luessing@web.de>
To: David Miller <davem@davemloft.net>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [Bridge] [PATCH] bridge: simplify a br_multicast_query_received() function call
Date: Fri, 2 May 2014 05:14:05 +0200 [thread overview]
Message-ID: <20140502031404.GR4593@Linus-Debian> (raw)
In-Reply-To: <20140423.144748.1259564888396787227.davem@davemloft.net>
On Wed, Apr 23, 2014 at 02:47:48PM -0400, David Miller wrote:
> > --- a/net/bridge/br_multicast.c
> > +++ b/net/bridge/br_multicast.c
> > @@ -1282,8 +1282,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
> > goto out;
> > }
> >
> > - br_multicast_query_received(br, port, &br->ip6_querier,
> > - !ipv6_addr_any(&ip6h->saddr),
> > + br_multicast_query_received(br, port, &br->ip6_querier, 1,
> > is_general_query, max_delay);
> >
> > if (!group)
>
> This doesn't make any sense to me, is_general_query can be false at this
> point.
This change has nothing to do with is_general_query, the fifth
argument. I'm modifying the fourth, the is_saddr flag. As Hannes
has pointed out here [0], now that we make sure that we have a
link-local IPv6 address at the beginning of
br_ip6_multicast_query() this implies that the source address is
not '::'.
>
> Furthermore, even if your change would be correct, the argument is a
> boolean not an integer.
Semantically yes. Syntactically the fourth argument is an integer
at the moment (unnecessarily). Should I change 'int saddr' to
'bool saddr' while at it, within the same patch?
Cheers
WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@web.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
stephen@networkplumber.org, linux-kernel@vger.kernel.org,
hannes@stressinduktion.org
Subject: Re: [PATCH] bridge: simplify a br_multicast_query_received() function call
Date: Fri, 2 May 2014 05:14:05 +0200 [thread overview]
Message-ID: <20140502031404.GR4593@Linus-Debian> (raw)
In-Reply-To: <20140423.144748.1259564888396787227.davem@davemloft.net>
On Wed, Apr 23, 2014 at 02:47:48PM -0400, David Miller wrote:
> > --- a/net/bridge/br_multicast.c
> > +++ b/net/bridge/br_multicast.c
> > @@ -1282,8 +1282,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
> > goto out;
> > }
> >
> > - br_multicast_query_received(br, port, &br->ip6_querier,
> > - !ipv6_addr_any(&ip6h->saddr),
> > + br_multicast_query_received(br, port, &br->ip6_querier, 1,
> > is_general_query, max_delay);
> >
> > if (!group)
>
> This doesn't make any sense to me, is_general_query can be false at this
> point.
This change has nothing to do with is_general_query, the fifth
argument. I'm modifying the fourth, the is_saddr flag. As Hannes
has pointed out here [0], now that we make sure that we have a
link-local IPv6 address at the beginning of
br_ip6_multicast_query() this implies that the source address is
not '::'.
>
> Furthermore, even if your change would be correct, the argument is a
> boolean not an integer.
Semantically yes. Syntactically the fourth argument is an integer
at the moment (unnecessarily). Should I change 'int saddr' to
'bool saddr' while at it, within the same patch?
Cheers
WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@web.de>
To: David Miller <davem@davemloft.net>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: simplify a br_multicast_query_received() function call
Date: Fri, 2 May 2014 05:14:05 +0200 [thread overview]
Message-ID: <20140502031404.GR4593@Linus-Debian> (raw)
In-Reply-To: <20140423.144748.1259564888396787227.davem@davemloft.net>
On Wed, Apr 23, 2014 at 02:47:48PM -0400, David Miller wrote:
> > --- a/net/bridge/br_multicast.c
> > +++ b/net/bridge/br_multicast.c
> > @@ -1282,8 +1282,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
> > goto out;
> > }
> >
> > - br_multicast_query_received(br, port, &br->ip6_querier,
> > - !ipv6_addr_any(&ip6h->saddr),
> > + br_multicast_query_received(br, port, &br->ip6_querier, 1,
> > is_general_query, max_delay);
> >
> > if (!group)
>
> This doesn't make any sense to me, is_general_query can be false at this
> point.
This change has nothing to do with is_general_query, the fifth
argument. I'm modifying the fourth, the is_saddr flag. As Hannes
has pointed out here [0], now that we make sure that we have a
link-local IPv6 address at the beginning of
br_ip6_multicast_query() this implies that the source address is
not '::'.
>
> Furthermore, even if your change would be correct, the argument is a
> boolean not an integer.
Semantically yes. Syntactically the fourth argument is an integer
at the moment (unnecessarily). Should I change 'int saddr' to
'bool saddr' while at it, within the same patch?
Cheers
next prev parent reply other threads:[~2014-05-02 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 18:59 [Bridge] [PATCH] bridge: simplify a br_multicast_query_received() function call Linus Lüssing
2014-04-21 18:59 ` Linus Lüssing
2014-04-23 18:47 ` [Bridge] " David Miller
2014-04-23 18:47 ` David Miller
2014-04-23 18:47 ` David Miller
2014-05-02 3:14 ` Linus Lüssing [this message]
2014-05-02 3:14 ` Linus Lüssing
2014-05-02 3:14 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502031404.GR4593@Linus-Debian \
--to=linus.luessing@web.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.