From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 07/12 v4] tools/pygrub: store kernels in /var/run/xen/pygrub
Date: Fri, 2 May 2014 13:02:47 +0200 [thread overview]
Message-ID: <20140502110247.GC5612@aepfle.de> (raw)
In-Reply-To: <1399027798.32736.31.camel@kazak.uk.xensource.com>
On Fri, May 02, Ian Campbell wrote:
> On Thu, 2014-04-24 at 14:12 +0200, Olaf Hering wrote:
> > Move location of temporary bootfiles from /var/run/xend/boot to
> > /var/run/xen/pygrub. Create the subdirectory if does not exist, unless
> > --output-directory=<dir> was specified.
>
> I'm not at all opposed to this change but why this last condition? Any
> reason not to always create the directory if it doesn't exist?
>
> Or should there be an existence check when you specify
> --output-directory?
Without --output-directory the default should be created internally.
With --output-directory the specified dir should exist already.
Perhaps new code can be added to check if the given path is a directory.
Olaf
next prev parent reply other threads:[~2014-05-02 11:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 8:36 [PATCH 00/12] more tools changes to honor --prefix= Olaf Hering
2014-04-24 8:36 ` [PATCH 01/12] Config.mk: move directory list into BUILD_MAKE_VARS Olaf Hering
2014-05-02 10:40 ` Ian Campbell
2014-05-02 10:57 ` Olaf Hering
2014-05-02 11:46 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 02/12] Config.mk: replace dependency to genpath with actual target Olaf Hering
2014-05-02 10:43 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 03/12] Config.mk: add new macro buildmakevars2header Olaf Hering
2014-05-02 10:44 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 04/12] tools/libxl: use buildmakevars2header to create _paths.h Olaf Hering
2014-05-02 10:46 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 05/12] tools/libxc: provide variable paths to libxc Olaf Hering
2014-05-02 10:48 ` Ian Campbell
2014-05-02 10:58 ` Olaf Hering
2014-04-24 8:36 ` [PATCH 06/12] tools/libxc: use XEN_RUN_DIR for SUSPEND_LOCK_FILE Olaf Hering
2014-04-24 8:36 ` [PATCH 07/12] tools/pygrub: store kernels in /var/run/xen/pygrub Olaf Hering
2014-04-24 9:41 ` Andrew Cooper
2014-04-24 12:12 ` [PATCH 07/12 v4] " Olaf Hering
2014-05-02 10:49 ` Ian Campbell
2014-05-02 11:02 ` Olaf Hering [this message]
2014-05-02 11:48 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 08/12] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path Olaf Hering
2014-05-02 10:53 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 09/12] tools/hotplug: create XEN_RUN_DIR at runtime Olaf Hering
2014-05-02 10:54 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 10/12] tools/hotplug: create XEN_LOCK_DIR " Olaf Hering
2014-05-02 10:56 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 11/12] tools/examples: remove obsolete install targets Olaf Hering
2014-05-02 10:57 ` Ian Campbell
2014-04-24 8:36 ` [PATCH 12/12] remove obsolete SUBSYS_DIR variable Olaf Hering
2014-05-02 10:59 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502110247.GC5612@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.