From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [patch] drm/panel: s6e8aa0: silence array overflow warning
Date: Fri, 02 May 2014 11:21:11 +0000 [thread overview]
Message-ID: <20140502112109.GA18693@ulmo> (raw)
In-Reply-To: <20140409152112.GD24536@mwanda>
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Wed, Apr 09, 2014 at 06:21:12PM +0300, Dan Carpenter wrote:
> Smatch complains that we are reading beyond the end of the array here:
>
> drivers/gpu/drm/panel/panel-s6e8aa0.c:852 s6e8aa0_read_mtp_id()
> warn: buffer overflow 's6e8aa0_variants' 4 <= 4
>
> We set the error code, so it's not harmful but it looks like a return
> was intended here so lets add that and silence the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [patch] drm/panel: s6e8aa0: silence array overflow warning
Date: Fri, 2 May 2014 13:21:11 +0200 [thread overview]
Message-ID: <20140502112109.GA18693@ulmo> (raw)
In-Reply-To: <20140409152112.GD24536@mwanda>
[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]
On Wed, Apr 09, 2014 at 06:21:12PM +0300, Dan Carpenter wrote:
> Smatch complains that we are reading beyond the end of the array here:
>
> drivers/gpu/drm/panel/panel-s6e8aa0.c:852 s6e8aa0_read_mtp_id()
> warn: buffer overflow 's6e8aa0_variants' 4 <= 4
>
> We set the error code, so it's not harmful but it looks like a return
> was intended here so lets add that and silence the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-05-02 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:21 [patch] drm/panel: s6e8aa0: silence array overflow warning Dan Carpenter
2014-04-09 15:21 ` Dan Carpenter
2014-04-10 5:48 ` Andrzej Hajda
2014-04-10 5:48 ` Andrzej Hajda
2014-05-02 11:21 ` Thierry Reding [this message]
2014-05-02 11:21 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502112109.GA18693@ulmo \
--to=thierry.reding@gmail.com \
--cc=a.hajda@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.