* [PATCH] drivers/tty/hvc: don't free hvc_console_setup after init
@ 2014-05-02 22:18 Tomoki Sekiyama
0 siblings, 0 replies; 2+ messages in thread
From: Tomoki Sekiyama @ 2014-05-02 22:18 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, jslaby, mitsuhiro.tanino, paul.gortmaker
When 'console=hvc0' is specified to the kernel parameter in x86 KVM guest,
hvc console is setup within a kthread. However, that will cause SEGV
and the boot will fail when the driver is builtin to the kernel,
because currently hvc_console_setup() is annotated with '__init'. This
patch removes '__init' to boot the guest successfully with 'console=hvc0'.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
---
drivers/tty/hvc/hvc_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 94f9e3a..0ff7fda 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -190,7 +190,7 @@ static struct tty_driver *hvc_console_device(struct console *c, int *index)
return hvc_driver;
}
-static int __init hvc_console_setup(struct console *co, char *options)
+static int hvc_console_setup(struct console *co, char *options)
{
if (co->index < 0 || co->index >= MAX_NR_HVC_CONSOLES)
return -ENODEV;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drivers/tty/hvc: don't free hvc_console_setup after init
@ 2014-05-02 22:58 Tomoki Sekiyama
0 siblings, 0 replies; 2+ messages in thread
From: Tomoki Sekiyama @ 2014-05-02 22:58 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, jslaby, mitsuhiro.tanino, paul.gortmaker
When 'console=hvc0' is specified to the kernel parameter in x86 KVM guest,
hvc console is setup within a kthread. However, that will cause SEGV
and the boot will fail when the driver is builtin to the kernel,
because currently hvc_console_setup() is annotated with '__init'. This
patch removes '__init' to boot the guest successfully with 'console=hvc0'.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
---
drivers/tty/hvc/hvc_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 94f9e3a..0ff7fda 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -190,7 +190,7 @@ static struct tty_driver *hvc_console_device(struct console *c, int *index)
return hvc_driver;
}
-static int __init hvc_console_setup(struct console *co, char *options)
+static int hvc_console_setup(struct console *co, char *options)
{
if (co->index < 0 || co->index >= MAX_NR_HVC_CONSOLES)
return -ENODEV;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-03 1:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-02 22:58 [PATCH] drivers/tty/hvc: don't free hvc_console_setup after init Tomoki Sekiyama
-- strict thread matches above, loose matches on Subject: below --
2014-05-02 22:18 Tomoki Sekiyama
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.