From: Greg KH <gregkh@linuxfoundation.org>
To: Tomasz Stanislawski <t.stanislaws@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
arnd@arndb.de, linux-doc@vger.kernel.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kyungmin.park@samsung.com, robh+dt@kernel.org,
ben-linux@fluff.org, grant.likely@linaro.org,
kgene.kim@samsung.com, m.szyprowski@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/2] Add support for sii9234 chip
Date: Sat, 3 May 2014 19:17:26 -0400 [thread overview]
Message-ID: <20140503231726.GA20212@kroah.com> (raw)
In-Reply-To: <1397216910-15904-1-git-send-email-t.stanislaws@samsung.com>
On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote:
> Hi everyone,
> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used
> to convert HDMI signal into MHL. The driver enables HDMI output on Trats and
> Trats2 boards.
>
> The code is based on the driver [1] developed by:
> Adam Hampson <ahampson@sta.samsung.com>
> Erik Gilling <konkers@android.com>
> with additional contributions from:
> Shankar Bandal <shankar.b@samsung.com>
> Dharam Kumar <dharam.kr@samsung.com>
>
> The drivers architecture was greatly simplified and transformed into a form
> accepted (hopefully) by opensource community. The main differences from
> original code are:
> * using single I2C client instead of 4 subclients
> * remove all logic non-related to establishing HDMI link
> * simplify error handling
> * rewrite state machine in interrupt handler
> * wakeup and discovery triggered by an extcon event
> * integrate with Device Tree
>
> For now, the driver is added to drivers/misc/ directory because it has neigher
> userspace nor kernel interface. The chip is capable of receiving and
> processing CEC events, so the driver may export an input device in /dev/ in the
> future. However CEC could be also handled by HDMI driver.
>
> I kindly ask for suggestions about the best location for this driver.
It really is an extcon driver, so why not put it in drivers/extcon? And
that might solve any build issues you have if you don't select extcon in
your .config file and try to build this code :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Add support for sii9234 chip
Date: Sat, 3 May 2014 19:17:26 -0400 [thread overview]
Message-ID: <20140503231726.GA20212@kroah.com> (raw)
In-Reply-To: <1397216910-15904-1-git-send-email-t.stanislaws@samsung.com>
On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote:
> Hi everyone,
> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used
> to convert HDMI signal into MHL. The driver enables HDMI output on Trats and
> Trats2 boards.
>
> The code is based on the driver [1] developed by:
> Adam Hampson <ahampson@sta.samsung.com>
> Erik Gilling <konkers@android.com>
> with additional contributions from:
> Shankar Bandal <shankar.b@samsung.com>
> Dharam Kumar <dharam.kr@samsung.com>
>
> The drivers architecture was greatly simplified and transformed into a form
> accepted (hopefully) by opensource community. The main differences from
> original code are:
> * using single I2C client instead of 4 subclients
> * remove all logic non-related to establishing HDMI link
> * simplify error handling
> * rewrite state machine in interrupt handler
> * wakeup and discovery triggered by an extcon event
> * integrate with Device Tree
>
> For now, the driver is added to drivers/misc/ directory because it has neigher
> userspace nor kernel interface. The chip is capable of receiving and
> processing CEC events, so the driver may export an input device in /dev/ in the
> future. However CEC could be also handled by HDMI driver.
>
> I kindly ask for suggestions about the best location for this driver.
It really is an extcon driver, so why not put it in drivers/extcon? And
that might solve any build issues you have if you don't select extcon in
your .config file and try to build this code :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Tomasz Stanislawski <t.stanislaws@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
t.figa@samsung.com, kyungmin.park@samsung.com,
m.szyprowski@samsung.com, robh+dt@kernel.org, arnd@arndb.de,
grant.likely@linaro.org, kgene.kim@samsung.com,
rdunlap@infradead.org, ben-linux@fluff.org
Subject: Re: [PATCH 0/2] Add support for sii9234 chip
Date: Sat, 3 May 2014 19:17:26 -0400 [thread overview]
Message-ID: <20140503231726.GA20212@kroah.com> (raw)
In-Reply-To: <1397216910-15904-1-git-send-email-t.stanislaws@samsung.com>
On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote:
> Hi everyone,
> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used
> to convert HDMI signal into MHL. The driver enables HDMI output on Trats and
> Trats2 boards.
>
> The code is based on the driver [1] developed by:
> Adam Hampson <ahampson@sta.samsung.com>
> Erik Gilling <konkers@android.com>
> with additional contributions from:
> Shankar Bandal <shankar.b@samsung.com>
> Dharam Kumar <dharam.kr@samsung.com>
>
> The drivers architecture was greatly simplified and transformed into a form
> accepted (hopefully) by opensource community. The main differences from
> original code are:
> * using single I2C client instead of 4 subclients
> * remove all logic non-related to establishing HDMI link
> * simplify error handling
> * rewrite state machine in interrupt handler
> * wakeup and discovery triggered by an extcon event
> * integrate with Device Tree
>
> For now, the driver is added to drivers/misc/ directory because it has neigher
> userspace nor kernel interface. The chip is capable of receiving and
> processing CEC events, so the driver may export an input device in /dev/ in the
> future. However CEC could be also handled by HDMI driver.
>
> I kindly ask for suggestions about the best location for this driver.
It really is an extcon driver, so why not put it in drivers/extcon? And
that might solve any build issues you have if you don't select extcon in
your .config file and try to build this code :)
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-03 23:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 11:48 [PATCH 0/2] Add support for sii9234 chip Tomasz Stanislawski
2014-04-11 11:48 ` Tomasz Stanislawski
2014-04-11 11:48 ` Tomasz Stanislawski
2014-04-11 11:48 ` [PATCH 1/2] misc: add sii9234 driver Tomasz Stanislawski
2014-04-11 11:48 ` Tomasz Stanislawski
2014-04-11 11:48 ` Tomasz Stanislawski
2014-05-03 23:17 ` Greg KH
2014-05-03 23:17 ` Greg KH
2014-05-03 23:17 ` Greg KH
2014-04-11 11:48 ` [PATCH 2/2] arm: dts: trats2: add SiI9234 node Tomasz Stanislawski
2014-04-11 11:48 ` Tomasz Stanislawski
2014-04-11 11:48 ` Tomasz Stanislawski
2014-05-03 23:17 ` Greg KH [this message]
2014-05-03 23:17 ` [PATCH 0/2] Add support for sii9234 chip Greg KH
2014-05-03 23:17 ` Greg KH
2014-05-05 14:15 ` Tomasz Stanislawski
2014-05-05 14:15 ` Tomasz Stanislawski
2014-05-05 14:15 ` Tomasz Stanislawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140503231726.GA20212@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=grant.likely@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.