All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Karsten Keil <isdn@linux-pingi.de>, Jiri Kosina <jkosina@suse.cz>,
	Randy Dunlap <rdunlap@infradead.org>,
	Masanari Iida <standby24x7@gmail.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: hisax: clean up some indenting
Date: Mon, 05 May 2014 07:44:34 +0000	[thread overview]
Message-ID: <20140505074434.GN26890@mwanda> (raw)
In-Reply-To: <53668DFC.6040106@bfs.de>

On Sun, May 04, 2014 at 08:59:08PM +0200, walter harms wrote:
> > @@ -1051,12 +1054,13 @@ tx_b_frame(struct hfc4s8s_btype *bch)
> >  			cnt -= 4;
> >  		}
> >  
> > -		while (cnt--)
> > +		while (cnt--) {
> >  #ifdef HISAX_HFC4S8S_PCIMEM
> >  			fWrite_hfc8(l1->hw, A_FIFO_DATA0, *cp++);
> >  #else
> > -		fWrite_hfc8(l1->hw, *cp++);
> > +			fWrite_hfc8(l1->hw, *cp++);
> >  #endif
> > +		}
> 
> This looks wrong. The read above uses Read_hfc8/fRead_hfc8 (easy to
> confuse but i am not the maintainer ....)
> here we have 2* fWrite_hfc8() ?
> Does this compile with HISAX_HFC4S8S_PCIMEM ??
> 

Yeah.  You're right.  The first fWrite_hfc8() should be Write_hfc8().
This same mistake is made two other places which prevents the driver
from compiling with HISAX_HFC4S8S_PCIMEM.

I will just delete this code since it has been broken since 2.6.12.
Let me resend.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Karsten Keil <isdn@linux-pingi.de>, Jiri Kosina <jkosina@suse.cz>,
	Randy Dunlap <rdunlap@infradead.org>,
	Masanari Iida <standby24x7@gmail.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: hisax: clean up some indenting
Date: Mon, 5 May 2014 10:44:34 +0300	[thread overview]
Message-ID: <20140505074434.GN26890@mwanda> (raw)
In-Reply-To: <53668DFC.6040106@bfs.de>

On Sun, May 04, 2014 at 08:59:08PM +0200, walter harms wrote:
> > @@ -1051,12 +1054,13 @@ tx_b_frame(struct hfc4s8s_btype *bch)
> >  			cnt -= 4;
> >  		}
> >  
> > -		while (cnt--)
> > +		while (cnt--) {
> >  #ifdef HISAX_HFC4S8S_PCIMEM
> >  			fWrite_hfc8(l1->hw, A_FIFO_DATA0, *cp++);
> >  #else
> > -		fWrite_hfc8(l1->hw, *cp++);
> > +			fWrite_hfc8(l1->hw, *cp++);
> >  #endif
> > +		}
> 
> This looks wrong. The read above uses Read_hfc8/fRead_hfc8 (easy to
> confuse but i am not the maintainer ....)
> here we have 2* fWrite_hfc8() ?
> Does this compile with HISAX_HFC4S8S_PCIMEM ??
> 

Yeah.  You're right.  The first fWrite_hfc8() should be Write_hfc8().
This same mistake is made two other places which prevents the driver
from compiling with HISAX_HFC4S8S_PCIMEM.

I will just delete this code since it has been broken since 2.6.12.
Let me resend.

regards,
dan carpenter


  reply	other threads:[~2014-05-05  7:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 20:20 [patch] isdn: hisax: clean up some indenting Dan Carpenter
2014-05-03 20:20 ` Dan Carpenter
2014-05-04 18:59 ` walter harms
2014-05-04 18:59   ` walter harms
2014-05-05  7:44   ` Dan Carpenter [this message]
2014-05-05  7:44     ` Dan Carpenter
2014-05-05  8:53   ` [patch v] isdn: hisax: remove some dead code Dan Carpenter
2014-05-05  8:53     ` Dan Carpenter
2014-05-07 19:44     ` David Miller
2014-05-07 19:44       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140505074434.GN26890@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=isdn@linux-pingi.de \
    --cc=jkosina@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=standby24x7@gmail.com \
    --cc=wharms@bfs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.