From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
"Ext4 Developers List" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] mke2fs: print a message when creating a regular file
Date: Mon, 5 May 2014 10:49:38 -0400 [thread overview]
Message-ID: <20140505144938.GH22287@thunk.org> (raw)
In-Reply-To: <5367A445.9070209@redhat.com>
On Mon, May 05, 2014 at 09:46:29AM -0500, Eric Sandeen wrote:
> > Even if there is some case in the future where dev_size could be left
> > unset, it will be initialized to zero, at which point we will fail
> > safe by skipping the mke2fs_discard_device() call.
>
> I kind of lost the thread here; if it is impossible to be unset, why
> add the check?
>
> And if (!dev_size) what would happen on this path? I guess I need to get
> all the pending patches applied to see what's changed in this area.
It's mostly cosmetic, to be honest. It avoids this confusing line:
5% ./misc/mke2fs -t ext4 /tmp/foo.img 16M
mke2fs 1.42.9 (4-Feb-2014)
Creating regular file /tmp/foo.img
Discarding device: done <========== this nonsense line
Creating filesystem with 16384 1k blocks and 4096 inodes
Filesystem UUID: 515a4e52-79f1-4317-ad61-a87c492c1371
Superblock backups stored on blocks:
8193
...
- Ted
prev parent reply other threads:[~2014-05-05 14:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 13:04 [PATCH 1/3] mke2fs: print a message when creating a regular file Theodore Ts'o
2014-05-05 13:04 ` [PATCH 2/3] mke2fs: print extra information about existing ext2/3/4 file systems Theodore Ts'o
2014-05-05 13:45 ` Lukáš Czerner
2014-05-05 14:04 ` Theodore Ts'o
2014-05-05 14:17 ` Lukáš Czerner
2014-05-05 14:28 ` Theodore Ts'o
2014-05-05 14:38 ` Lukáš Czerner
2014-05-05 14:44 ` Theodore Ts'o
2014-05-05 14:51 ` Lukáš Czerner
2014-05-05 14:57 ` Theodore Ts'o
2014-05-05 16:25 ` Andreas Dilger
2014-05-05 17:50 ` Karel Zak
2014-05-05 18:32 ` Theodore Ts'o
2014-05-06 7:44 ` Karel Zak
2014-05-05 16:30 ` Andreas Dilger
2014-05-05 13:04 ` [PATCH 3/3] mke2fs: check for a partition table and warn if present Theodore Ts'o
2014-05-05 13:52 ` Lukáš Czerner
2014-05-05 13:58 ` Theodore Ts'o
2014-05-05 14:11 ` Lukáš Czerner
2014-05-05 14:20 ` Theodore Ts'o
2014-05-06 12:20 ` Karel Zak
2014-05-06 12:52 ` Lukáš Czerner
2014-05-05 13:41 ` [PATCH 1/3] mke2fs: print a message when creating a regular file Lukáš Czerner
2014-05-05 13:52 ` Theodore Ts'o
2014-05-05 14:04 ` Lukáš Czerner
2014-05-05 14:46 ` Eric Sandeen
2014-05-05 14:49 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505144938.GH22287@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.