All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] qmp: use valid JSON in transaction example
Date: Wed, 7 May 2014 10:37:15 -0400	[thread overview]
Message-ID: <20140507103715.3708b209@redhat.com> (raw)
In-Reply-To: <1399390743-21802-1-git-send-email-eblake@redhat.com>

On Tue,  6 May 2014 09:39:03 -0600
Eric Blake <eblake@redhat.com> wrote:

> Our example should use the correct quotes to match what someone
> could actually pass over the wire.
> 
> * qmp-commands.hx: Use correct JSON quotes.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..e20fcf0 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1165,19 +1165,19 @@ Example:
> 
>  -> { "execute": "transaction",
>       "arguments": { "actions": [
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
>                                           "snapshot-file": "/some/place/my-image",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
> +         { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "snapshot-node-name": "node3432",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
> +         { "type": "blockdev-snapshot-internal-sync", "data" : {
>                                           "device": "ide-hd2",
>                                           "name": "snapshot0" } } ] } }
>  <- { "return": {} }



WARNING: multiple messages have this Message-ID (diff)
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example
Date: Wed, 7 May 2014 10:37:15 -0400	[thread overview]
Message-ID: <20140507103715.3708b209@redhat.com> (raw)
In-Reply-To: <1399390743-21802-1-git-send-email-eblake@redhat.com>

On Tue,  6 May 2014 09:39:03 -0600
Eric Blake <eblake@redhat.com> wrote:

> Our example should use the correct quotes to match what someone
> could actually pass over the wire.
> 
> * qmp-commands.hx: Use correct JSON quotes.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..e20fcf0 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1165,19 +1165,19 @@ Example:
> 
>  -> { "execute": "transaction",
>       "arguments": { "actions": [
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
>                                           "snapshot-file": "/some/place/my-image",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
> +         { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "snapshot-node-name": "node3432",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
> +         { "type": "blockdev-snapshot-internal-sync", "data" : {
>                                           "device": "ide-hd2",
>                                           "name": "snapshot0" } } ] } }
>  <- { "return": {} }

  reply	other threads:[~2014-05-07 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 15:39 [Qemu-trivial] [PATCH] qmp: use valid JSON in transaction example Eric Blake
2014-05-06 15:39 ` [Qemu-devel] " Eric Blake
2014-05-07 14:37 ` Luiz Capitulino [this message]
2014-05-07 14:37   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507103715.3708b209@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.