[PATCH] dell-laptop: Enable rfkill on Inspiron 3437

[PATCH] dell-laptop: Enable rfkill on Inspiron 3437

[Edward Lin]

Create a rfkill whitelist for the specific models.
Add Inspiron 3437 to rfkill whitelist.

Signed-off-by: Edward Lin <yidi.lin@canonical.com>
---
 drivers/platform/x86/dell-laptop.c |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index fed4111..4ead97e 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -271,6 +271,17 @@ static struct dmi_system_id dell_quirks[] = {
 	{ }
 };
 
+static struct dmi_system_id dell_rfkill_whitelist[] = {
+	{
+		.ident = "Dell Inspiron 3437",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3437"),
+		},
+	},
+	{}
+};
+
 static struct calling_interface_buffer *buffer;
 static struct page *bufferpage;
 static DEFINE_MUTEX(buffer_mutex);
@@ -597,7 +608,7 @@ static int __init dell_setup_rfkill(void)
 	if (product &&  (strncmp(product, "Latitude", 8) == 0 ||
 			 strncmp(product, "Precision", 9) == 0))
 		whitelisted = 1;
-	if (!force_rfkill && !whitelisted)
+	if (!force_rfkill && !whitelisted && !dmi_check_system(dell_rfkill_whitelist))
 		return 0;
 
 	get_buffer();
-- 
1.7.9.5

Re: [PATCH] dell-laptop: Enable rfkill on Inspiron 3437

[Matthew Garrett]

The information we had from Dell is that the rfkill functionality isn't 
validated on Inspiron devices. How do we know this works under all 
circumstances?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] dell-laptop: Enable rfkill on Inspiron 3437

[Yidi Lin]

Hi Mattew,

I only have Inspiron 7737 and Inspiron 3437 on hand to verify my patch.
rfkill does not function on Inspiron 7737 with force_rfkill=1 boot parameter.
But it works on Inspiron 3437.
So I only whitelist Inspiron 3437 for rfkill functionality.

Can you give me some advice for validation ?
Thanks.

Edward

On Wed, May 7, 2014 at 7:53 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> The information we had from Dell is that the rfkill functionality isn't
> validated on Inspiron devices. How do we know this works under all
> circumstances?
>
> --
> Matthew Garrett | mjg59@srcf.ucam.org