From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM
Date: Fri, 9 May 2014 22:52:18 +0200 [thread overview]
Message-ID: <20140509205218.GA16051@pd.tnic> (raw)
In-Reply-To: <CAF03EBeKbXr-7+qeARkBRXjystMjs4yEWnmw7q8tgJv9-SPgXA@mail.gmail.com>
On Fri, May 09, 2014 at 03:31:53PM -0500, Thor Thayer wrote:
> Yes, good point. Our hardware can't recover from Double Bit Errors so
> I'll go back to the panic() in that path. I like the flexibility of
> the command line parameter though...
Like to panic by default when the machine is booted normally but to be
able to turn off the panicking with a module parameter?
If so, then you could probably implement a trivial setter called
edac_mc_set_panic_on_ue() in a separate patch.
Then, you call it at the end of altr_sdram_probe().
If you want to turn it off again, you do
echo "0" > /sys/module/edac_core/parameters/edac_mc_panic_on_ue
Something like that...
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Thor Thayer <tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Thor Thayer <tthayer-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
Dinh Nguyen <dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM
Date: Fri, 9 May 2014 22:52:18 +0200 [thread overview]
Message-ID: <20140509205218.GA16051@pd.tnic> (raw)
In-Reply-To: <CAF03EBeKbXr-7+qeARkBRXjystMjs4yEWnmw7q8tgJv9-SPgXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, May 09, 2014 at 03:31:53PM -0500, Thor Thayer wrote:
> Yes, good point. Our hardware can't recover from Double Bit Errors so
> I'll go back to the panic() in that path. I like the flexibility of
> the command line parameter though...
Like to panic by default when the machine is booted normally but to be
able to turn off the panicking with a module parameter?
If so, then you could probably implement a trivial setter called
edac_mc_set_panic_on_ue() in a separate patch.
Then, you call it at the end of altr_sdram_probe().
If you want to turn it off again, you do
echo "0" > /sys/module/edac_core/parameters/edac_mc_panic_on_ue
Something like that...
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Thor Thayer <tthayer.linux@gmail.com>
Cc: Thor Thayer <tthayer@altera.com>,
Rob Herring <robherring2@gmail.com>,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, Kumar Gala <galak@codeaurora.org>,
Rob Landley <rob@landley.net>,
linux@arm.linux.org.uk, Dinh Nguyen <dinguyen@altera.com>,
dougthompson@xmission.com, Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM
Date: Fri, 9 May 2014 22:52:18 +0200 [thread overview]
Message-ID: <20140509205218.GA16051@pd.tnic> (raw)
In-Reply-To: <CAF03EBeKbXr-7+qeARkBRXjystMjs4yEWnmw7q8tgJv9-SPgXA@mail.gmail.com>
On Fri, May 09, 2014 at 03:31:53PM -0500, Thor Thayer wrote:
> Yes, good point. Our hardware can't recover from Double Bit Errors so
> I'll go back to the panic() in that path. I like the flexibility of
> the command line parameter though...
Like to panic by default when the machine is booted normally but to be
able to turn off the panicking with a module parameter?
If so, then you could probably implement a trivial setter called
edac_mc_set_panic_on_ue() in a separate patch.
Then, you call it at the end of altr_sdram_probe().
If you want to turn it off again, you do
echo "0" > /sys/module/edac_core/parameters/edac_mc_panic_on_ue
Something like that...
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-05-09 20:52 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 22:52 edac: altera: Add EDAC support for Altera SDRAM Controller tthayer at altera.com
2014-05-05 22:52 ` tthayer
2014-05-05 22:52 ` tthayer-EIB2kfCEclfQT0dZR+AlfA
2014-05-05 22:52 ` [PATCHv3 1/3] dts: socfpga: Add bindings for Altera SoC SDRAM controller tthayer at altera.com
2014-05-05 22:52 ` tthayer
2014-05-05 22:52 ` tthayer
2014-05-05 23:16 ` Sören Brinkmann
2014-05-05 23:16 ` Sören Brinkmann
2014-05-05 23:16 ` Sören Brinkmann
2014-05-06 18:34 ` Thor Thayer
2014-05-06 18:34 ` Thor Thayer
2014-05-05 22:52 ` [PATCHv3 2/3] dts: socfpga: Add bindings for Altera SoC SDRAM EDAC tthayer at altera.com
2014-05-05 22:52 ` tthayer
2014-05-05 22:52 ` tthayer-EIB2kfCEclfQT0dZR+AlfA
2014-05-05 22:52 ` [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM tthayer at altera.com
2014-05-05 22:52 ` tthayer
2014-05-05 22:52 ` tthayer
2014-05-06 15:42 ` Dinh Nguyen
2014-05-06 15:42 ` Dinh Nguyen
2014-05-06 15:42 ` Dinh Nguyen
2014-05-06 21:00 ` Thor Thayer
2014-05-06 21:00 ` Thor Thayer
2014-05-08 12:05 ` Borislav Petkov
2014-05-08 12:05 ` Borislav Petkov
2014-05-08 12:05 ` Borislav Petkov
2014-05-08 20:37 ` Thor Thayer
2014-05-08 20:37 ` Thor Thayer
2014-05-09 13:52 ` Borislav Petkov
2014-05-09 13:52 ` Borislav Petkov
2014-05-09 20:31 ` Thor Thayer
2014-05-09 20:31 ` Thor Thayer
2014-05-09 20:31 ` Thor Thayer
2014-05-09 20:52 ` Borislav Petkov [this message]
2014-05-09 20:52 ` Borislav Petkov
2014-05-09 20:52 ` Borislav Petkov
2014-05-12 21:58 ` Thor Thayer
2014-05-12 21:58 ` Thor Thayer
2014-05-08 22:44 ` Dinh Nguyen
2014-05-08 22:44 ` Dinh Nguyen
2014-05-08 22:44 ` Dinh Nguyen
2014-05-09 20:04 ` Thor Thayer
2014-05-09 20:04 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509205218.GA16051@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.