All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: Support arch_irq_work_raise() via self IPIs
Date: Mon, 12 May 2014 10:29:56 +0100	[thread overview]
Message-ID: <20140512092956.GB914@arm.com> (raw)
In-Reply-To: <1399760621-10954-1-git-send-email-larry.bassel@linaro.org>

On Sat, May 10, 2014 at 11:23:41PM +0100, Larry Bassel wrote:
> Support for arch_irq_work_raise() was missing from
> arm64 (a prerequisite for FULL_NOHZ).

[...]

> @@ -455,6 +457,14 @@ void arch_send_call_function_single_ipi(int cpu)
>  	smp_cross_call(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE);
>  }
>  
> +#ifdef CONFIG_IRQ_WORK
> +void arch_irq_work_raise(void)
> +{
> +	if (is_smp())
> +		smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK);
> +}
> +#endif

Does this even compile? We're probably better off just checking whether or
not smp_cross_call is NULL.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Larry Bassel <larry.bassel@linaro.org>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"khilman@linaro.org" <khilman@linaro.org>
Subject: Re: [PATCH v2] arm64: Support arch_irq_work_raise() via self IPIs
Date: Mon, 12 May 2014 10:29:56 +0100	[thread overview]
Message-ID: <20140512092956.GB914@arm.com> (raw)
In-Reply-To: <1399760621-10954-1-git-send-email-larry.bassel@linaro.org>

On Sat, May 10, 2014 at 11:23:41PM +0100, Larry Bassel wrote:
> Support for arch_irq_work_raise() was missing from
> arm64 (a prerequisite for FULL_NOHZ).

[...]

> @@ -455,6 +457,14 @@ void arch_send_call_function_single_ipi(int cpu)
>  	smp_cross_call(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE);
>  }
>  
> +#ifdef CONFIG_IRQ_WORK
> +void arch_irq_work_raise(void)
> +{
> +	if (is_smp())
> +		smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK);
> +}
> +#endif

Does this even compile? We're probably better off just checking whether or
not smp_cross_call is NULL.

Will

  reply	other threads:[~2014-05-12  9:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 22:23 [PATCH v2] arm64: Support arch_irq_work_raise() via self IPIs Larry Bassel
2014-05-10 22:23 ` Larry Bassel
2014-05-12  9:29 ` Will Deacon [this message]
2014-05-12  9:29   ` Will Deacon
2014-05-12 15:38   ` Larry Bassel
2014-05-12 15:38     ` Larry Bassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512092956.GB914@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.