All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: mx1_camera: Remove driver
Date: Mon, 12 May 2014 22:25:34 +0800	[thread overview]
Message-ID: <20140512142533.GF8330@dragon> (raw)
In-Reply-To: <1399904280.435992890@f125.i.mail.ru>

On Mon, May 12, 2014 at 06:18:00PM +0400, Alexander Shiyan wrote:
> Mon, 12 May 2014 22:09:34 +0800 ?? Shawn Guo <shawn.guo@freescale.com>:
> > On Sun, May 11, 2014 at 10:09:11AM +0400, Alexander Shiyan wrote:
> > > That driver hasn't been really maintained for a long time. It doesn't
> > > compile in any way, it includes non-existent headers, has no users,
> > > and marked as "broken" more than year. Due to these factors, mx1_camera
> > > is now removed from the tree.
> > > 
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > >  arch/arm/mach-imx/Makefile                      |   3 -
> > >  arch/arm/mach-imx/devices/Kconfig               |   3 -
> > >  arch/arm/mach-imx/devices/Makefile              |   1 -
> > >  arch/arm/mach-imx/devices/devices-common.h      |  10 -
> > >  arch/arm/mach-imx/devices/platform-mx1-camera.c |  42 --
> > >  arch/arm/mach-imx/mx1-camera-fiq-ksym.c         |  18 -
> > >  arch/arm/mach-imx/mx1-camera-fiq.S              |  35 -
> > >  drivers/media/platform/soc_camera/Kconfig       |  13 -
> > >  drivers/media/platform/soc_camera/Makefile      |   1 -
> > >  drivers/media/platform/soc_camera/mx1_camera.c  | 866 ------------------------
> > >  include/linux/platform_data/camera-mx1.h        |  35 -
> > >  11 files changed, 1027 deletions(-)
> > >  delete mode 100644 arch/arm/mach-imx/devices/platform-mx1-camera.c
> > >  delete mode 100644 arch/arm/mach-imx/mx1-camera-fiq-ksym.c
> > >  delete mode 100644 arch/arm/mach-imx/mx1-camera-fiq.S
> > >  delete mode 100644 drivers/media/platform/soc_camera/mx1_camera.c
> > >  delete mode 100644 include/linux/platform_data/camera-mx1.h
> > 
> > Can this patch be split into arch and driver part?  Recently, arm-soc
> > folks do not want to have arch changes go via driver tree, unless that's
> > absolutely necessary.
> 
> Can this patch be applied through arm-soc (imx) tree if it will be approved
> by the linux-media maintainers?

Yes, it can, if linux-media maintainers want.  But I still prefer to two
patches, since I do not see any thing requiring it be one.  Doing that
will ensure we do not run into any merge conflicts.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: mx1_camera: Remove driver
Date: Mon, 12 May 2014 22:25:34 +0800	[thread overview]
Message-ID: <20140512142533.GF8330@dragon> (raw)
In-Reply-To: <1399904280.435992890@f125.i.mail.ru>

On Mon, May 12, 2014 at 06:18:00PM +0400, Alexander Shiyan wrote:
> Mon, 12 May 2014 22:09:34 +0800 от Shawn Guo <shawn.guo@freescale.com>:
> > On Sun, May 11, 2014 at 10:09:11AM +0400, Alexander Shiyan wrote:
> > > That driver hasn't been really maintained for a long time. It doesn't
> > > compile in any way, it includes non-existent headers, has no users,
> > > and marked as "broken" more than year. Due to these factors, mx1_camera
> > > is now removed from the tree.
> > > 
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > >  arch/arm/mach-imx/Makefile                      |   3 -
> > >  arch/arm/mach-imx/devices/Kconfig               |   3 -
> > >  arch/arm/mach-imx/devices/Makefile              |   1 -
> > >  arch/arm/mach-imx/devices/devices-common.h      |  10 -
> > >  arch/arm/mach-imx/devices/platform-mx1-camera.c |  42 --
> > >  arch/arm/mach-imx/mx1-camera-fiq-ksym.c         |  18 -
> > >  arch/arm/mach-imx/mx1-camera-fiq.S              |  35 -
> > >  drivers/media/platform/soc_camera/Kconfig       |  13 -
> > >  drivers/media/platform/soc_camera/Makefile      |   1 -
> > >  drivers/media/platform/soc_camera/mx1_camera.c  | 866 ------------------------
> > >  include/linux/platform_data/camera-mx1.h        |  35 -
> > >  11 files changed, 1027 deletions(-)
> > >  delete mode 100644 arch/arm/mach-imx/devices/platform-mx1-camera.c
> > >  delete mode 100644 arch/arm/mach-imx/mx1-camera-fiq-ksym.c
> > >  delete mode 100644 arch/arm/mach-imx/mx1-camera-fiq.S
> > >  delete mode 100644 drivers/media/platform/soc_camera/mx1_camera.c
> > >  delete mode 100644 include/linux/platform_data/camera-mx1.h
> > 
> > Can this patch be split into arch and driver part?  Recently, arm-soc
> > folks do not want to have arch changes go via driver tree, unless that's
> > absolutely necessary.
> 
> Can this patch be applied through arm-soc (imx) tree if it will be approved
> by the linux-media maintainers?

Yes, it can, if linux-media maintainers want.  But I still prefer to two
patches, since I do not see any thing requiring it be one.  Doing that
will ensure we do not run into any merge conflicts.

Shawn

  reply	other threads:[~2014-05-12 14:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-11  6:09 [PATCH] media: mx1_camera: Remove driver Alexander Shiyan
2014-05-11  6:09 ` Alexander Shiyan
2014-05-12  5:20 ` Sascha Hauer
2014-05-12  5:20   ` Sascha Hauer
2014-05-12  7:26 ` Hans Verkuil
2014-05-12  7:26   ` Hans Verkuil
2014-05-12 14:09 ` Shawn Guo
2014-05-12 14:09   ` Shawn Guo
2014-05-12 14:18   ` Alexander Shiyan
2014-05-12 14:18     ` Alexander Shiyan
2014-05-12 14:25     ` Shawn Guo [this message]
2014-05-12 14:25       ` Shawn Guo
2014-05-12 15:46       ` Alexander Shiyan
2014-05-12 15:46         ` Alexander Shiyan
2014-05-12 16:39         ` Hans Verkuil
2014-05-12 16:39           ` Hans Verkuil
2014-05-18 20:36           ` Guennadi Liakhovetski
2014-05-18 20:36             ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512142533.GF8330@dragon \
    --to=shawn.guo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.