From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remap_file_pages: initialize populate before usage
Date: Mon, 12 May 2014 20:05:04 +0300 [thread overview]
Message-ID: <20140512170504.GA30120@node.dhcp.inet.fi> (raw)
In-Reply-To: <1399898454-14915-1-git-send-email-sasha.levin@oracle.com>
On Mon, May 12, 2014 at 08:40:54AM -0400, Sasha Levin wrote:
> 'populate' wasn't initialized before being used in error paths,
> causing panics when mm_populate() would get called with invalid
> values.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 84dcfc7..2a0e0a8 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2591,7 +2591,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
>
> struct mm_struct *mm = current->mm;
> struct vm_area_struct *vma;
> - unsigned long populate;
> + unsigned long populate = 0;
> unsigned long ret = -EINVAL;
>
> pr_warn_once("%s (%d) uses deprecated remap_file_pages() syscall. "
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remap_file_pages: initialize populate before usage
Date: Mon, 12 May 2014 20:05:04 +0300 [thread overview]
Message-ID: <20140512170504.GA30120@node.dhcp.inet.fi> (raw)
In-Reply-To: <1399898454-14915-1-git-send-email-sasha.levin@oracle.com>
On Mon, May 12, 2014 at 08:40:54AM -0400, Sasha Levin wrote:
> 'populate' wasn't initialized before being used in error paths,
> causing panics when mm_populate() would get called with invalid
> values.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 84dcfc7..2a0e0a8 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2591,7 +2591,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
>
> struct mm_struct *mm = current->mm;
> struct vm_area_struct *vma;
> - unsigned long populate;
> + unsigned long populate = 0;
> unsigned long ret = -EINVAL;
>
> pr_warn_once("%s (%d) uses deprecated remap_file_pages() syscall. "
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-05-12 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 12:40 [PATCH] mm: remap_file_pages: initialize populate before usage Sasha Levin
2014-05-12 12:40 ` Sasha Levin
2014-05-12 17:05 ` Kirill A. Shutemov [this message]
2014-05-12 17:05 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512170504.GA30120@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.