From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/8] clk: sunxi: Implement A31 USB clock
Date: Mon, 12 May 2014 18:32:08 -0700 [thread overview]
Message-ID: <20140513013208.5943.89944@quantum> (raw)
In-Reply-To: <1399923274-6017-2-git-send-email-maxime.ripard@free-electrons.com>
Quoting Maxime Ripard (2014-05-12 12:34:27)
> The A31 USB clock slightly differ from its older counterparts, mostly because
> it has a different gate for each PHY, while the older one had a single gate for
> all the phy.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index bd7dc733c1ca..d9bab75f128b 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -972,6 +972,11 @@ static const struct gates_data sun5i_a13_usb_gates_data __initconst = {
> .reset_mask = 0x03,
> };
>
> +static const struct gates_data sun6i_a31_usb_gates_data __initconst = {
> + .mask = { BIT(18) | BIT(17) | BIT(16) | BIT(10) | BIT(9) | BIT(8) },
> + .reset_mask = BIT(2) | BIT(1) | BIT(0),
> +};
> +
> static void __init sunxi_gates_clk_setup(struct device_node *node,
> struct gates_data *data)
> {
> @@ -1267,6 +1272,7 @@ static const struct of_device_id clk_gates_match[] __initconst = {
> {.compatible = "allwinner,sun6i-a31-apb2-gates-clk", .data = &sun6i_a31_apb2_gates_data,},
> {.compatible = "allwinner,sun4i-a10-usb-clk", .data = &sun4i_a10_usb_gates_data,},
> {.compatible = "allwinner,sun5i-a13-usb-clk", .data = &sun5i_a13_usb_gates_data,},
> + {.compatible = "allwinner,sun6i-a31-usb-clk", .data = &sun6i_a31_usb_gates_data,},
> {}
> };
>
> --
> 1.9.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
"Emilio Lopez" <emilio@elopez.com.ar>,
stern@rowland.harvard.edu, kishon@ti.com, hdegoede@redhat.com
Cc: "Boris Brezillon" <boris@free-electrons.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
shuge@allwinnertech.com, zhuzhenhua@allwinnertech.com,
linux-sunxi@googlegroups.com,
"Maxime Ripard" <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH v3 1/8] clk: sunxi: Implement A31 USB clock
Date: Mon, 12 May 2014 18:32:08 -0700 [thread overview]
Message-ID: <20140513013208.5943.89944@quantum> (raw)
In-Reply-To: <1399923274-6017-2-git-send-email-maxime.ripard@free-electrons.com>
Quoting Maxime Ripard (2014-05-12 12:34:27)
> The A31 USB clock slightly differ from its older counterparts, mostly because
> it has a different gate for each PHY, while the older one had a single gate for
> all the phy.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index bd7dc733c1ca..d9bab75f128b 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -972,6 +972,11 @@ static const struct gates_data sun5i_a13_usb_gates_data __initconst = {
> .reset_mask = 0x03,
> };
>
> +static const struct gates_data sun6i_a31_usb_gates_data __initconst = {
> + .mask = { BIT(18) | BIT(17) | BIT(16) | BIT(10) | BIT(9) | BIT(8) },
> + .reset_mask = BIT(2) | BIT(1) | BIT(0),
> +};
> +
> static void __init sunxi_gates_clk_setup(struct device_node *node,
> struct gates_data *data)
> {
> @@ -1267,6 +1272,7 @@ static const struct of_device_id clk_gates_match[] __initconst = {
> {.compatible = "allwinner,sun6i-a31-apb2-gates-clk", .data = &sun6i_a31_apb2_gates_data,},
> {.compatible = "allwinner,sun4i-a10-usb-clk", .data = &sun4i_a10_usb_gates_data,},
> {.compatible = "allwinner,sun5i-a13-usb-clk", .data = &sun5i_a13_usb_gates_data,},
> + {.compatible = "allwinner,sun6i-a31-usb-clk", .data = &sun6i_a31_usb_gates_data,},
> {}
> };
>
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-05-13 1:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 19:34 [PATCH v3 0/8] Add Allwinner A31 USB support Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-12 19:34 ` [PATCH v3 1/8] clk: sunxi: Implement A31 USB clock Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-13 1:32 ` Mike Turquette [this message]
2014-05-13 1:32 ` Mike Turquette
2014-05-12 19:34 ` [PATCH v3 2/8] ARM: sun6i: Add the USB clocks to the DTSI Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-12 19:34 ` [PATCH v3 3/8] phy: sunxi: Rework phy initialization Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-13 6:39 ` Hans de Goede
2014-05-13 6:39 ` Hans de Goede
2014-05-12 19:34 ` [PATCH v3 4/8] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-12 19:34 ` [PATCH v3 5/8] usb: ehci-platform: add optional reset controller retrieval Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-12 20:06 ` Alan Stern
2014-05-12 20:06 ` Alan Stern
2014-05-13 7:51 ` Maxime Ripard
2014-05-13 7:51 ` Maxime Ripard
2014-05-12 19:34 ` [PATCH v3 6/8] usb: ohci-platform: Enable optional use of reset controller Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-12 19:34 ` [PATCH v3 7/8] ARM: sun6i: dt: Add support for the USB controllers Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
2014-05-12 19:34 ` [PATCH v3 8/8] ARM: sunxi: dt: add APP4-EVB1 board support Maxime Ripard
2014-05-12 19:34 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513013208.5943.89944@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.