* [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs
@ 2014-05-07 8:26 Daniel Vetter
2014-05-07 19:24 ` Patrik Jakobsson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Daniel Vetter @ 2014-05-07 8:26 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Thierry Reding, Alan Cox
Only gma500 is still using this, once that's converted we can kill all
this code. If that conversion doesn't happen soonish I think we should
just move this helper code into the gma500 driver itself to avoid
abuse from new drivers.
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/drm_dp_helper.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index a13f1f51f68e..494219ccdf96 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -213,6 +213,10 @@ i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter)
*
* RETURNS:
* 0 on success, -ERRNO on failure.
+ *
+ * IMPORTANT:
+ * This interface is deprecated, please switch to the new dp aux helpers and
+ * drm_dp_aux_register_i2c_bus().
*/
int
i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
--
1.9.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs
2014-05-07 8:26 [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs Daniel Vetter
@ 2014-05-07 19:24 ` Patrik Jakobsson
2014-05-13 7:38 ` Thierry Reding
2014-05-13 7:36 ` Thierry Reding
2014-05-13 7:49 ` Jani Nikula
2 siblings, 1 reply; 6+ messages in thread
From: Patrik Jakobsson @ 2014-05-07 19:24 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Thierry Reding, DRI Development, Alan Cox
On Wed, May 7, 2014 at 10:26 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Only gma500 is still using this, once that's converted we can kill all
> this code. If that conversion doesn't happen soonish I think we should
> just move this helper code into the gma500 driver itself to avoid
> abuse from new drivers.
I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok
with moving it into gma500.
Thanks for reminding me
Patrik
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a13f1f51f68e..494219ccdf96 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -213,6 +213,10 @@ i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter)
> *
> * RETURNS:
> * 0 on success, -ERRNO on failure.
> + *
> + * IMPORTANT:
> + * This interface is deprecated, please switch to the new dp aux helpers and
> + * drm_dp_aux_register_i2c_bus().
> */
> int
> i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
> --
> 1.9.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs
2014-05-07 19:24 ` Patrik Jakobsson
@ 2014-05-13 7:38 ` Thierry Reding
2014-05-13 12:11 ` Jingoo Han
0 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2014-05-13 7:38 UTC (permalink / raw)
To: Patrik Jakobsson; +Cc: Daniel Vetter, Thierry Reding, DRI Development, Alan Cox
[-- Attachment #1.1: Type: text/plain, Size: 694 bytes --]
On Wed, May 07, 2014 at 09:24:02PM +0200, Patrik Jakobsson wrote:
> On Wed, May 7, 2014 at 10:26 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Only gma500 is still using this, once that's converted we can kill all
> > this code. If that conversion doesn't happen soonish I think we should
> > just move this helper code into the gma500 driver itself to avoid
> > abuse from new drivers.
>
> I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok
> with moving it into gma500.
I don't think there's a need to rush things. In my opinion it's fine if
this stays around for another couple of releases, as long as it's
removed eventually.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs
2014-05-13 7:38 ` Thierry Reding
@ 2014-05-13 12:11 ` Jingoo Han
0 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2014-05-13 12:11 UTC (permalink / raw)
To: 'Thierry Reding', 'Patrik Jakobsson'
Cc: 'Daniel Vetter', 'Thierry Reding',
'DRI Development', 'Alan Cox'
On Tuesday, May 13, 2014 4:38 PM, Thierry Reding wrote:
> On Wed, May 07, 2014 at 09:24:02PM +0200, Patrik Jakobsson wrote:
> > On Wed, May 7, 2014 at 10:26 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > Only gma500 is still using this, once that's converted we can kill all
> > > this code. If that conversion doesn't happen soonish I think we should
> > > just move this helper code into the gma500 driver itself to avoid
> > > abuse from new drivers.
> >
> > I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok
> > with moving it into gma500.
>
> I don't think there's a need to rush things. In my opinion it's fine if
> this stays around for another couple of releases, as long as it's
> removed eventually.
I agree with your opinion. Within few releases, it can be changed
and removed. Actually, marking it as deprecated looks more urgent.
Thanks.
Best regards,
Jingoo Han
>
> Thierry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs
2014-05-07 8:26 [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs Daniel Vetter
2014-05-07 19:24 ` Patrik Jakobsson
@ 2014-05-13 7:36 ` Thierry Reding
2014-05-13 7:49 ` Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2014-05-13 7:36 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Thierry Reding, DRI Development, Alan Cox
[-- Attachment #1.1: Type: text/plain, Size: 643 bytes --]
On Wed, May 07, 2014 at 10:26:41AM +0200, Daniel Vetter wrote:
> Only gma500 is still using this, once that's converted we can kill all
> this code. If that conversion doesn't happen soonish I think we should
> just move this helper code into the gma500 driver itself to avoid
> abuse from new drivers.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs
2014-05-07 8:26 [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs Daniel Vetter
2014-05-07 19:24 ` Patrik Jakobsson
2014-05-13 7:36 ` Thierry Reding
@ 2014-05-13 7:49 ` Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2014-05-13 7:49 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Thierry Reding, Alan Cox
Typo in the subject bugs my OCD, otherwise agreed.
Jani.
On Wed, 07 May 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Only gma500 is still using this, once that's converted we can kill all
> this code. If that conversion doesn't happen soonish I think we should
> just move this helper code into the gma500 driver itself to avoid
> abuse from new drivers.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a13f1f51f68e..494219ccdf96 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -213,6 +213,10 @@ i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter)
> *
> * RETURNS:
> * 0 on success, -ERRNO on failure.
> + *
> + * IMPORTANT:
> + * This interface is deprecated, please switch to the new dp aux helpers and
> + * drm_dp_aux_register_i2c_bus().
> */
> int
> i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
> --
> 1.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-13 12:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07 8:26 [PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs Daniel Vetter
2014-05-07 19:24 ` Patrik Jakobsson
2014-05-13 7:38 ` Thierry Reding
2014-05-13 12:11 ` Jingoo Han
2014-05-13 7:36 ` Thierry Reding
2014-05-13 7:49 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.