From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, jet.chen@intel.com, fengguang.wu@intel.com,
linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sched: fix: initialization of sched_domain_topology for NUMA
Date: Tue, 13 May 2014 10:15:20 +0000 [thread overview]
Message-ID: <20140513101520.GX30445@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1399972261-25693-1-git-send-email-vincent.guittot@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Tue, May 13, 2014 at 11:11:01AM +0200, Vincent Guittot wrote:
> Jet Chen has reported a kernel panics when booting qemu-system-x86_64 with
> kvm64 cpu. A panic occured while building the sched_domain.
>
> In sched_init_numa, we create a new topology table in which both default
> levels and numa levels are copied. The last row of the table must have a null
> pointer in the mask field.
>
> The current implementation doesn't add this last row in the computation of the
> table size. So we add 1 row in the allocation size that will be used as the
> last row of the table. The kzalloc will ensure that the mask field is NULL.
>
> Reported-by: Jet Chen <jet.chen@intel.com>
> Tested-by: Jet Chen <jet.chen@intel.com>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> link: https://lkml.org/lkml/2014/5/12/130
>
> ---
>
> Hi Peter,
>
> Does this commit message contain enough information ?
Yes, thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, jet.chen@intel.com, fengguang.wu@intel.com,
linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sched: fix: initialization of sched_domain_topology for NUMA
Date: Tue, 13 May 2014 12:15:20 +0200 [thread overview]
Message-ID: <20140513101520.GX30445@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1399972261-25693-1-git-send-email-vincent.guittot@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Tue, May 13, 2014 at 11:11:01AM +0200, Vincent Guittot wrote:
> Jet Chen has reported a kernel panics when booting qemu-system-x86_64 with
> kvm64 cpu. A panic occured while building the sched_domain.
>
> In sched_init_numa, we create a new topology table in which both default
> levels and numa levels are copied. The last row of the table must have a null
> pointer in the mask field.
>
> The current implementation doesn't add this last row in the computation of the
> table size. So we add 1 row in the allocation size that will be used as the
> last row of the table. The kzalloc will ensure that the mask field is NULL.
>
> Reported-by: Jet Chen <jet.chen@intel.com>
> Tested-by: Jet Chen <jet.chen@intel.com>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> link: https://lkml.org/lkml/2014/5/12/130
>
> ---
>
> Hi Peter,
>
> Does this commit message contain enough information ?
Yes, thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-13 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 21:16 sched: fix: initialization of sched_domain_topology for NUMA Vincent Guittot
2014-05-12 21:16 ` Vincent Guittot
2014-05-13 8:26 ` Peter Zijlstra
2014-05-13 8:26 ` Peter Zijlstra
2014-05-13 8:33 ` Vincent Guittot
2014-05-13 8:33 ` Vincent Guittot
2014-05-13 9:11 ` Vincent Guittot
2014-05-13 9:11 ` Vincent Guittot
2014-05-13 10:15 ` Peter Zijlstra [this message]
2014-05-13 10:15 ` Peter Zijlstra
2014-05-19 13:09 ` [tip:sched/core] sched: Fix " tip-bot for Vincent Guittot
2014-05-22 12:27 ` [tip:sched/core] sched/numa: " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513101520.GX30445@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=jet.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.