From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com, tj@kernel.org,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
alexandre.belloni@free-electrons.com, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] ata: ahci: add AHCI support for the Berlin BG2Q
Date: Tue, 13 May 2014 14:07:51 +0200 [thread overview]
Message-ID: <20140513120751.GA3213@kwain> (raw)
In-Reply-To: <20140512141221.GE3378@lunn.ch>
Hi Andrew,
On Mon, May 12, 2014 at 04:12:21PM +0200, Andrew Lunn wrote:
> On Mon, May 12, 2014 at 11:16:54AM +0200, Antoine Ténart wrote:
[…]
> I've no idea is this is a good or bad idea, but could you put all the
> above code in the phy driver? It does seem to be mostly phy
> related. Then teach the core ahci code about optional phy nodes in DT.
> You can then probably do without a ahci berlin driver.
The code is PHY related, but the setup done is SATA specific. I think it
makes sense to keep it here. From what I saw lots of PHY drivers only
power up / down the PHYs.
Lots of port setups are done in the SATA framework, so it would separate
related code into two subsystems.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: antoine.tenart@free-electrons.com (Antoine Ténart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] ata: ahci: add AHCI support for the Berlin BG2Q
Date: Tue, 13 May 2014 14:07:51 +0200 [thread overview]
Message-ID: <20140513120751.GA3213@kwain> (raw)
In-Reply-To: <20140512141221.GE3378@lunn.ch>
Hi Andrew,
On Mon, May 12, 2014 at 04:12:21PM +0200, Andrew Lunn wrote:
> On Mon, May 12, 2014 at 11:16:54AM +0200, Antoine T?nart wrote:
[?]
> I've no idea is this is a good or bad idea, but could you put all the
> above code in the phy driver? It does seem to be mostly phy
> related. Then teach the core ahci code about optional phy nodes in DT.
> You can then probably do without a ahci berlin driver.
The code is PHY related, but the setup done is SATA specific. I think it
makes sense to keep it here. From what I saw lots of PHY drivers only
power up / down the PHYs.
Lots of port setups are done in the SATA framework, so it would separate
related code into two subsystems.
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-13 12:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 9:16 [PATCH v2 0/6] ARM: berlin: add AHCI support Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 9:16 ` [PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 12:46 ` Kishon Vijay Abraham I
2014-05-12 12:46 ` Kishon Vijay Abraham I
2014-05-12 12:46 ` Kishon Vijay Abraham I
2014-05-12 14:18 ` Sebastian Hesselbarth
2014-05-12 14:18 ` Sebastian Hesselbarth
2014-05-12 14:18 ` Sebastian Hesselbarth
2014-05-13 5:28 ` Kishon Vijay Abraham I
2014-05-13 5:28 ` Kishon Vijay Abraham I
2014-05-13 5:28 ` Kishon Vijay Abraham I
2014-05-13 12:11 ` Antoine Ténart
2014-05-13 12:11 ` Antoine Ténart
2014-05-13 12:14 ` Antoine Ténart
2014-05-13 12:14 ` Antoine Ténart
2014-05-12 9:16 ` [PATCH v2 2/6] Documentation: bindings: add " Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 9:16 ` [PATCH v2 3/6] ata: ahci: add AHCI support for the Berlin BG2Q Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 14:12 ` Andrew Lunn
2014-05-12 14:12 ` Andrew Lunn
2014-05-13 12:07 ` Antoine Ténart [this message]
2014-05-13 12:07 ` Antoine Ténart
2014-05-12 9:16 ` [PATCH v2 4/6] Documentation: bindings: add the berlin-ahci compatible to the ahci platform Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 9:16 ` [PATCH v2 5/6] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
2014-05-12 9:16 ` [PATCH v2 6/6] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart
2014-05-12 9:16 ` Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513120751.GA3213@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tj@kernel.org \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.