All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] iotests: Use configured python
Date: Tue, 13 May 2014 17:08:27 +0200	[thread overview]
Message-ID: <20140513150827.GD5267@noname.redhat.com> (raw)
In-Reply-To: <1399128428-25546-1-git-send-email-mreitz@redhat.com>

Am 03.05.2014 um 16:47 hat Max Reitz geschrieben:
> Currently, QEMU's iotests rely on /usr/bin/env to start the correct
> Python (that is, at least Python 2.4, but not 3). On systems where
> Python 3 is the default, the user has no clean way of making the iotests
> use the correct binary.
> 
> This commit makes the iotests use the Python selected by configure.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Max, apparently this breaks out-of-tree build from a clean directory:

[16:11] <rth> ../qemu/configure: line 4773:
tests/qemu-iotests/common.env: No such file or directory
[16:11] <rth> eh?
[16:13] <bonzini> kwolf, stefanha: i think you broke srcdir != builddir
[16:14] <pm215> really? my pre-push test suites are all out-of-tree
build (though not ditto from clean)
[16:14] <bonzini> pm215: needs to be clean
[16:14] <bonzini> pm215: tests/qemu-iotests is created at line 5165

Could you post a follow-up to fix this, please?

Kevin

  parent reply	other threads:[~2014-05-13 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 14:47 [Qemu-devel] [PATCH] iotests: Use configured python Max Reitz
2014-05-05 12:26 ` Stefan Hajnoczi
2014-05-05 13:08   ` Peter Maydell
2014-05-05 14:02   ` Eric Blake
2014-05-05 16:25   ` Max Reitz
2014-05-05 16:35     ` Eric Blake
2014-05-06 10:23     ` Stefan Hajnoczi
2014-05-13 15:08 ` Kevin Wolf [this message]
2014-05-14 12:33 ` Markus Armbruster
2014-05-14 23:41   ` Max Reitz
2014-05-15  2:02     ` Fam Zheng
2014-05-15  6:52     ` Markus Armbruster
2014-05-15  8:12       ` Markus Armbruster
2014-05-15 16:56       ` Max Reitz
2014-05-15 17:08         ` Peter Maydell
2014-05-15 17:29           ` Max Reitz
2014-05-15 17:33             ` Peter Maydell
2014-05-15 17:35         ` Markus Armbruster
2014-05-15 17:41           ` Max Reitz
2014-05-15 19:23           ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140513150827.GD5267@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.