Re: [Qemu-devel] [PATCH] iotests: Use configured python

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

On 05/05/2014 10:25 AM, Max Reitz wrote:
>> The code generally uses the older `` notation instead of $().  Please
>> use ``.
> 
> If I'd send a v2 with ``, Eric would probably want me to send a v3 with
> $(). ;-)

I won't make you resend if you are consistent with other code in the
same file.  But I also won't object to someone tackling a generic
cleanup series to nuke ALL use of `` in the codebase.

> 
> I personally don't really care what to use, but so far nobody has picked
> on me for using $(), whereas Eric once criticized my use of `` (which I
> had taken over from other tests).

Consistency trumps aesthetics; I can point out obsolete usages, but
won't reject a commit that is self-consistent in the use of that construct.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]