From: "Michael S. Tsirkin" <mst@redhat.com>
To: Romain Francoise <romain@orebokech.com>
Cc: ddongch@cn.ibm.com, Michael Mueller <mimu@linux.vnet.ibm.com>,
kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
borntraeger@de.ibm.com
Subject: Re: [PATCH v1] vhost: avoid large order allocations
Date: Tue, 13 May 2014 18:15:27 +0300 [thread overview]
Message-ID: <20140513151527.GA28517@redhat.com> (raw)
In-Reply-To: <87tx8tg3a1.fsf@kima.orebokech.com>
On Tue, May 13, 2014 at 04:29:58PM +0200, Romain Francoise wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > Please dont' do this, extra indirection hurts performance.
> > Instead, please change vhost_net_open and scsi to allocate the whole
> > structure with vmalloc if kmalloc fails, along the lines of
> > 74d332c13b2148ae934ea94dac1745ae92efe8e5
>
> Back in January 2013, you didn't seem to think it was a good idea:
>
> https://lkml.org/lkml/2013/1/23/492
Hmm true, and Dave thought the structure's too large.
I'll have to do some benchmarks to see what the effect
of Michael's patch is, performance-wise.
If it's too expensive I can pick up your patch, no need to
repost.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Romain Francoise <romain@orebokech.com>
Cc: Michael Mueller <mimu@linux.vnet.ibm.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, cornelia.huck@de.ibm.com,
ddongch@cn.ibm.com
Subject: Re: [PATCH v1] vhost: avoid large order allocations
Date: Tue, 13 May 2014 18:15:27 +0300 [thread overview]
Message-ID: <20140513151527.GA28517@redhat.com> (raw)
In-Reply-To: <87tx8tg3a1.fsf@kima.orebokech.com>
On Tue, May 13, 2014 at 04:29:58PM +0200, Romain Francoise wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > Please dont' do this, extra indirection hurts performance.
> > Instead, please change vhost_net_open and scsi to allocate the whole
> > structure with vmalloc if kmalloc fails, along the lines of
> > 74d332c13b2148ae934ea94dac1745ae92efe8e5
>
> Back in January 2013, you didn't seem to think it was a good idea:
>
> https://lkml.org/lkml/2013/1/23/492
Hmm true, and Dave thought the structure's too large.
I'll have to do some benchmarks to see what the effect
of Michael's patch is, performance-wise.
If it's too expensive I can pick up your patch, no need to
repost.
--
MST
next prev parent reply other threads:[~2014-05-13 15:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 8:35 [PATCH v1] vhost: avoid large order allocations Michael Mueller
2014-05-13 8:35 ` Michael Mueller
2014-05-13 8:35 ` Michael Mueller
2014-05-13 8:40 ` Michael S. Tsirkin
2014-05-13 8:40 ` Michael S. Tsirkin
2014-05-13 8:57 ` Michael Mueller
2014-05-13 8:57 ` Michael Mueller
2014-05-13 14:29 ` Romain Francoise
2014-05-13 14:29 ` Romain Francoise
2014-05-13 15:07 ` Michael Mueller
2014-05-13 15:07 ` Michael Mueller
2014-05-13 15:15 ` Michael S. Tsirkin [this message]
2014-05-13 15:15 ` Michael S. Tsirkin
2014-05-14 8:11 ` Michael Mueller
2014-05-14 8:11 ` Michael Mueller
2014-06-13 11:56 ` Michael Mueller
2014-06-13 11:56 ` Michael Mueller
-- strict thread matches above, loose matches on Subject: below --
2014-05-13 8:35 Michael Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513151527.GA28517@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=ddongch@cn.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mimu@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=romain@orebokech.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.