From: Tony Lindgren <tony@atomide.com>
To: Pekon Gupta <pekon@ti.com>
Cc: bcousson@baylibre.com, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] ARM: dts: am43x-epos-evm: fix reg and range property of GPMC NAND node
Date: Tue, 13 May 2014 10:32:18 -0700 [thread overview]
Message-ID: <20140513173218.GJ16837@atomide.com> (raw)
In-Reply-To: <1399668412-10818-3-git-send-email-pekon@ti.com>
* Pekon Gupta <pekon@ti.com> [140509 13:48]:
> 1) NAND device memory is not directly accessible to CPU, its indirectly accessed
> via registers. So the 'reg' property for GPMC NAND nodes should be limited to
> address range of internal GPMC registers only.
> 2) Also, minimum granularity of address space under a GPMC chip-select is 16MB
> so 'range' property for GPMC NAND node should specify 16MB as its memory-size
> 3) On AM437x, address map of external memory accessible via GPMC starts from 0x0
>
> Signed-off-by: Pekon Gupta <pekon@ti.com>
> ---
> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index fd29930..63a6a59 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -287,9 +287,9 @@
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&nand_flash_x8>;
> - ranges = <0 0 0x08000000 0x10000000>; /* CS0: NAND */
> + ranges = <0 0 0 0x1000000>; /* CS0: NAND */
> nand@0,0 {
> - reg = <0 0 0>; /* CS0, offset 0 */
> + reg = <0 0 0x380>; /* CS0, offset=0, re-map size=0x380 */
> ti,nand-ecc-opt = "bch8";
> ti,elm-id = <&elm>;
> nand-bus-width = <8>;
>
Here too let's use the standard comments while fixing up the GPMC
ranges.
Tony
next prev parent reply other threads:[~2014-05-13 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 20:46 [PATCH v4 3/6] ARM: dts: dra7: add support for parallel NAND flash Pekon Gupta
2014-05-09 20:46 ` [PATCH v4 4/6] ARM: dts: am43xx: fix starting offset of NAND.filesystem MTD partition Pekon Gupta
2014-05-10 17:02 ` Javier Martinez Canillas
2014-05-09 20:46 ` [PATCH v4 5/6] ARM: dts: am43x-epos-evm: fix reg and range property of GPMC NAND node Pekon Gupta
2014-05-13 17:32 ` Tony Lindgren [this message]
2014-05-09 20:46 ` [PATCH v4 6/6] ARM: dts: am335x-evm: " Pekon Gupta
2014-05-10 17:11 ` Javier Martinez Canillas
2014-05-12 19:44 ` Tony Lindgren
2014-05-10 17:57 ` [PATCH v4 3/6] ARM: dts: dra7: add support for parallel NAND flash Javier Martinez Canillas
2014-05-12 7:03 ` Gupta, Pekon
2014-05-12 8:49 ` Javier Martinez Canillas
2014-05-12 9:05 ` Gupta, Pekon
2014-05-12 9:08 ` Javier Martinez Canillas
2014-05-14 8:25 ` Roger Quadros
2014-05-14 8:47 ` Gupta, Pekon
2014-05-14 9:00 ` Roger Quadros
2014-05-14 9:09 ` Gupta, Pekon
2014-05-14 9:17 ` Roger Quadros
2014-05-14 9:23 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513173218.GJ16837@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=linux-omap@vger.kernel.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.