From: Mateusz Guzik <mguzik@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Josef Bacik <jbacik@fb.com>, Jan Kara <jack@suse.cz>,
Al Viro <viro@ZenIV.linux.org.uk>,
Eric Sandeen <esandeen@redhat.com>
Subject: Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems
Date: Tue, 13 May 2014 21:06:35 +0200 [thread overview]
Message-ID: <20140513190634.GC2738@mguzik.redhat.com> (raw)
In-Reply-To: <1400007621.24350.47.camel@joe-AO725>
On Tue, May 13, 2014 at 12:00:21PM -0700, Joe Perches wrote:
> On Tue, 2014-05-13 at 20:53 +0200, Mateusz Guzik wrote:
> > This is the same code which you can find at the end of the function.
> > I added the label so that I can write freeze printk only once.
>
> Yes, but for a read-only filesystem is the message useful?
>
I see no harm in printing it and it seems more correct given that
s_writers.frozen changed, but I'm fine either way.
btw, I just noticed a copy-pasto - the same message for freezing and
unfreezing found its way into the patch. sigh.
--
Mateusz Guzik
next prev parent reply other threads:[~2014-05-13 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:31 [PATCH 1/2] fs: include device name in error messages about freezing Mateusz Guzik
2014-05-13 18:31 ` [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems Mateusz Guzik
2014-05-13 18:39 ` Joe Perches
2014-05-13 18:53 ` Mateusz Guzik
2014-05-13 19:00 ` Joe Perches
2014-05-13 19:06 ` Mateusz Guzik [this message]
2014-05-14 21:54 ` Dave Chinner
2014-05-15 2:17 ` Theodore Ts'o
2014-05-15 3:04 ` Dave Chinner
2014-05-15 9:42 ` Mateusz Guzik
2014-05-15 10:01 ` Jan Kara
2014-05-15 10:43 ` Lukáš Czerner
2014-05-15 12:47 ` Theodore Ts'o
2014-05-15 13:46 ` Jan Kara
2014-05-15 14:15 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513190634.GC2738@mguzik.redhat.com \
--to=mguzik@redhat.com \
--cc=esandeen@redhat.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.